From: Eric Biggers <ebiggers@kernel.org>
To: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
broonie@kernel.org, ard.biesheuvel@linaro.org,
jonathan.cameron@huawei.com
Subject: Re: [PATCH 1/5] crypto: api - add a helper to (un)register a array of templates
Date: Wed, 16 Jan 2019 09:52:36 -0800 [thread overview]
Message-ID: <20190116175236.GB152952@gmail.com> (raw)
In-Reply-To: <1547607034-40948-2-git-send-email-wangxiongfeng2@huawei.com>
A few nits:
On Wed, Jan 16, 2019 at 10:50:30AM +0800, Xiongfeng Wang wrote:
> This patch add a helper to (un)register a array of templates. The
> following patches will use this helper to simplify the code.
>
> Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>
> ---
> crypto/algapi.c | 27 +++++++++++++++++++++++++++
> include/crypto/algapi.h | 2 ++
> 2 files changed, 29 insertions(+)
>
> diff --git a/crypto/algapi.c b/crypto/algapi.c
> index 8b65ada..59a6599 100644
> --- a/crypto/algapi.c
> +++ b/crypto/algapi.c
> @@ -494,6 +494,24 @@ int crypto_register_template(struct crypto_template *tmpl)
> }
> EXPORT_SYMBOL_GPL(crypto_register_template);
>
> +int crypto_register_templates(struct crypto_template *tmpl, int num)
Can you adjust the parameter names to make it consistent with the other bulk
registration functions?
int crypto_register_templates(struct crypto_template *tmpls, int count)
Note the 's' on 'tmpls'.
> +{
> + int i, err;
> +
> + for (i = 0; i < num; i++) {
> + err = crypto_register_template(&tmpl[i]);
> + if (err)
> + goto out;
> + }
> + return 0;
> +
> +out:
> + for (i -= 1; i >= 0; i--)
Other places write this as: 'for (--i; i >= 0; --i)'
> + crypto_unregister_template(&tmpl[i]);
> + return err;
> +}
> +EXPORT_SYMBOL_GPL(crypto_register_templates);
> +
> void crypto_unregister_template(struct crypto_template *tmpl)
> {
> struct crypto_instance *inst;
> @@ -523,6 +541,15 @@ void crypto_unregister_template(struct crypto_template *tmpl)
> }
> EXPORT_SYMBOL_GPL(crypto_unregister_template);
>
> +void crypto_unregister_templates(struct crypto_template *tmpl, int num)
> +{
Same here.
> + int i;
> +
> + for (i = num - 1; i >= 0; i--)
> + crypto_unregister_template(&tmpl[i]);
> +}
> +EXPORT_SYMBOL_GPL(crypto_unregister_templates);
> +
> static struct crypto_template *__crypto_lookup_template(const char *name)
> {
> struct crypto_template *q, *tmpl = NULL;
> diff --git a/include/crypto/algapi.h b/include/crypto/algapi.h
> index 4a5ad10..e879a20 100644
> --- a/include/crypto/algapi.h
> +++ b/include/crypto/algapi.h
> @@ -143,7 +143,9 @@ struct ablkcipher_walk {
> void crypto_mod_put(struct crypto_alg *alg);
>
> int crypto_register_template(struct crypto_template *tmpl);
> +int crypto_register_templates(struct crypto_template *tmpl, int num);
> void crypto_unregister_template(struct crypto_template *tmpl);
> +void crypto_unregister_templates(struct crypto_template *tmpl, int num);
And here.
- Eric
next prev parent reply other threads:[~2019-01-16 17:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 2:50 [PATCH 0/5] Crypto Cleanup Xiongfeng Wang
2019-01-16 2:50 ` [PATCH 1/5] crypto: api - add a helper to (un)register a array of templates Xiongfeng Wang
2019-01-16 17:52 ` Eric Biggers [this message]
2019-01-16 2:50 ` [PATCH 2/5] crypto: ccm - use template array registering API to simplify the code Xiongfeng Wang
2019-01-16 17:57 ` Eric Biggers
2019-01-16 2:50 ` [PATCH 3/5] crypto: gcm " Xiongfeng Wang
2019-01-16 2:50 ` [PATCH 4/5] crypto: ctr " Xiongfeng Wang
2019-01-16 2:50 ` [PATCH 5/5] crypto: chacha20poly1305 " Xiongfeng Wang
2019-01-16 17:49 ` [PATCH 0/5] Crypto Cleanup Eric Biggers
2019-01-17 2:50 ` Xiongfeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116175236.GB152952@gmail.com \
--to=ebiggers@kernel.org \
--cc=ard.biesheuvel@linaro.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jonathan.cameron@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).