* [PATCH net-next] net/tls: remove unused function tls_sw_sendpage_locked
@ 2019-01-16 2:39 YueHaibing
2019-01-16 2:39 ` [PATCH net-next] net/tls: Make function tls_sw_do_sendpage static YueHaibing
2019-01-17 19:45 ` [PATCH net-next] net/tls: remove unused function tls_sw_sendpage_locked David Miller
0 siblings, 2 replies; 4+ messages in thread
From: YueHaibing @ 2019-01-16 2:39 UTC (permalink / raw)
To: borisp, aviadye, davejwatson, john.fastabend, daniel, davem
Cc: linux-kernel, netdev, YueHaibing
There are no in-tree callers.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/tls/tls_sw.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
index 11cdc8f..c475538 100644
--- a/net/tls/tls_sw.c
+++ b/net/tls/tls_sw.c
@@ -1143,16 +1143,6 @@ int tls_sw_do_sendpage(struct sock *sk, struct page *page,
return copied ? copied : ret;
}
-int tls_sw_sendpage_locked(struct sock *sk, struct page *page,
- int offset, size_t size, int flags)
-{
- if (flags & ~(MSG_MORE | MSG_DONTWAIT | MSG_NOSIGNAL |
- MSG_SENDPAGE_NOTLAST | MSG_SENDPAGE_NOPOLICY))
- return -ENOTSUPP;
-
- return tls_sw_do_sendpage(sk, page, offset, size, flags);
-}
-
int tls_sw_sendpage(struct sock *sk, struct page *page,
int offset, size_t size, int flags)
{
--
2.7.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net-next] net/tls: Make function tls_sw_do_sendpage static
2019-01-16 2:39 [PATCH net-next] net/tls: remove unused function tls_sw_sendpage_locked YueHaibing
@ 2019-01-16 2:39 ` YueHaibing
2019-01-17 19:45 ` David Miller
2019-01-17 19:45 ` [PATCH net-next] net/tls: remove unused function tls_sw_sendpage_locked David Miller
1 sibling, 1 reply; 4+ messages in thread
From: YueHaibing @ 2019-01-16 2:39 UTC (permalink / raw)
To: borisp, aviadye, davejwatson, john.fastabend, daniel, davem
Cc: linux-kernel, netdev, YueHaibing
Fixes the following sparse warning:
net/tls/tls_sw.c:1023:5: warning:
symbol 'tls_sw_do_sendpage' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/tls/tls_sw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
index c475538..b8e50e2 100644
--- a/net/tls/tls_sw.c
+++ b/net/tls/tls_sw.c
@@ -1020,8 +1020,8 @@ int tls_sw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
return copied ? copied : ret;
}
-int tls_sw_do_sendpage(struct sock *sk, struct page *page,
- int offset, size_t size, int flags)
+static int tls_sw_do_sendpage(struct sock *sk, struct page *page,
+ int offset, size_t size, int flags)
{
long timeo = sock_sndtimeo(sk, flags & MSG_DONTWAIT);
struct tls_context *tls_ctx = tls_get_ctx(sk);
--
2.7.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/tls: remove unused function tls_sw_sendpage_locked
2019-01-16 2:39 [PATCH net-next] net/tls: remove unused function tls_sw_sendpage_locked YueHaibing
2019-01-16 2:39 ` [PATCH net-next] net/tls: Make function tls_sw_do_sendpage static YueHaibing
@ 2019-01-17 19:45 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2019-01-17 19:45 UTC (permalink / raw)
To: yuehaibing
Cc: borisp, aviadye, davejwatson, john.fastabend, daniel,
linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 16 Jan 2019 10:39:27 +0800
> There are no in-tree callers.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/tls: Make function tls_sw_do_sendpage static
2019-01-16 2:39 ` [PATCH net-next] net/tls: Make function tls_sw_do_sendpage static YueHaibing
@ 2019-01-17 19:45 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-01-17 19:45 UTC (permalink / raw)
To: yuehaibing
Cc: borisp, aviadye, davejwatson, john.fastabend, daniel,
linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 16 Jan 2019 10:39:28 +0800
> Fixes the following sparse warning:
>
> net/tls/tls_sw.c:1023:5: warning:
> symbol 'tls_sw_do_sendpage' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-17 19:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-16 2:39 [PATCH net-next] net/tls: remove unused function tls_sw_sendpage_locked YueHaibing
2019-01-16 2:39 ` [PATCH net-next] net/tls: Make function tls_sw_do_sendpage static YueHaibing
2019-01-17 19:45 ` David Miller
2019-01-17 19:45 ` [PATCH net-next] net/tls: remove unused function tls_sw_sendpage_locked David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).