* [PATCH v8 2/3] proc: add AVX-512 usage elapsed time to /proc/pid/status
2019-01-17 18:38 [PATCH v8 1/3] x86/fpu: track AVX-512 usage of tasks Aubrey Li
@ 2019-01-17 18:38 ` Aubrey Li
2019-02-11 13:26 ` Thomas Gleixner
2019-01-17 18:38 ` [PATCH v8 3/3] Documentation/filesystems/proc.txt: add AVX512_elapsed_ms Aubrey Li
` (3 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: Aubrey Li @ 2019-01-17 18:38 UTC (permalink / raw)
To: tglx, mingo, peterz, hpa
Cc: ak, tim.c.chen, dave.hansen, arjan, aubrey.li, linux-kernel, Aubrey Li
AVX-512 components use could cause core turbo frequency drop. So
it's useful to expose AVX-512 usage elapsed time as a heuristic hint
for the user space job scheduler to cluster the AVX-512 using tasks
together.
Example:
$ cat /proc/pid/status | grep AVX512_elapsed_ms
AVX512_elapsed_ms: 1020
The number '1020' denotes 1020 millisecond elapsed since last time
context switch the off-CPU task using AVX-512 components, thus the
task could cause core frequency drop.
Or:
$ cat /proc/pid/status | grep AVX512_elapsed_ms
AVX512_elapsed_ms: -1
The number '-1' indicates the task didn't use AVX-512 components
before thus unlikely has frequency drop issue.
User space tools may want to further check by:
$ perf stat --pid <pid> -e core_power.lvl2_turbo_license -- sleep 1
Performance counter stats for process id '3558':
3,251,565,961 core_power.lvl2_turbo_license
1.004031387 seconds time elapsed
Non-zero counter value confirms that the task causes frequency drop.
Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
---
arch/x86/kernel/fpu/xstate.c | 38 ++++++++++++++++++++++++++++++++++++
fs/proc/array.c | 5 +++++
2 files changed, 43 insertions(+)
diff --git a/arch/x86/kernel/fpu/xstate.c b/arch/x86/kernel/fpu/xstate.c
index 87a57b7642d3..c361de2bfb28 100644
--- a/arch/x86/kernel/fpu/xstate.c
+++ b/arch/x86/kernel/fpu/xstate.c
@@ -7,6 +7,7 @@
#include <linux/cpu.h>
#include <linux/mman.h>
#include <linux/pkeys.h>
+#include <linux/seq_file.h>
#include <asm/fpu/api.h>
#include <asm/fpu/internal.h>
@@ -1245,3 +1246,40 @@ int copy_user_to_xstate(struct xregs_state *xsave, const void __user *ubuf)
return 0;
}
+
+/*
+ * Report the amount of time elapsed in millisecond since last AVX512
+ * use in the task.
+ */
+void avx512_state(struct seq_file *m, struct task_struct *task)
+{
+ unsigned long timestamp = task->thread.fpu.avx512_timestamp;
+ long delta;
+
+ if (!timestamp)
+ delta = -1;
+ else {
+ delta = (long)(jiffies - timestamp);
+ /*
+ * Cap to LONG_MAX if time difference > LONG_MAX
+ */
+ if (delta < 0)
+ delta = LONG_MAX;
+ delta = jiffies_to_msecs(delta);
+ }
+
+ seq_put_decimal_ll(m, "AVX512_elapsed_ms:\t", delta);
+ seq_putc(m, '\n');
+}
+
+/*
+ * Report CPU specific thread state
+ */
+void arch_task_state(struct seq_file *m, struct task_struct *task)
+{
+ /*
+ * Report AVX512 state if the processor and build option supported.
+ */
+ if (cpu_feature_enabled(X86_FEATURE_AVX512F))
+ avx512_state(m, task);
+}
diff --git a/fs/proc/array.c b/fs/proc/array.c
index 0ceb3b6b37e7..dd88c2219f08 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -392,6 +392,10 @@ static inline void task_core_dumping(struct seq_file *m, struct mm_struct *mm)
seq_putc(m, '\n');
}
+void __weak arch_task_state(struct seq_file *m, struct task_struct *task)
+{
+}
+
int proc_pid_status(struct seq_file *m, struct pid_namespace *ns,
struct pid *pid, struct task_struct *task)
{
@@ -414,6 +418,7 @@ int proc_pid_status(struct seq_file *m, struct pid_namespace *ns,
task_cpus_allowed(m, task);
cpuset_task_status_allowed(m, task);
task_context_switch_counts(m, task);
+ arch_task_state(m, task);
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v8 2/3] proc: add AVX-512 usage elapsed time to /proc/pid/status
2019-01-17 18:38 ` [PATCH v8 2/3] proc: add AVX-512 usage elapsed time to /proc/pid/status Aubrey Li
@ 2019-02-11 13:26 ` Thomas Gleixner
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Gleixner @ 2019-02-11 13:26 UTC (permalink / raw)
To: Aubrey Li
Cc: mingo, peterz, hpa, ak, tim.c.chen, dave.hansen, arjan,
linux-kernel, Aubrey Li
On Fri, 18 Jan 2019, Aubrey Li wrote:
> Subject: proc: add AVX-512 usage elapsed time to /proc/pid/status
Well, no. This should be split into two patches:
#1 proc/status: Add support for architecture specific output
#2 x86/proc/status: Add AVX-512 usage time
> +/*
> + * Report the amount of time elapsed in millisecond since last AVX512
> + * use in the task.
> + */
> +void avx512_state(struct seq_file *m, struct task_struct *task)
> +{
> + unsigned long timestamp = task->thread.fpu.avx512_timestamp;
> + long delta;
> +
> + if (!timestamp)
> + delta = -1;
> + else {
Still lacks curly brackets around the if () clause
> diff --git a/fs/proc/array.c b/fs/proc/array.c
> index 0ceb3b6b37e7..dd88c2219f08 100644
> --- a/fs/proc/array.c
> +++ b/fs/proc/array.c
> @@ -392,6 +392,10 @@ static inline void task_core_dumping(struct seq_file *m, struct mm_struct *mm)
> seq_putc(m, '\n');
> }
> +void __weak arch_task_state(struct seq_file *m, struct task_struct *task)
Still lacks a function prototype in the appropriate header file and please
rename it to something which makes it clear what this is
about. arch_proc_pid_status() or something like that.
Thanks,
tglx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v8 3/3] Documentation/filesystems/proc.txt: add AVX512_elapsed_ms
2019-01-17 18:38 [PATCH v8 1/3] x86/fpu: track AVX-512 usage of tasks Aubrey Li
2019-01-17 18:38 ` [PATCH v8 2/3] proc: add AVX-512 usage elapsed time to /proc/pid/status Aubrey Li
@ 2019-01-17 18:38 ` Aubrey Li
2019-02-01 5:30 ` [PATCH v8 1/3] x86/fpu: track AVX-512 usage of tasks Li, Aubrey
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Aubrey Li @ 2019-01-17 18:38 UTC (permalink / raw)
To: tglx, mingo, peterz, hpa
Cc: ak, tim.c.chen, dave.hansen, arjan, aubrey.li, linux-kernel, Aubrey Li
Added AVX512_elapsed_ms in /proc/<pid>/status. Report it
in Documentation/filesystems/proc.txt
Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
---
Documentation/filesystems/proc.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/filesystems/proc.txt b/Documentation/filesystems/proc.txt
index 12a5e6e693b6..1bc5d1b1f70b 100644
--- a/Documentation/filesystems/proc.txt
+++ b/Documentation/filesystems/proc.txt
@@ -197,6 +197,7 @@ read the file /proc/PID/status:
Seccomp: 0
voluntary_ctxt_switches: 0
nonvoluntary_ctxt_switches: 1
+ AVX512_elapsed_ms: 1020
This shows you nearly the same information you would get if you viewed it with
the ps command. In fact, ps uses the proc file system to obtain its
@@ -214,7 +215,7 @@ asynchronous manner and the value may not be very precise. To see a precise
snapshot of a moment, you can see /proc/<pid>/smaps file and scan page table.
It's slow but very precise.
-Table 1-2: Contents of the status files (as of 4.8)
+Table 1-2: Contents of the status files (as of 5.0)
..............................................................................
Field Content
Name filename of the executable
@@ -275,6 +276,7 @@ Table 1-2: Contents of the status files (as of 4.8)
Mems_allowed_list Same as previous, but in "list format"
voluntary_ctxt_switches number of voluntary context switches
nonvoluntary_ctxt_switches number of non voluntary context switches
+ AVX512_elapsed_ms time elapsed since last AVX512 use in millisecond
..............................................................................
Table 1-3: Contents of the statm files (as of 2.6.8-rc3)
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v8 1/3] x86/fpu: track AVX-512 usage of tasks
2019-01-17 18:38 [PATCH v8 1/3] x86/fpu: track AVX-512 usage of tasks Aubrey Li
2019-01-17 18:38 ` [PATCH v8 2/3] proc: add AVX-512 usage elapsed time to /proc/pid/status Aubrey Li
2019-01-17 18:38 ` [PATCH v8 3/3] Documentation/filesystems/proc.txt: add AVX512_elapsed_ms Aubrey Li
@ 2019-02-01 5:30 ` Li, Aubrey
2019-02-11 13:20 ` Thomas Gleixner
2019-02-11 13:34 ` [tip:x86/fpu] x86/fpu: Track " tip-bot for Aubrey Li
4 siblings, 0 replies; 7+ messages in thread
From: Li, Aubrey @ 2019-02-01 5:30 UTC (permalink / raw)
To: Aubrey Li, tglx, mingo, peterz, hpa
Cc: ak, tim.c.chen, dave.hansen, arjan, linux-kernel
Hi Thomas,
Just a soft reminder in case you didn't get a chance to look at this version.
To address your concern about jiffies_64 on 32bit kernel, I use jiffies here
instead. And to address jiffies wrap around issue, I use the trick from kernel
micro time_before/after, that is, as long as the time difference <= LONG_MAX
(num of jiffies), no wrap around issue. And if time difference > LONG_MAX,
then capped to LONG_MAX (24 days if HZ=1000). This should be long enough to
determine how to schedule the tasks.
If this is not acceptable, I'll try to limit this feature on 64bit kernel.
Looking forward to your response.
Thanks,
-Aubrey
On 2019/1/18 2:38, Aubrey Li wrote:
> User space tools which do automated task placement need information
> about AVX-512 usage of tasks, because AVX-512 usage could cause core
> turbo frequency drop and impact the running task on the sibling CPU.
>
> The XSAVE hardware structure has bits that indicate when valid state
> is present in registers unique to AVX-512 use. Use these bits to
> indicate when AVX-512 has been in use and add per-task AVX-512 state
> timestamp tracking to context switch.
>
> Well-written AVX-512 applications are expected to clear the AVX-512
> state when not actively using AVX-512 registers, so the tracking
> mechanism is imprecise and can theoretically miss AVX-512 usage during
> context switch. But it has been measured to be precise enough to be
> useful under real-world workloads like tensorflow and linpack.
>
> If higher precision is required, suggest user space tools to use the
> PMU-based mechanisms in combination.
>
> Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Andi Kleen <ak@linux.intel.com>
> Cc: Tim Chen <tim.c.chen@linux.intel.com>
> Cc: Dave Hansen <dave.hansen@intel.com>
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> ---
> arch/x86/include/asm/fpu/internal.h | 7 +++++++
> arch/x86/include/asm/fpu/types.h | 7 +++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/arch/x86/include/asm/fpu/internal.h b/arch/x86/include/asm/fpu/internal.h
> index 69dcdf195b61..c74f7b5f6886 100644
> --- a/arch/x86/include/asm/fpu/internal.h
> +++ b/arch/x86/include/asm/fpu/internal.h
> @@ -411,6 +411,13 @@ static inline int copy_fpregs_to_fpstate(struct fpu *fpu)
> {
> if (likely(use_xsave())) {
> copy_xregs_to_kernel(&fpu->state.xsave);
> +
> + /*
> + * AVX512 state is tracked here because its use is
> + * known to slow the max clock speed of the core.
> + */
> + if (fpu->state.xsave.header.xfeatures & XFEATURE_MASK_AVX512)
> + fpu->avx512_timestamp = jiffies;
> return 1;
> }
>
> diff --git a/arch/x86/include/asm/fpu/types.h b/arch/x86/include/asm/fpu/types.h
> index 202c53918ecf..2e32e178e064 100644
> --- a/arch/x86/include/asm/fpu/types.h
> +++ b/arch/x86/include/asm/fpu/types.h
> @@ -302,6 +302,13 @@ struct fpu {
> */
> unsigned char initialized;
>
> + /*
> + * @avx512_timestamp:
> + *
> + * Records the timestamp of AVX512 use during last context switch.
> + */
> + unsigned long avx512_timestamp;
> +
> /*
> * @state:
> *
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v8 1/3] x86/fpu: track AVX-512 usage of tasks
2019-01-17 18:38 [PATCH v8 1/3] x86/fpu: track AVX-512 usage of tasks Aubrey Li
` (2 preceding siblings ...)
2019-02-01 5:30 ` [PATCH v8 1/3] x86/fpu: track AVX-512 usage of tasks Li, Aubrey
@ 2019-02-11 13:20 ` Thomas Gleixner
2019-02-11 13:34 ` [tip:x86/fpu] x86/fpu: Track " tip-bot for Aubrey Li
4 siblings, 0 replies; 7+ messages in thread
From: Thomas Gleixner @ 2019-02-11 13:20 UTC (permalink / raw)
To: Aubrey Li
Cc: mingo, peterz, hpa, ak, tim.c.chen, dave.hansen, arjan,
linux-kernel, Aubrey Li
On Fri, 18 Jan 2019, Aubrey Li wrote:
> User space tools which do automated task placement need information
> about AVX-512 usage of tasks, because AVX-512 usage could cause core
> turbo frequency drop and impact the running task on the sibling CPU.
>
> The XSAVE hardware structure has bits that indicate when valid state
> is present in registers unique to AVX-512 use. Use these bits to
> indicate when AVX-512 has been in use and add per-task AVX-512 state
> timestamp tracking to context switch.
>
> Well-written AVX-512 applications are expected to clear the AVX-512
> state when not actively using AVX-512 registers, so the tracking
> mechanism is imprecise and can theoretically miss AVX-512 usage during
> context switch. But it has been measured to be precise enough to be
> useful under real-world workloads like tensorflow and linpack.
>
> If higher precision is required, suggest user space tools to use the
> PMU-based mechanisms in combination.
>
> Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
^ permalink raw reply [flat|nested] 7+ messages in thread* [tip:x86/fpu] x86/fpu: Track AVX-512 usage of tasks
2019-01-17 18:38 [PATCH v8 1/3] x86/fpu: track AVX-512 usage of tasks Aubrey Li
` (3 preceding siblings ...)
2019-02-11 13:20 ` Thomas Gleixner
@ 2019-02-11 13:34 ` tip-bot for Aubrey Li
4 siblings, 0 replies; 7+ messages in thread
From: tip-bot for Aubrey Li @ 2019-02-11 13:34 UTC (permalink / raw)
To: linux-tip-commits
Cc: oleg, peterz, torvalds, hpa, dave.hansen, tim.c.chen, luto, tglx,
linux-kernel, mingo, dave.hansen, fenghua.yu, aubrey.li,
aubrey.li, arjan, bp
Commit-ID: 2f7726f955572e587d5f50fbe9b2deed5334bd90
Gitweb: https://git.kernel.org/tip/2f7726f955572e587d5f50fbe9b2deed5334bd90
Author: Aubrey Li <aubrey.li@intel.com>
AuthorDate: Fri, 18 Jan 2019 02:38:20 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 11 Feb 2019 14:28:56 +0100
x86/fpu: Track AVX-512 usage of tasks
User space tools which do automated task placement need information
about AVX-512 usage of tasks, because AVX-512 usage could cause core
turbo frequency drop and impact the running task on the sibling CPU.
The XSAVE hardware structure has bits that indicate when valid state
is present in registers unique to AVX-512 use. Use these bits to
indicate when AVX-512 has been in use and add per-task AVX-512 state
timestamp tracking to context switch.
Well-written AVX-512 applications are expected to clear the AVX-512
state when not actively using AVX-512 registers, so the tracking
mechanism is imprecise and can theoretically miss AVX-512 usage during
context switch. But it has been measured to be precise enough to be
useful under real-world workloads like tensorflow and linpack.
If higher precision is required, suggest user space tools to use the
PMU-based mechanisms in combination.
Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: aubrey.li@intel.com
Link: http://lkml.kernel.org/r/20190117183822.31333-1-aubrey.li@intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/include/asm/fpu/internal.h | 7 +++++++
arch/x86/include/asm/fpu/types.h | 7 +++++++
2 files changed, 14 insertions(+)
diff --git a/arch/x86/include/asm/fpu/internal.h b/arch/x86/include/asm/fpu/internal.h
index 5d536e3dcc6d..fb04a3ded7dd 100644
--- a/arch/x86/include/asm/fpu/internal.h
+++ b/arch/x86/include/asm/fpu/internal.h
@@ -376,6 +376,13 @@ static inline int copy_fpregs_to_fpstate(struct fpu *fpu)
{
if (likely(use_xsave())) {
copy_xregs_to_kernel(&fpu->state.xsave);
+
+ /*
+ * AVX512 state is tracked here because its use is
+ * known to slow the max clock speed of the core.
+ */
+ if (fpu->state.xsave.header.xfeatures & XFEATURE_MASK_AVX512)
+ fpu->avx512_timestamp = jiffies;
return 1;
}
diff --git a/arch/x86/include/asm/fpu/types.h b/arch/x86/include/asm/fpu/types.h
index 202c53918ecf..2e32e178e064 100644
--- a/arch/x86/include/asm/fpu/types.h
+++ b/arch/x86/include/asm/fpu/types.h
@@ -302,6 +302,13 @@ struct fpu {
*/
unsigned char initialized;
+ /*
+ * @avx512_timestamp:
+ *
+ * Records the timestamp of AVX512 use during last context switch.
+ */
+ unsigned long avx512_timestamp;
+
/*
* @state:
*
^ permalink raw reply related [flat|nested] 7+ messages in thread