* [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again
@ 2019-01-18 5:30 Masahiro Yamada
2019-01-18 6:19 ` Boris Brezillon
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Masahiro Yamada @ 2019-01-18 5:30 UTC (permalink / raw)
To: linux-mtd, Boris Brezillon, Miquel Raynal
Cc: Masahiro Yamada, linux-stable # v4 . 20, Brian Norris,
linux-kernel, Marek Vasut, Richard Weinberger, David Woodhouse,
Boris Brezillon
Commit 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to
nand_controller_ops") missed to invert the if-conditonal for denali.
Since then, the Denali NAND driver cannnot invoke setup_data_interface.
Fixes: 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops")
Cc: linux-stable <stable@vger.kernel.org> # v4.20
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/mtd/nand/raw/denali.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c
index eebac35..6e8edc9 100644
--- a/drivers/mtd/nand/raw/denali.c
+++ b/drivers/mtd/nand/raw/denali.c
@@ -1322,7 +1322,7 @@ int denali_init(struct denali_nand_info *denali)
}
/* clk rate info is needed for setup_data_interface */
- if (denali->clk_rate && denali->clk_x_rate)
+ if (!denali->clk_rate || !denali->clk_x_rate)
chip->options |= NAND_KEEP_TIMINGS;
chip->legacy.dummy_controller.ops = &denali_controller_ops;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again
2019-01-18 5:30 [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again Masahiro Yamada
@ 2019-01-18 6:19 ` Boris Brezillon
2019-01-18 6:21 ` Masahiro Yamada
2019-01-18 8:52 ` Miquel Raynal
2019-01-18 11:43 ` Boris Brezillon
2 siblings, 1 reply; 5+ messages in thread
From: Boris Brezillon @ 2019-01-18 6:19 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-mtd, Boris Brezillon, Miquel Raynal, Marek Vasut,
Richard Weinberger, linux-kernel, linux-stable # v4 . 20,
Brian Norris, David Woodhouse
On Fri, 18 Jan 2019 14:30:38 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> Commit 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to
> nand_controller_ops") missed to invert the if-conditonal for denali.
> Since then, the Denali NAND driver cannnot invoke setup_data_interface.
>
> Fixes: 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops")
> Cc: linux-stable <stable@vger.kernel.org> # v4.20
Commit 7a08dbaedd36 was merged in 5.0, I'll drop Cc stable when
applying.
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/mtd/nand/raw/denali.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c
> index eebac35..6e8edc9 100644
> --- a/drivers/mtd/nand/raw/denali.c
> +++ b/drivers/mtd/nand/raw/denali.c
> @@ -1322,7 +1322,7 @@ int denali_init(struct denali_nand_info *denali)
> }
>
> /* clk rate info is needed for setup_data_interface */
> - if (denali->clk_rate && denali->clk_x_rate)
> + if (!denali->clk_rate || !denali->clk_x_rate)
> chip->options |= NAND_KEEP_TIMINGS;
>
> chip->legacy.dummy_controller.ops = &denali_controller_ops;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again
2019-01-18 6:19 ` Boris Brezillon
@ 2019-01-18 6:21 ` Masahiro Yamada
0 siblings, 0 replies; 5+ messages in thread
From: Masahiro Yamada @ 2019-01-18 6:21 UTC (permalink / raw)
To: Boris Brezillon
Cc: Marek Vasut, Richard Weinberger, Linux Kernel Mailing List,
linux-stable # v4 . 20, Boris Brezillon, linux-mtd,
Miquel Raynal, Brian Norris, David Woodhouse
On Fri, Jan 18, 2019 at 3:19 PM Boris Brezillon <bbrezillon@kernel.org> wrote:
>
> On Fri, 18 Jan 2019 14:30:38 +0900
> Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
> > Commit 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to
> > nand_controller_ops") missed to invert the if-conditonal for denali.
> > Since then, the Denali NAND driver cannnot invoke setup_data_interface.
> >
> > Fixes: 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops")
> > Cc: linux-stable <stable@vger.kernel.org> # v4.20
>
> Commit 7a08dbaedd36 was merged in 5.0, I'll drop Cc stable when
> applying.
Ah, right. Thanks.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again
2019-01-18 5:30 [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again Masahiro Yamada
2019-01-18 6:19 ` Boris Brezillon
@ 2019-01-18 8:52 ` Miquel Raynal
2019-01-18 11:43 ` Boris Brezillon
2 siblings, 0 replies; 5+ messages in thread
From: Miquel Raynal @ 2019-01-18 8:52 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-mtd, Boris Brezillon, linux-stable # v4 . 20, Brian Norris,
linux-kernel, Marek Vasut, Richard Weinberger, David Woodhouse,
Boris Brezillon
Hi Masahiro,
Masahiro Yamada <yamada.masahiro@socionext.com> wrote on Fri, 18 Jan
2019 14:30:38 +0900:
> Commit 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to
> nand_controller_ops") missed to invert the if-conditonal for denali.
> Since then, the Denali NAND driver cannnot invoke setup_data_interface.
>
> Fixes: 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops")
> Cc: linux-stable <stable@vger.kernel.org> # v4.20
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: mtd: rawnand: denali: get ->setup_data_interface() working again
2019-01-18 5:30 [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again Masahiro Yamada
2019-01-18 6:19 ` Boris Brezillon
2019-01-18 8:52 ` Miquel Raynal
@ 2019-01-18 11:43 ` Boris Brezillon
2 siblings, 0 replies; 5+ messages in thread
From: Boris Brezillon @ 2019-01-18 11:43 UTC (permalink / raw)
To: Masahiro Yamada, linux-mtd, Boris Brezillon, Miquel Raynal
Cc: Boris Brezillon, Marek Vasut, Richard Weinberger, linux-kernel,
linux-stable # v4 . 20, Brian Norris, David Woodhouse
On Fri, 2019-01-18 at 05:30:38 UTC, Masahiro Yamada wrote:
> Commit 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to
> nand_controller_ops") missed to invert the if-conditonal for denali.
> Since then, the Denali NAND driver cannnot invoke setup_data_interface.
>
> Fixes: 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops")
> Cc: linux-stable <stable@vger.kernel.org> # v4.20
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied to http://git.infradead.org/linux-mtd.git mtd/fixes, thanks.
Boris
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-18 11:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 5:30 [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again Masahiro Yamada
2019-01-18 6:19 ` Boris Brezillon
2019-01-18 6:21 ` Masahiro Yamada
2019-01-18 8:52 ` Miquel Raynal
2019-01-18 11:43 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).