* [PATCH 1/2] regulator: lochnagar: Add missing MODULE_DEVICE_TABLE
@ 2019-01-18 11:36 Charles Keepax
2019-01-18 11:36 ` [PATCH 2/2] regulator: lochnagar: Remove redundant MODULE_ALIAS Charles Keepax
0 siblings, 1 reply; 4+ messages in thread
From: Charles Keepax @ 2019-01-18 11:36 UTC (permalink / raw)
To: broonie; +Cc: lgirdwood, linux-kernel, patches
Add the missing MODULE_DEVICE_TABLE and remove the comma from the
separator on the end of the of_device_id array.
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
drivers/regulator/lochnagar-regulator.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/lochnagar-regulator.c b/drivers/regulator/lochnagar-regulator.c
index 818d204105186..4962d13659aab 100644
--- a/drivers/regulator/lochnagar-regulator.c
+++ b/drivers/regulator/lochnagar-regulator.c
@@ -232,8 +232,9 @@ static const struct of_device_id lochnagar_of_match[] = {
.compatible = "cirrus,lochnagar2-vddcore",
.data = &lochnagar_regulators[LOCHNAGAR_VDDCORE],
},
- {},
+ {}
};
+MODULE_DEVICE_TABLE(of, lochnagar_of_match);
static int lochnagar_regulator_probe(struct platform_device *pdev)
{
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] regulator: lochnagar: Remove redundant MODULE_ALIAS
2019-01-18 11:36 [PATCH 1/2] regulator: lochnagar: Add missing MODULE_DEVICE_TABLE Charles Keepax
@ 2019-01-18 11:36 ` Charles Keepax
2019-01-18 17:28 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Charles Keepax @ 2019-01-18 11:36 UTC (permalink / raw)
To: broonie; +Cc: lgirdwood, linux-kernel, patches
The module alias has no effect as the driver can only be loaded through
device tree at this time.
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
drivers/regulator/lochnagar-regulator.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/regulator/lochnagar-regulator.c b/drivers/regulator/lochnagar-regulator.c
index 4962d13659aab..41de3b715b4db 100644
--- a/drivers/regulator/lochnagar-regulator.c
+++ b/drivers/regulator/lochnagar-regulator.c
@@ -280,4 +280,3 @@ module_platform_driver(lochnagar_regulator_driver);
MODULE_AUTHOR("Charles Keepax <ckeepax@opensource.cirrus.com>");
MODULE_DESCRIPTION("Regulator driver for Cirrus Logic Lochnagar Board");
MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("platform:lochnagar-regulator");
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] regulator: lochnagar: Remove redundant MODULE_ALIAS
2019-01-18 11:36 ` [PATCH 2/2] regulator: lochnagar: Remove redundant MODULE_ALIAS Charles Keepax
@ 2019-01-18 17:28 ` Mark Brown
2019-01-21 9:21 ` Charles Keepax
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2019-01-18 17:28 UTC (permalink / raw)
To: Charles Keepax; +Cc: lgirdwood, linux-kernel, patches
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
On Fri, Jan 18, 2019 at 11:36:31AM +0000, Charles Keepax wrote:
> The module alias has no effect as the driver can only be loaded through
> device tree at this time.
It also does no harm...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] regulator: lochnagar: Remove redundant MODULE_ALIAS
2019-01-18 17:28 ` Mark Brown
@ 2019-01-21 9:21 ` Charles Keepax
0 siblings, 0 replies; 4+ messages in thread
From: Charles Keepax @ 2019-01-21 9:21 UTC (permalink / raw)
To: Mark Brown; +Cc: lgirdwood, linux-kernel, patches
On Fri, Jan 18, 2019 at 05:28:54PM +0000, Mark Brown wrote:
> On Fri, Jan 18, 2019 at 11:36:31AM +0000, Charles Keepax wrote:
> > The module alias has no effect as the driver can only be loaded through
> > device tree at this time.
>
> It also does no harm...
Indeed yes, I have no problem with leaving it.
Thanks,
Charles
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-21 9:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 11:36 [PATCH 1/2] regulator: lochnagar: Add missing MODULE_DEVICE_TABLE Charles Keepax
2019-01-18 11:36 ` [PATCH 2/2] regulator: lochnagar: Remove redundant MODULE_ALIAS Charles Keepax
2019-01-18 17:28 ` Mark Brown
2019-01-21 9:21 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).