[PATCH] ASoC: dapm: Skip suspending widgets with ignore flag

[PATCH] ASoC: dapm: Skip suspending widgets with ignore flag

[Zhiwei Jiang]

For endpoint wigdets which have set the suspend ignore flag, asoc
shouldn't mark them as dirty when ASoC suspend function is called.

Signed-off-by: Zhiwei Jiang <qq282012236@gmail.com>
---
 sound/soc/soc-dapm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index a5178845065b..68c49090f561 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -278,7 +278,7 @@ void dapm_mark_endpoints_dirty(struct snd_soc_card *card)
 	mutex_lock(&card->dapm_mutex);
 
 	list_for_each_entry(w, &card->widgets, list) {
-		if (w->is_ep) {
+		if (w->is_ep && !w->ignore_suspend) {
 			dapm_mark_dirty(w, "Rechecking endpoints");
 			if (w->is_ep & SND_SOC_DAPM_EP_SINK)
 				dapm_widget_invalidate_output_paths(w);
-- 
2.19.0

Re: [PATCH] ASoC: dapm: Skip suspending widgets with ignore flag

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

On Mon, Jan 21, 2019 at 10:48:18PM +0800, Zhiwei Jiang wrote:
> For endpoint wigdets which have set the suspend ignore flag, asoc
> shouldn't mark them as dirty when ASoC suspend function is called.

Why not?  It will cost us a bit of time confirming that they should be
kept enabled if they're part of a valid path but it also ensures that
we've reexamined everything which is a bit safer.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]