From: Rob Herring <robh@kernel.org>
To: Faiz Abbas <faiz_abbas@ti.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-mmc@vger.kernel.org, zhang.chunyan@linaro.org,
kishon@ti.com, adrian.hunter@intel.com, mark.rutland@arm.com,
ulf.hansson@linaro.org
Subject: Re: [PATCH 3/7] dt-bindings: sdhci-omap: Add example for using external dma
Date: Mon, 21 Jan 2019 17:20:57 -0600 [thread overview]
Message-ID: <20190121232057.GA30919@bogus> (raw)
In-Reply-To: <20190111110851.6805-4-faiz_abbas@ti.com>
On Fri, Jan 11, 2019 at 04:38:47PM +0530, Faiz Abbas wrote:
> From: Chunyan Zhang <zhang.chunyan@linaro.org>
The subject is misleading. You are adding new properties, not just
changing an example.
>
> sdhci-omap can support both external dma controller via dmaengine
> framework as well as ADMA which standard SD host controller
> provides.
>
> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> ---
> Documentation/devicetree/bindings/mmc/sdhci-omap.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
> index 72c4dec7e1db..f8914a2a2aec 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
> @@ -14,6 +14,11 @@ Required properties:
> "ddr_1_8v-rev11", "ddr_1_8v" or "ddr_3_3v", "hs200_1_8v-rev11",
> "hs200_1_8v",
> - pinctrl-<n> : Pinctrl states as described in bindings/pinctrl/pinctrl-bindings.txt
> +- dmas: List of DMA specifiers with the controller specific format as described
> + in the generic DMA client binding. A tx and rx specifier is required.
> +- dma-names: List of DMA request names. These strings correspond 1:1 with the
> + DMA specifiers listed in dmas. The string naming is to be "rx"
> + and "tx" for RX and TX DMA requests, respectively.
The ordering of rx and tx should be defined and you have a mixture.
>
> Example:
> mmc1: mmc@4809c000 {
> @@ -22,4 +27,6 @@ Example:
> ti,hwmods = "mmc1";
> bus-width = <4>;
> vmmc-supply = <&vmmc>; /* phandle to regulator node */
> + dmas = <&sdma 61 &sdma 62>;
> + dma-names = "tx", "rx";
> };
> --
> 2.19.2
>
next prev parent reply other threads:[~2019-01-21 23:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 11:08 [PATCH 0/7] Port am335 and am437 devices to sdhci-omap Faiz Abbas
2019-01-11 11:08 ` [PATCH 1/7] mmc: sdhci: add support for using external DMA devices Faiz Abbas
2019-01-14 8:45 ` Adrian Hunter
2019-01-24 11:40 ` Adrian Hunter
2019-01-28 10:20 ` Chunyan Zhang
2019-01-28 10:43 ` Faiz Abbas
2019-01-28 11:46 ` Chunyan Zhang
2019-01-29 11:53 ` Faiz Abbas
2019-01-30 5:01 ` Chunyan Zhang
2019-01-30 11:05 ` Chunyan Zhang
2019-01-31 12:32 ` Faiz Abbas
2019-02-11 12:23 ` Faiz Abbas
2019-01-11 11:08 ` [PATCH 2/7] mmc: sdhci-omap: Add using external dma Faiz Abbas
2019-01-11 11:08 ` [PATCH 3/7] dt-bindings: sdhci-omap: Add example for " Faiz Abbas
2019-01-21 23:20 ` Rob Herring [this message]
2019-01-22 8:47 ` [PATCH] dt-bindings: sdhci-omap: Add properties " Chunyan Zhang
2019-01-22 10:20 ` Faiz Abbas
2019-01-23 2:44 ` Chunyan Zhang
2019-01-11 11:08 ` [PATCH 4/7] mmc: sdhci: Add quirk for disabling DTO during erase command Faiz Abbas
2019-01-24 12:08 ` Adrian Hunter
2019-01-28 11:19 ` Faiz Abbas
2019-01-11 11:08 ` [PATCH 5/7] mmc: sdhci-omap: Add DISABLE_DTO_FOR_ERASE Quirk Faiz Abbas
2019-01-11 11:08 ` [PATCH 6/7] dt-bindings: sdhci-omap: Add am335x and am437x specific bindings Faiz Abbas
2019-01-21 23:21 ` Rob Herring
2019-01-11 11:08 ` [PATCH 7/7] mmc: sdhci-omap: Add am335x and am437x specific compatibles Faiz Abbas
2019-01-24 9:44 ` [PATCH 0/7] Port am335 and am437 devices to sdhci-omap Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121232057.GA30919@bogus \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ulf.hansson@linaro.org \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).