From: Faiz Abbas <faiz_abbas@ti.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-mmc@vger.kernel.org>
Cc: <zhang.chunyan@linaro.org>, <kishon@ti.com>,
<mark.rutland@arm.com>, <robh+dt@kernel.org>,
<ulf.hansson@linaro.org>
Subject: Re: [PATCH 4/7] mmc: sdhci: Add quirk for disabling DTO during erase command
Date: Mon, 28 Jan 2019 16:49:20 +0530 [thread overview]
Message-ID: <3ca3f7d3-cc75-f616-4c13-b044c8e52d4d@ti.com> (raw)
In-Reply-To: <8c5875db-016c-c416-7356-d7a26d8d2a0e@intel.com>
Hi Adrian,
On 24/01/19 5:38 PM, Adrian Hunter wrote:
> On 11/01/19 1:08 PM, Faiz Abbas wrote:
>> Some controllers might prematurely issue a data timeout during an erase
>> command. Add a quirk to disable the interrupt when an erase command is
>> issued.
>
> I might have already asked this, but would it be possible to use the
> existing SDHCI_QUIRK2_DISABLE_HW_TIMEOUT quirk?
This looks promising. Let me look into this. In any case, I should
probably move this to something like sdhci_set_timeout and use
sdhci_set_data_timeout_irq().
I was following 93caf8e69eac ("omap_hsmmc: add erase capability") for
adding this.
Thanks,
Faiz
>
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>> ---
>> drivers/mmc/host/sdhci.c | 8 ++++++++
>> drivers/mmc/host/sdhci.h | 2 ++
>> 2 files changed, 10 insertions(+)
>>
>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
>> index 4a9044c06e21..cfd716aee552 100644
>> --- a/drivers/mmc/host/sdhci.c
>> +++ b/drivers/mmc/host/sdhci.c
>> @@ -1560,6 +1560,14 @@ void sdhci_send_command(struct sdhci_host *host, struct mmc_command *cmd)
>> /* Initially, a command has no error */
>> cmd->error = 0;
>>
>> + if (cmd->opcode == MMC_ERASE &&
>> + (host->quirks2 & SDHCI_QUIRK2_DISABLE_DTO_FOR_ERASE)) {
>> + mask = sdhci_readl(host, SDHCI_INT_ENABLE);
>> + mask &= ~SDHCI_INT_DATA_TIMEOUT;
>> + sdhci_writel(host, mask, SDHCI_INT_ENABLE);
>> + sdhci_writel(host, mask, SDHCI_SIGNAL_ENABLE);
>> + }
>> +
>> if ((host->quirks2 & SDHCI_QUIRK2_STOP_WITH_TC) &&
>> cmd->opcode == MMC_STOP_TRANSMISSION)
>> cmd->flags |= MMC_RSP_BUSY;
>> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
>> index 7a52823ebef4..d0c6d4fe5371 100644
>> --- a/drivers/mmc/host/sdhci.h
>> +++ b/drivers/mmc/host/sdhci.h
>> @@ -479,6 +479,8 @@ struct sdhci_host {
>> * block count.
>> */
>> #define SDHCI_QUIRK2_USE_32BIT_BLK_CNT (1<<18)
>> +/* Controller needs to disable DTO for erase command */
>> +#define SDHCI_QUIRK2_DISABLE_DTO_FOR_ERASE (1<<19)
>>
>> int irq; /* Device IRQ */
>> void __iomem *ioaddr; /* Mapped address */
>>
>
next prev parent reply other threads:[~2019-01-28 11:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 11:08 [PATCH 0/7] Port am335 and am437 devices to sdhci-omap Faiz Abbas
2019-01-11 11:08 ` [PATCH 1/7] mmc: sdhci: add support for using external DMA devices Faiz Abbas
2019-01-14 8:45 ` Adrian Hunter
2019-01-24 11:40 ` Adrian Hunter
2019-01-28 10:20 ` Chunyan Zhang
2019-01-28 10:43 ` Faiz Abbas
2019-01-28 11:46 ` Chunyan Zhang
2019-01-29 11:53 ` Faiz Abbas
2019-01-30 5:01 ` Chunyan Zhang
2019-01-30 11:05 ` Chunyan Zhang
2019-01-31 12:32 ` Faiz Abbas
2019-02-11 12:23 ` Faiz Abbas
2019-01-11 11:08 ` [PATCH 2/7] mmc: sdhci-omap: Add using external dma Faiz Abbas
2019-01-11 11:08 ` [PATCH 3/7] dt-bindings: sdhci-omap: Add example for " Faiz Abbas
2019-01-21 23:20 ` Rob Herring
2019-01-22 8:47 ` [PATCH] dt-bindings: sdhci-omap: Add properties " Chunyan Zhang
2019-01-22 10:20 ` Faiz Abbas
2019-01-23 2:44 ` Chunyan Zhang
2019-01-11 11:08 ` [PATCH 4/7] mmc: sdhci: Add quirk for disabling DTO during erase command Faiz Abbas
2019-01-24 12:08 ` Adrian Hunter
2019-01-28 11:19 ` Faiz Abbas [this message]
2019-01-11 11:08 ` [PATCH 5/7] mmc: sdhci-omap: Add DISABLE_DTO_FOR_ERASE Quirk Faiz Abbas
2019-01-11 11:08 ` [PATCH 6/7] dt-bindings: sdhci-omap: Add am335x and am437x specific bindings Faiz Abbas
2019-01-21 23:21 ` Rob Herring
2019-01-11 11:08 ` [PATCH 7/7] mmc: sdhci-omap: Add am335x and am437x specific compatibles Faiz Abbas
2019-01-24 9:44 ` [PATCH 0/7] Port am335 and am437 devices to sdhci-omap Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ca3f7d3-cc75-f616-4c13-b044c8e52d4d@ti.com \
--to=faiz_abbas@ti.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).