* [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS
@ 2019-01-21 23:31 Sinan Kaya
2019-01-22 10:15 ` Luciano Coelho
0 siblings, 1 reply; 5+ messages in thread
From: Sinan Kaya @ 2019-01-21 23:31 UTC (permalink / raw)
To: linux-next
Cc: Sinan Kaya, Johannes Berg, Emmanuel Grumbach, Luca Coelho,
Intel Linux Wireless, Kalle Valo, David S. Miller,
open list:INTEL WIRELESS WIFI LINK (iwlwifi),
open list:NETWORKING DRIVERS, open list
There is an unresolved dependency as follows:
IWLWIFI_LEDS selects MAC80211_LEDS.
MAC80211_LEDS depends on MAC80211.
It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 (n)
WARNING: unmet direct dependencies detected for MAC80211_LEDS
Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] && LEDS_CLASS [=y]
Selected by [y]:
- IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=y])
Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this
configuration.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/net/wireless/intel/iwlwifi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
index 491ca3c8b43c..74f0d0bbed34 100644
--- a/drivers/net/wireless/intel/iwlwifi/Kconfig
+++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
@@ -46,7 +46,7 @@ if IWLWIFI
config IWLWIFI_LEDS
bool
- depends on LEDS_CLASS=y || LEDS_CLASS=IWLWIFI
+ depends on MAC80211 && (LEDS_CLASS=y || LEDS_CLASS=IWLWIFI)
select LEDS_TRIGGERS
select MAC80211_LEDS
default y
--
2.19.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS
2019-01-21 23:31 [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS Sinan Kaya
@ 2019-01-22 10:15 ` Luciano Coelho
2019-01-22 16:12 ` Sinan Kaya
0 siblings, 1 reply; 5+ messages in thread
From: Luciano Coelho @ 2019-01-22 10:15 UTC (permalink / raw)
To: Sinan Kaya, linux-next
Cc: Johannes Berg, Emmanuel Grumbach, Intel Linux Wireless,
Kalle Valo, David S. Miller,
open list:INTEL WIRELESS WIFI LINK (iwlwifi),
open list:NETWORKING DRIVERS, open list
On Mon, 2019-01-21 at 23:31 +0000, Sinan Kaya wrote:
> There is an unresolved dependency as follows:
>
> IWLWIFI_LEDS selects MAC80211_LEDS.
> MAC80211_LEDS depends on MAC80211.
>
> It is possible to choose MAC80211_LEDS (y) but not choose MAC80211
> (n)
>
> WARNING: unmet direct dependencies detected for MAC80211_LEDS
> Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] &&
> LEDS_CLASS [=y]
> Selected by [y]:
> - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] &&
> WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y ||
> LEDS_CLASS [=y]=IWLWIFI [=y])
>
> Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this
> configuration.
>
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
Thanks for your patch! But we already have another patch to fix this
issued queued for 5.0-rc4 (it's currently in wireless-drivers.git):
https://patchwork.kernel.org/patch/10762079/
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS
2019-01-22 10:15 ` Luciano Coelho
@ 2019-01-22 16:12 ` Sinan Kaya
2019-01-22 16:17 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: Sinan Kaya @ 2019-01-22 16:12 UTC (permalink / raw)
To: Luciano Coelho, linux-next
Cc: Johannes Berg, Emmanuel Grumbach, Intel Linux Wireless,
Kalle Valo, David S. Miller,
open list:INTEL WIRELESS WIFI LINK (iwlwifi),
open list:NETWORKING DRIVERS, open list
On 1/22/2019 5:15 AM, Luciano Coelho wrote:
> On Mon, 2019-01-21 at 23:31 +0000, Sinan Kaya wrote:
>> There is an unresolved dependency as follows:
>>
>> IWLWIFI_LEDS selects MAC80211_LEDS.
>> MAC80211_LEDS depends on MAC80211.
>>
>> It is possible to choose MAC80211_LEDS (y) but not choose MAC80211
>> (n)
>>
>> WARNING: unmet direct dependencies detected for MAC80211_LEDS
>> Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] &&
>> LEDS_CLASS [=y]
>> Selected by [y]:
>> - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] &&
>> WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y ||
>> LEDS_CLASS [=y]=IWLWIFI [=y])
>>
>> Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this
>> configuration.
>>
>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>> ---
>
> Thanks for your patch! But we already have another patch to fix this
> issued queued for 5.0-rc4 (it's currently in wireless-drivers.git):
>
> https://patchwork.kernel.org/patch/10762079/
Is it possible to queue this up soon? There is an effort to clean up
linux-next against randconfig failures and this issue showed up there.
>
> --
> Cheers,
> Luca.
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS
2019-01-22 16:12 ` Sinan Kaya
@ 2019-01-22 16:17 ` Kalle Valo
2019-01-22 16:20 ` Sinan Kaya
0 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2019-01-22 16:17 UTC (permalink / raw)
To: Sinan Kaya
Cc: Luciano Coelho, linux-next, Johannes Berg, Emmanuel Grumbach,
Intel Linux Wireless, David S. Miller, linux-wireless, netdev,
linux-kernel
Sinan Kaya <okaya@kernel.org> writes:
> On 1/22/2019 5:15 AM, Luciano Coelho wrote:
>> On Mon, 2019-01-21 at 23:31 +0000, Sinan Kaya wrote:
>>> There is an unresolved dependency as follows:
>>>
>>> IWLWIFI_LEDS selects MAC80211_LEDS.
>>> MAC80211_LEDS depends on MAC80211.
>>>
>>> It is possible to choose MAC80211_LEDS (y) but not choose MAC80211
>>> (n)
>>>
>>> WARNING: unmet direct dependencies detected for MAC80211_LEDS
>>> Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] &&
>>> LEDS_CLASS [=y]
>>> Selected by [y]:
>>> - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] &&
>>> WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y ||
>>> LEDS_CLASS [=y]=IWLWIFI [=y])
>>>
>>> Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this
>>> configuration.
>>>
>>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>>> ---
>>
>> Thanks for your patch! But we already have another patch to fix this
>> issued queued for 5.0-rc4 (it's currently in wireless-drivers.git):
>>
>> https://patchwork.kernel.org/patch/10762079/
>
> Is it possible to queue this up soon? There is an effort to clean up
> linux-next against randconfig failures and this issue showed up there.
It already should be in linux-next:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=ec5aecc0b227f5509d25853537f989ca303e2be1
But it's not in Linus' tree, yet.
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS
2019-01-22 16:17 ` Kalle Valo
@ 2019-01-22 16:20 ` Sinan Kaya
0 siblings, 0 replies; 5+ messages in thread
From: Sinan Kaya @ 2019-01-22 16:20 UTC (permalink / raw)
To: Kalle Valo
Cc: Luciano Coelho, linux-next, Johannes Berg, Emmanuel Grumbach,
Intel Linux Wireless, David S. Miller, linux-wireless, netdev,
linux-kernel
On 1/22/2019 11:17 AM, Kalle Valo wrote:
> Sinan Kaya <okaya@kernel.org> writes:
>
>> On 1/22/2019 5:15 AM, Luciano Coelho wrote:
>>> On Mon, 2019-01-21 at 23:31 +0000, Sinan Kaya wrote:
>>>> There is an unresolved dependency as follows:
>>>>
>>>> IWLWIFI_LEDS selects MAC80211_LEDS.
>>>> MAC80211_LEDS depends on MAC80211.
>>>>
>>>> It is possible to choose MAC80211_LEDS (y) but not choose MAC80211
>>>> (n)
>>>>
>>>> WARNING: unmet direct dependencies detected for MAC80211_LEDS
>>>> Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] &&
>>>> LEDS_CLASS [=y]
>>>> Selected by [y]:
>>>> - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] &&
>>>> WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y ||
>>>> LEDS_CLASS [=y]=IWLWIFI [=y])
>>>>
>>>> Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this
>>>> configuration.
>>>>
>>>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>>>> ---
>>>
>>> Thanks for your patch! But we already have another patch to fix this
>>> issued queued for 5.0-rc4 (it's currently in wireless-drivers.git):
>>>
>>> https://patchwork.kernel.org/patch/10762079/
>>
>> Is it possible to queue this up soon? There is an effort to clean up
>> linux-next against randconfig failures and this issue showed up there.
>
> It already should be in linux-next:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=ec5aecc0b227f5509d25853537f989ca303e2be1
>
> But it's not in Linus' tree, yet.
>
Thanks, let me grab a recent linux-next tag.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-22 16:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-21 23:31 [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS Sinan Kaya
2019-01-22 10:15 ` Luciano Coelho
2019-01-22 16:12 ` Sinan Kaya
2019-01-22 16:17 ` Kalle Valo
2019-01-22 16:20 ` Sinan Kaya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).