From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Thomas Richter <tmricht@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com
Subject: Re: [PATCHv2 1/3] perf report: Display s390 diagnostic counter sets
Date: Mon, 21 Jan 2019 21:01:11 -0300 [thread overview]
Message-ID: <20190122000111.GE20269@kernel.org> (raw)
In-Reply-To: <20190121183437.GB11396@krava>
Em Mon, Jan 21, 2019 at 07:34:37PM +0100, Jiri Olsa escreveu:
> On Mon, Jan 21, 2019 at 11:17:48AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Jan 21, 2019 at 02:13:36PM +0100, Jiri Olsa escreveu:
> > > On Sun, Jan 20, 2019 at 07:18:14PM +0100, Jiri Olsa wrote:
> > > > On Thu, Jan 17, 2019 at 11:00:53AM -0300, Arnaldo Carvalho de Melo wrote:
> > > >
> > > > SNIP
> > > >
> > > > > --- a/tools/perf/util/python-ext-sources
> > > > > +++ b/tools/perf/util/python-ext-sources
> > > > > @@ -25,6 +25,7 @@ util/parse-branch-options.c
> > > > > util/rblist.c
> > > > > util/counts.c
> > > > > util/print_binary.c
> > > > > +util/s390-sample-raw.c
> > > > > util/strlist.c
> > > > > util/trace-event.c
> > > > > ../lib/rbtree.c
> > > >
> > > > hi,
> > > > this change breaks the python module:
> > > >
> > > > >>> import perf
> > > > Traceback (most recent call last):
> > > > File "<stdin>", line 1, in <module>
> > > > ImportError: ./perf.so: undefined symbol: color_fprintf
> > > >
> > > > changelog doesn't say anything about python related change
> > >
> > > I made some chenages and movedthat raw sample code
> > > under s390.. which cured the python module, but
> > > I haven't tested it on s390.
> >
> > Nope, I explicitely asked him to build that code for all arches, as we
> > want to process s390 perf.data files on a x86 or arm or any other arch.
> >
>
> aah, so this actualy works over the s390 perf archive data on x86 host?
>
> I missed that in the original conversation, sry for noise
np, I fixed my mistake by making this be done on perf_session__new(),
right after creating the evlist, this way these arch specific bits,
needed only for dumping the raw sample, do not get dragged via evlist.c
into the perf binding :-)
- Arnaldo
> jirka
>
> > I stumbled on this as well, I think the way to go is to get the
> > color_fprintf bits in a separate object to avoid dragging more stuff to
> > the perf binding set of objects and then add that to the python binding.
> >
> > > Could you please check if code in here works for you:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> > > perf/s390
> > >
> > > if it works, I'll post it
> > >
> > > thanks,
> > > jirka
> >
> > --
> >
> > - Arnaldo
--
- Arnaldo
next prev parent reply other threads:[~2019-01-22 0:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 9:30 [Patchv2 0/3] perf report: Display CPU Measurement facility counter sets Thomas Richter
2019-01-17 9:30 ` [PATCHv2 1/3] perf report: Display s390 diagnostic " Thomas Richter
2019-01-17 14:00 ` Arnaldo Carvalho de Melo
2019-01-18 8:39 ` Thomas-Mich Richter
2019-01-22 10:15 ` [tip:perf/core] perf report: Display arch specific diagnostic counter sets, starting with s390 tip-bot for Thomas Richter
2019-01-20 18:18 ` [PATCHv2 1/3] perf report: Display s390 diagnostic counter sets Jiri Olsa
2019-01-21 13:13 ` Jiri Olsa
2019-01-21 14:10 ` Thomas-Mich Richter
2019-01-21 14:17 ` Arnaldo Carvalho de Melo
2019-01-21 18:34 ` Jiri Olsa
2019-01-22 0:01 ` Arnaldo Carvalho de Melo [this message]
2019-01-21 19:17 ` Arnaldo Carvalho de Melo
2019-01-17 9:30 ` [PATCHv2 2/3] perf report: Display names in " Thomas Richter
2019-01-17 14:02 ` Arnaldo Carvalho de Melo
2019-01-22 10:16 ` [tip:perf/core] " tip-bot for Thomas Richter
2019-01-17 9:30 ` [PATCHv2 3/3] perf report: s390 dump counter set data to file Thomas Richter
2019-01-17 14:03 ` Arnaldo Carvalho de Melo
2019-01-22 10:16 ` [tip:perf/core] perf report: Dump s390 " tip-bot for Thomas Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122000111.GE20269@kernel.org \
--to=acme@kernel.org \
--cc=brueckner@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).