From: Thomas-Mich Richter <tmricht@linux.ibm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com
Subject: Re: [PATCHv2 1/3] perf report: Display s390 diagnostic counter sets
Date: Fri, 18 Jan 2019 09:39:10 +0100 [thread overview]
Message-ID: <9c856ac0-ef23-72b5-901d-a1f815508976@linux.ibm.com> (raw)
In-Reply-To: <20190117140053.GJ11922@kernel.org>
On 01/17/2019 03:00 PM, Arnaldo Carvalho de Melo wrote:
> erf report: Display arch specific diagnostic counter sets, starting with s390
>
> On s390 the event bc000 (also named CF_DIAG) extracts the CPU
> Measurement Facility diagnostic counter sets and displays them as
> counter number and counter value pairs sorted by counter set number.
>
> Output:
> [root@s35lp76 perf]# ./perf report -D --stdio
>
> [00000000] Counterset:0 Counters:6
> Counter:000 Value:0x000000000085ec36 Counter:001 Value:0x0000000000796c94
> Counter:002 Value:0x0000000000005ada Counter:003 Value:0x0000000000092460
> Counter:004 Value:0x0000000000006073 Counter:005 Value:0x00000000001a9a73
> [0x000038] Counterset:1 Counters:2
> Counter:000 Value:0x000000000007c59f Counter:001 Value:0x000000000002fad6
> [0x000050] Counterset:2 Counters:16
> Counter:000 Value:000000000000000000 Counter:001 Value:000000000000000000
> Counter:002 Value:000000000000000000 Counter:003 Value:000000000000000000
> Counter:004 Value:000000000000000000 Counter:005 Value:000000000000000000
> Counter:006 Value:000000000000000000 Counter:007 Value:000000000000000000
> Counter:008 Value:000000000000000000 Counter:009 Value:000000000000000000
> Counter:010 Value:000000000000000000 Counter:011 Value:000000000000000000
> Counter:012 Value:000000000000000000 Counter:013 Value:000000000000000000
> Counter:014 Value:000000000000000000 Counter:015 Value:000000000000000000
> [0x0000d8] Counterset:3 Counters:128
> Counter:000 Value:0x000000000000020f Counter:001 Value:0x00000000000001d8
> Counter:002 Value:0x000000000000d7fa Counter:003 Value:0x000000000000008b
> ...
>
> The number in brackets is the offset into the raw data field of the
> sample.
>
> New functions trace_event_sample_raw__init() and s390_sample_raw() are
> introduced in the code path to enable interpretation on non s390
> platforms. This event bc000 attached raw data is generated only on s390
> platform. Correct display on other platforms requires correct endianness
> handling.
>
> Committer notes:
>
> Added a init function that sets up a evlist function pointer to avoid
> repeated tests on evlist->env and calls to perf_env__name() that
> involves normalizing, etc, for each PERF_RECORD_SAMPLE.
>
> Removed needless __maybe_unused from the trace_event_raw()
> prototype in session.h, move it to be an static function in evlist.
>
> Reviewed-by: Hendrik Brueckner <brueckner@linux.ibm.com>
I have applied your changed patch. Works great. Thanks a lot.
Tested-by: Thomas Richter <tmricht@linux.ibm.com>
--
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2019-01-18 8:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 9:30 [Patchv2 0/3] perf report: Display CPU Measurement facility counter sets Thomas Richter
2019-01-17 9:30 ` [PATCHv2 1/3] perf report: Display s390 diagnostic " Thomas Richter
2019-01-17 14:00 ` Arnaldo Carvalho de Melo
2019-01-18 8:39 ` Thomas-Mich Richter [this message]
2019-01-22 10:15 ` [tip:perf/core] perf report: Display arch specific diagnostic counter sets, starting with s390 tip-bot for Thomas Richter
2019-01-20 18:18 ` [PATCHv2 1/3] perf report: Display s390 diagnostic counter sets Jiri Olsa
2019-01-21 13:13 ` Jiri Olsa
2019-01-21 14:10 ` Thomas-Mich Richter
2019-01-21 14:17 ` Arnaldo Carvalho de Melo
2019-01-21 18:34 ` Jiri Olsa
2019-01-22 0:01 ` Arnaldo Carvalho de Melo
2019-01-21 19:17 ` Arnaldo Carvalho de Melo
2019-01-17 9:30 ` [PATCHv2 2/3] perf report: Display names in " Thomas Richter
2019-01-17 14:02 ` Arnaldo Carvalho de Melo
2019-01-22 10:16 ` [tip:perf/core] " tip-bot for Thomas Richter
2019-01-17 9:30 ` [PATCHv2 3/3] perf report: s390 dump counter set data to file Thomas Richter
2019-01-17 14:03 ` Arnaldo Carvalho de Melo
2019-01-22 10:16 ` [tip:perf/core] perf report: Dump s390 " tip-bot for Thomas Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c856ac0-ef23-72b5-901d-a1f815508976@linux.ibm.com \
--to=tmricht@linux.ibm.com \
--cc=acme@kernel.org \
--cc=brueckner@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).