* [PATCH v2 0/3] Add Oxalis board support
@ 2019-01-14 10:20 Manivannan Sadhasivam
2019-01-14 10:20 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add EBS-SYSTART GmbH Vendor Prefix Manivannan Sadhasivam
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Manivannan Sadhasivam @ 2019-01-14 10:20 UTC (permalink / raw)
To: shawnguo, leoyang.li, robh+dt
Cc: linux-arm-kernel, devicetree, linux-kernel, a.tropschug,
m.bittner, amit.kucheria, Manivannan Sadhasivam
Hello,
This patchset adds Oxalis board support. This board is one of the
96Boards Enterprise Edition platform from EBS-SYSTART GmbH. Below are some
of the key features of this board:
* SoC: NXP Layerscape LS1012A
* RAM: 1GB DDR3L
* PMU: NXP VR5100
* Storage: 64MByte SPI Flash for bootloader and RCW, MicroSD Card, SATA
* Connectivity: 2x Ethernet
* USB: 2x USB3.0
More information about this board can be found in 96Boards product
page: https://www.96boards.org/product/oxalis/
Ethernet and SPI flash are not supported yet!
Thanks,
Mani
Changes in v2:
As per Rob's review:
* Adopted the Oxalis board binding to JSON format.
* Sorted the EBS-SYSTART vendor prefix alphabetically.
* Used the generic node name for audio codec.
Manivannan Sadhasivam (3):
dt-bindings: vendor-prefixes: Add EBS-SYSTART GmbH Vendor Prefix
dt-bindings: arm: fsl: Add devicetree binding for Oxalis
arm64: dts: freescale: Add devicetree for Oxalis
.../devicetree/bindings/arm/fsl.yaml | 3 +-
.../devicetree/bindings/vendor-prefixes.txt | 1 +
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../boot/dts/freescale/fsl-ls1012a-oxalis.dts | 96 +++++++++++++++++++
4 files changed, 100 insertions(+), 1 deletion(-)
create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-oxalis.dts
--
2.17.1
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add EBS-SYSTART GmbH Vendor Prefix 2019-01-14 10:20 [PATCH v2 0/3] Add Oxalis board support Manivannan Sadhasivam @ 2019-01-14 10:20 ` Manivannan Sadhasivam 2019-01-16 21:10 ` Rob Herring 2019-01-14 10:20 ` [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis Manivannan Sadhasivam 2019-01-14 10:20 ` [PATCH v2 3/3] arm64: dts: freescale: Add devicetree " Manivannan Sadhasivam 2 siblings, 1 reply; 13+ messages in thread From: Manivannan Sadhasivam @ 2019-01-14 10:20 UTC (permalink / raw) To: shawnguo, leoyang.li, robh+dt Cc: linux-arm-kernel, devicetree, linux-kernel, a.tropschug, m.bittner, amit.kucheria, Manivannan Sadhasivam Add vendor prefix for EBS-SYSTART GmbH. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 389508584f48..38693105b5c6 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -108,6 +108,7 @@ dongwoon Dongwoon Anatech dptechnics DPTechnics dragino Dragino Technology Co., Limited ea Embedded Artists AB +ebs-systart EBS-SYSTART GmbH ebv EBV Elektronik eckelmann Eckelmann AG edt Emerging Display Technologies -- 2.17.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add EBS-SYSTART GmbH Vendor Prefix 2019-01-14 10:20 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add EBS-SYSTART GmbH Vendor Prefix Manivannan Sadhasivam @ 2019-01-16 21:10 ` Rob Herring 0 siblings, 0 replies; 13+ messages in thread From: Rob Herring @ 2019-01-16 21:10 UTC (permalink / raw) To: Manivannan Sadhasivam Cc: shawnguo, leoyang.li, robh+dt, linux-arm-kernel, devicetree, linux-kernel, a.tropschug, m.bittner, amit.kucheria, Manivannan Sadhasivam On Mon, 14 Jan 2019 15:50:51 +0530, Manivannan Sadhasivam wrote: > Add vendor prefix for EBS-SYSTART GmbH. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis 2019-01-14 10:20 [PATCH v2 0/3] Add Oxalis board support Manivannan Sadhasivam 2019-01-14 10:20 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add EBS-SYSTART GmbH Vendor Prefix Manivannan Sadhasivam @ 2019-01-14 10:20 ` Manivannan Sadhasivam 2019-01-14 18:02 ` Rob Herring 2019-01-14 10:20 ` [PATCH v2 3/3] arm64: dts: freescale: Add devicetree " Manivannan Sadhasivam 2 siblings, 1 reply; 13+ messages in thread From: Manivannan Sadhasivam @ 2019-01-14 10:20 UTC (permalink / raw) To: shawnguo, leoyang.li, robh+dt Cc: linux-arm-kernel, devicetree, linux-kernel, a.tropschug, m.bittner, amit.kucheria, Manivannan Sadhasivam Add devicetree binding for Oxalis board in JSON format. While adding that, let's fix the description for LS1012A also. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- Documentation/devicetree/bindings/arm/fsl.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index d34fe0749199..0f30142fe316 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -173,12 +173,13 @@ properties: - fsl,vf610 - fsl,vf610m4 - - description: LS1021A based Boards + - description: LS1012A based Boards items: - enum: - fsl,ls1012a-rdb - fsl,ls1012a-frdm - fsl,ls1012a-qds + - ebs-systart,oxalis - const: fsl,ls1021a - description: LS1043A based Boards -- 2.17.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis 2019-01-14 10:20 ` [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis Manivannan Sadhasivam @ 2019-01-14 18:02 ` Rob Herring 2019-01-14 18:10 ` Manivannan Sadhasivam 2019-01-16 2:21 ` Shawn Guo 0 siblings, 2 replies; 13+ messages in thread From: Rob Herring @ 2019-01-14 18:02 UTC (permalink / raw) To: Manivannan Sadhasivam Cc: Shawn Guo, Yang-Leo Li, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, devicetree, linux-kernel, a.tropschug, m.bittner, Amit Kucheria On Mon, Jan 14, 2019 at 4:21 AM Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > > Add devicetree binding for Oxalis board in JSON format. While adding > that, let's fix the description for LS1012A also. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index d34fe0749199..0f30142fe316 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -173,12 +173,13 @@ properties: > - fsl,vf610 > - fsl,vf610m4 > > - - description: LS1021A based Boards > + - description: LS1012A based Boards Well, yes that was wrong... > items: > - enum: > - fsl,ls1012a-rdb > - fsl,ls1012a-frdm > - fsl,ls1012a-qds > + - ebs-systart,oxalis Sort alphabetically. > - const: fsl,ls1021a And this is wrong too. I you just change it, then we will be missing an entry for LS1021A. What's the status of that SoC because there is no board dts file? We should not have .dtsi files in the kernel which don't get built. Rob ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis 2019-01-14 18:02 ` Rob Herring @ 2019-01-14 18:10 ` Manivannan Sadhasivam 2019-01-16 2:21 ` Shawn Guo 1 sibling, 0 replies; 13+ messages in thread From: Manivannan Sadhasivam @ 2019-01-14 18:10 UTC (permalink / raw) To: Rob Herring Cc: Shawn Guo, Yang-Leo Li, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, devicetree, linux-kernel, a.tropschug, m.bittner, Amit Kucheria Hi Rob, On Mon, Jan 14, 2019 at 12:02:47PM -0600, Rob Herring wrote: > On Mon, Jan 14, 2019 at 4:21 AM Manivannan Sadhasivam > <manivannan.sadhasivam@linaro.org> wrote: > > > > Add devicetree binding for Oxalis board in JSON format. While adding > > that, let's fix the description for LS1012A also. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index d34fe0749199..0f30142fe316 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -173,12 +173,13 @@ properties: > > - fsl,vf610 > > - fsl,vf610m4 > > > > - - description: LS1021A based Boards > > + - description: LS1012A based Boards > > Well, yes that was wrong... > > > items: > > - enum: > > - fsl,ls1012a-rdb > > - fsl,ls1012a-frdm > > - fsl,ls1012a-qds > > + - ebs-systart,oxalis > > Sort alphabetically. > Okay. > > - const: fsl,ls1021a > > And this is wrong too. > Ah, I missed this ;-) > I you just change it, then we will be missing an entry for LS1021A. > What's the status of that SoC because there is no board dts file? We > should not have .dtsi files in the kernel which don't get built. > I don't know much about LS1021A. Shawn should have an idea! Thanks, Mani > Rob ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis 2019-01-14 18:02 ` Rob Herring 2019-01-14 18:10 ` Manivannan Sadhasivam @ 2019-01-16 2:21 ` Shawn Guo 2019-01-16 4:07 ` Rob Herring 1 sibling, 1 reply; 13+ messages in thread From: Shawn Guo @ 2019-01-16 2:21 UTC (permalink / raw) To: Rob Herring Cc: Manivannan Sadhasivam, Yang-Leo Li, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, devicetree, linux-kernel, a.tropschug, m.bittner, Amit Kucheria On Mon, Jan 14, 2019 at 12:02:47PM -0600, Rob Herring wrote: > On Mon, Jan 14, 2019 at 4:21 AM Manivannan Sadhasivam > <manivannan.sadhasivam@linaro.org> wrote: > > > > Add devicetree binding for Oxalis board in JSON format. While adding > > that, let's fix the description for LS1012A also. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index d34fe0749199..0f30142fe316 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -173,12 +173,13 @@ properties: > > - fsl,vf610 > > - fsl,vf610m4 > > > > - - description: LS1021A based Boards > > + - description: LS1012A based Boards > > Well, yes that was wrong... > > > items: > > - enum: > > - fsl,ls1012a-rdb > > - fsl,ls1012a-frdm > > - fsl,ls1012a-qds > > + - ebs-systart,oxalis > > Sort alphabetically. > > > - const: fsl,ls1021a > > And this is wrong too. > > I you just change it, then we will be missing an entry for LS1021A. > What's the status of that SoC because there is no board dts file? We > should not have .dtsi files in the kernel which don't get built. Hmm, I do not see any LS1021A SoC .dtsi in the tree. I suspect it's just a typo of LS1012A. @Leo, do we have a LS1021A SoC? Shawn ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis 2019-01-16 2:21 ` Shawn Guo @ 2019-01-16 4:07 ` Rob Herring 2019-01-16 10:14 ` Shawn Guo 0 siblings, 1 reply; 13+ messages in thread From: Rob Herring @ 2019-01-16 4:07 UTC (permalink / raw) To: Shawn Guo Cc: Manivannan Sadhasivam, Yang-Leo Li, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, devicetree, linux-kernel, a.tropschug, m.bittner, Amit Kucheria On Tue, Jan 15, 2019 at 8:21 PM Shawn Guo <shawnguo@kernel.org> wrote: > > On Mon, Jan 14, 2019 at 12:02:47PM -0600, Rob Herring wrote: > > On Mon, Jan 14, 2019 at 4:21 AM Manivannan Sadhasivam > > <manivannan.sadhasivam@linaro.org> wrote: > > > > > > Add devicetree binding for Oxalis board in JSON format. While adding > > > that, let's fix the description for LS1012A also. > > > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > > --- > > > Documentation/devicetree/bindings/arm/fsl.yaml | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > > index d34fe0749199..0f30142fe316 100644 > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > @@ -173,12 +173,13 @@ properties: > > > - fsl,vf610 > > > - fsl,vf610m4 > > > > > > - - description: LS1021A based Boards > > > + - description: LS1012A based Boards > > > > Well, yes that was wrong... > > > > > items: > > > - enum: > > > - fsl,ls1012a-rdb > > > - fsl,ls1012a-frdm > > > - fsl,ls1012a-qds > > > + - ebs-systart,oxalis > > > > Sort alphabetically. > > > > > - const: fsl,ls1021a > > > > And this is wrong too. > > > > I you just change it, then we will be missing an entry for LS1021A. > > What's the status of that SoC because there is no board dts file? We > > should not have .dtsi files in the kernel which don't get built. > > Hmm, I do not see any LS1021A SoC .dtsi in the tree. I suspect it's > just a typo of LS1012A. > > @Leo, do we have a LS1021A SoC? arch/arm/boot/dts/ls1021a.dtsi Rob ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis 2019-01-16 4:07 ` Rob Herring @ 2019-01-16 10:14 ` Shawn Guo 2019-01-21 6:09 ` Manivannan Sadhasivam 0 siblings, 1 reply; 13+ messages in thread From: Shawn Guo @ 2019-01-16 10:14 UTC (permalink / raw) To: Rob Herring Cc: Manivannan Sadhasivam, Yang-Leo Li, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, devicetree, linux-kernel, a.tropschug, m.bittner, Amit Kucheria On Tue, Jan 15, 2019 at 10:07:12PM -0600, Rob Herring wrote: > On Tue, Jan 15, 2019 at 8:21 PM Shawn Guo <shawnguo@kernel.org> wrote: > > > > On Mon, Jan 14, 2019 at 12:02:47PM -0600, Rob Herring wrote: > > > On Mon, Jan 14, 2019 at 4:21 AM Manivannan Sadhasivam > > > <manivannan.sadhasivam@linaro.org> wrote: > > > > > > > > Add devicetree binding for Oxalis board in JSON format. While adding > > > > that, let's fix the description for LS1012A also. > > > > > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > > > --- > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > > > index d34fe0749199..0f30142fe316 100644 > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > > @@ -173,12 +173,13 @@ properties: > > > > - fsl,vf610 > > > > - fsl,vf610m4 > > > > > > > > - - description: LS1021A based Boards > > > > + - description: LS1012A based Boards > > > > > > Well, yes that was wrong... > > > > > > > items: > > > > - enum: > > > > - fsl,ls1012a-rdb > > > > - fsl,ls1012a-frdm > > > > - fsl,ls1012a-qds > > > > + - ebs-systart,oxalis > > > > > > Sort alphabetically. > > > > > > > - const: fsl,ls1021a > > > > > > And this is wrong too. > > > > > > I you just change it, then we will be missing an entry for LS1021A. > > > What's the status of that SoC because there is no board dts file? We > > > should not have .dtsi files in the kernel which don't get built. > > > > Hmm, I do not see any LS1021A SoC .dtsi in the tree. I suspect it's > > just a typo of LS1012A. > > > > @Leo, do we have a LS1021A SoC? > > arch/arm/boot/dts/ls1021a.dtsi Oops, I only searched arm64 folder. So it seems the compatible of the boards below are missing there. ls1021a-moxa-uc-8410a.dts ls1021a-qds.dts ls1021a-twr.dts Shawn ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis 2019-01-16 10:14 ` Shawn Guo @ 2019-01-21 6:09 ` Manivannan Sadhasivam 2019-01-21 19:57 ` Leo Li 0 siblings, 1 reply; 13+ messages in thread From: Manivannan Sadhasivam @ 2019-01-21 6:09 UTC (permalink / raw) To: Shawn Guo, Rob Herring Cc: Yang-Leo Li, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, devicetree, linux-kernel, a.tropschug, m.bittner, Amit Kucheria On Wed, Jan 16, 2019 at 06:14:43PM +0800, Shawn Guo wrote: > On Tue, Jan 15, 2019 at 10:07:12PM -0600, Rob Herring wrote: > > On Tue, Jan 15, 2019 at 8:21 PM Shawn Guo <shawnguo@kernel.org> wrote: > > > > > > On Mon, Jan 14, 2019 at 12:02:47PM -0600, Rob Herring wrote: > > > > On Mon, Jan 14, 2019 at 4:21 AM Manivannan Sadhasivam > > > > <manivannan.sadhasivam@linaro.org> wrote: > > > > > > > > > > Add devicetree binding for Oxalis board in JSON format. While adding > > > > > that, let's fix the description for LS1012A also. > > > > > > > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > > > > --- > > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 3 ++- > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > > > > index d34fe0749199..0f30142fe316 100644 > > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > > > @@ -173,12 +173,13 @@ properties: > > > > > - fsl,vf610 > > > > > - fsl,vf610m4 > > > > > > > > > > - - description: LS1021A based Boards > > > > > + - description: LS1012A based Boards > > > > > > > > Well, yes that was wrong... > > > > > > > > > items: > > > > > - enum: > > > > > - fsl,ls1012a-rdb > > > > > - fsl,ls1012a-frdm > > > > > - fsl,ls1012a-qds > > > > > + - ebs-systart,oxalis > > > > > > > > Sort alphabetically. > > > > > > > > > - const: fsl,ls1021a > > > > > > > > And this is wrong too. > > > > > > > > I you just change it, then we will be missing an entry for LS1021A. > > > > What's the status of that SoC because there is no board dts file? We > > > > should not have .dtsi files in the kernel which don't get built. > > > > > > Hmm, I do not see any LS1021A SoC .dtsi in the tree. I suspect it's > > > just a typo of LS1012A. > > > > > > @Leo, do we have a LS1021A SoC? > > > > arch/arm/boot/dts/ls1021a.dtsi > > Oops, I only searched arm64 folder. > > So it seems the compatible of the boards below are missing there. > > ls1021a-moxa-uc-8410a.dts > ls1021a-qds.dts > ls1021a-twr.dts So how should we proceed here? The above mentioned boards are lacking compatible in dts files and I guess that's the reason they didn't get mentioned in "fsl" binding file. Should I just go ahead and add the compatibles for these boards and list them in binding file? Thanks, Mani > > Shawn ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis 2019-01-21 6:09 ` Manivannan Sadhasivam @ 2019-01-21 19:57 ` Leo Li 2019-01-22 3:00 ` Shawn Guo 0 siblings, 1 reply; 13+ messages in thread From: Leo Li @ 2019-01-21 19:57 UTC (permalink / raw) To: Manivannan Sadhasivam, Shawn Guo, Rob Herring Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, devicetree, linux-kernel, a.tropschug, m.bittner, Amit Kucheria > -----Original Message----- > From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Sent: Monday, January 21, 2019 12:10 AM > To: Shawn Guo <shawnguo@kernel.org>; Rob Herring <robh+dt@kernel.org> > Cc: Leo Li <leoyang.li@nxp.com>; moderated list:ARM/FREESCALE IMX / MXC > ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > a.tropschug@ebs-systart.com; m.bittner@ebs-systart.com; Amit Kucheria > <amit.kucheria@linaro.org> > Subject: Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for > Oxalis > > On Wed, Jan 16, 2019 at 06:14:43PM +0800, Shawn Guo wrote: > > On Tue, Jan 15, 2019 at 10:07:12PM -0600, Rob Herring wrote: > > > On Tue, Jan 15, 2019 at 8:21 PM Shawn Guo <shawnguo@kernel.org> > wrote: > > > > > > > > On Mon, Jan 14, 2019 at 12:02:47PM -0600, Rob Herring wrote: > > > > > On Mon, Jan 14, 2019 at 4:21 AM Manivannan Sadhasivam > > > > > <manivannan.sadhasivam@linaro.org> wrote: > > > > > > > > > > > > Add devicetree binding for Oxalis board in JSON format. While > > > > > > adding that, let's fix the description for LS1012A also. > > > > > > > > > > > > Signed-off-by: Manivannan Sadhasivam > > > > > > <manivannan.sadhasivam@linaro.org> > > > > > > --- > > > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 3 ++- > > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > > > > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > > > > > index d34fe0749199..0f30142fe316 100644 > > > > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > > > > @@ -173,12 +173,13 @@ properties: > > > > > > - fsl,vf610 > > > > > > - fsl,vf610m4 > > > > > > > > > > > > - - description: LS1021A based Boards > > > > > > + - description: LS1012A based Boards > > > > > > > > > > Well, yes that was wrong... > > > > > > > > > > > items: > > > > > > - enum: > > > > > > - fsl,ls1012a-rdb > > > > > > - fsl,ls1012a-frdm > > > > > > - fsl,ls1012a-qds > > > > > > + - ebs-systart,oxalis > > > > > > > > > > Sort alphabetically. > > > > > > > > > > > - const: fsl,ls1021a > > > > > > > > > > And this is wrong too. > > > > > > > > > > I you just change it, then we will be missing an entry for LS1021A. > > > > > What's the status of that SoC because there is no board dts > > > > > file? We should not have .dtsi files in the kernel which don't get built. > > > > > > > > Hmm, I do not see any LS1021A SoC .dtsi in the tree. I suspect > > > > it's just a typo of LS1012A. > > > > > > > > @Leo, do we have a LS1021A SoC? > > > > > > arch/arm/boot/dts/ls1021a.dtsi > > > > Oops, I only searched arm64 folder. > > > > So it seems the compatible of the boards below are missing there. > > > > ls1021a-moxa-uc-8410a.dts > > ls1021a-qds.dts > > ls1021a-twr.dts > > So how should we proceed here? The above mentioned boards are lacking > compatible in dts files and I guess that's the reason they didn't get > mentioned in "fsl" binding file. > > Should I just go ahead and add the compatibles for these boards and list > them in binding file? Please go ahead and do that. One thing is that the moxa-uc-8410a board is a 3rd-party board, not sure if it should belong to the fsl binding file. Regards, Leo ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis 2019-01-21 19:57 ` Leo Li @ 2019-01-22 3:00 ` Shawn Guo 0 siblings, 0 replies; 13+ messages in thread From: Shawn Guo @ 2019-01-22 3:00 UTC (permalink / raw) To: Leo Li Cc: Manivannan Sadhasivam, Rob Herring, devicetree, a.tropschug, m.bittner, linux-kernel, Amit Kucheria, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE On Mon, Jan 21, 2019 at 07:57:20PM +0000, Leo Li wrote: > > > So it seems the compatible of the boards below are missing there. > > > > > > ls1021a-moxa-uc-8410a.dts > > > ls1021a-qds.dts > > > ls1021a-twr.dts > > > > So how should we proceed here? The above mentioned boards are lacking > > compatible in dts files and I guess that's the reason they didn't get > > mentioned in "fsl" binding file. > > > > Should I just go ahead and add the compatibles for these boards and list > > them in binding file? > > Please go ahead and do that. One thing is that the moxa-uc-8410a board is a 3rd-party board, not sure if it should belong to the fsl binding file. The fsl.yaml is designed to contain various boards using fsl SoCs, so it's fine. Shawn ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 3/3] arm64: dts: freescale: Add devicetree for Oxalis 2019-01-14 10:20 [PATCH v2 0/3] Add Oxalis board support Manivannan Sadhasivam 2019-01-14 10:20 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add EBS-SYSTART GmbH Vendor Prefix Manivannan Sadhasivam 2019-01-14 10:20 ` [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis Manivannan Sadhasivam @ 2019-01-14 10:20 ` Manivannan Sadhasivam 2 siblings, 0 replies; 13+ messages in thread From: Manivannan Sadhasivam @ 2019-01-14 10:20 UTC (permalink / raw) To: shawnguo, leoyang.li, robh+dt Cc: linux-arm-kernel, devicetree, linux-kernel, a.tropschug, m.bittner, amit.kucheria, Manivannan Sadhasivam Add devicetree support for Oxalis SoM board from EBS-SYSTART. This board is one of the 96Boards Enterprise Edition platform. Below are some of the key features of this board: * SoC: NXP Layerscape LS1012A * RAM: 1GB DDR3L * PMU: NXP VR5100 * Storage: 64MByte SPI Flash for bootloader and RCW, MicroSD Card, SATA * Connectivity: 2x Ethernet * USB: 2x USB3.0 More information about this board can be found in 96Boards product page: https://www.96boards.org/product/oxalis/ Ethernet and SPI flash are not supported yet! Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- arch/arm64/boot/dts/freescale/Makefile | 1 + .../boot/dts/freescale/fsl-ls1012a-oxalis.dts | 96 +++++++++++++++++++ 2 files changed, 97 insertions(+) create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1012a-oxalis.dts diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile index f9be2426f83c..d8152cc06b3f 100644 --- a/arch/arm64/boot/dts/freescale/Makefile +++ b/arch/arm64/boot/dts/freescale/Makefile @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frdm.dtb dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frwy.dtb +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-oxalis.dtb dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-qds.dtb diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-oxalis.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-oxalis.dts new file mode 100644 index 000000000000..7c726267ec8f --- /dev/null +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-oxalis.dts @@ -0,0 +1,96 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Device Tree file for Oxalis + * + * Copyright (c) 2019 Manivannan Sadhasivam + * + */ + +/dts-v1/; + +#include "fsl-ls1012a.dtsi" + +/ { + model = "Oxalis"; + compatible = "ebs-systart,oxalis", "fsl,ls1012a"; + + sys_mclk: clock-mclk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <25000000>; + }; + + reg_1p8v: regulator-1p8v { + compatible = "regulator-fixed"; + regulator-name = "1P8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; + + sound { + compatible = "simple-audio-card"; + simple-audio-card,format = "i2s"; + simple-audio-card,widgets = + "Microphone", "Microphone Jack", + "Headphone", "Headphone Jack", + "Speaker", "Speaker Ext", + "Line", "Line In Jack"; + simple-audio-card,routing = + "MIC_IN", "Microphone Jack", + "Microphone Jack", "Mic Bias", + "LINE_IN", "Line In Jack", + "Headphone Jack", "HP_OUT", + "Speaker Ext", "LINE_OUT"; + + simple-audio-card,cpu { + sound-dai = <&sai2>; + frame-master; + bitclock-master; + }; + + simple-audio-card,codec { + sound-dai = <&codec>; + frame-master; + bitclock-master; + system-clock-frequency = <25000000>; + }; + }; +}; + +&duart0 { + status = "okay"; +}; + +&duart1 { + status = "okay"; +}; + +&esdhc1 { + status = "okay"; +}; + +&i2c0 { + status = "okay"; + + codec: audio-codec@a { + #sound-dai-cells = <0>; + compatible = "fsl,sgtl5000"; + reg = <0xa>; + VDDA-supply = <®_1p8v>; + VDDIO-supply = <®_1p8v>; + clocks = <&sys_mclk>; + }; +}; + +&i2c1 { + status = "okay"; +}; + +&sai2 { + status = "okay"; +}; + +&sata { + status = "okay"; +}; -- 2.17.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-01-22 3:00 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-01-14 10:20 [PATCH v2 0/3] Add Oxalis board support Manivannan Sadhasivam 2019-01-14 10:20 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add EBS-SYSTART GmbH Vendor Prefix Manivannan Sadhasivam 2019-01-16 21:10 ` Rob Herring 2019-01-14 10:20 ` [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis Manivannan Sadhasivam 2019-01-14 18:02 ` Rob Herring 2019-01-14 18:10 ` Manivannan Sadhasivam 2019-01-16 2:21 ` Shawn Guo 2019-01-16 4:07 ` Rob Herring 2019-01-16 10:14 ` Shawn Guo 2019-01-21 6:09 ` Manivannan Sadhasivam 2019-01-21 19:57 ` Leo Li 2019-01-22 3:00 ` Shawn Guo 2019-01-14 10:20 ` [PATCH v2 3/3] arm64: dts: freescale: Add devicetree " Manivannan Sadhasivam
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).