* [PATCH] clk: sunxi-ng: v3s: Fix TCON reset de-assert bit
@ 2019-01-22 8:16 Paul Kocialkowski
2019-01-22 9:03 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Paul Kocialkowski @ 2019-01-22 8:16 UTC (permalink / raw)
To: linux-arm-kernel, linux-clk, linux-kernel
Cc: Maxime Ripard, Chen-Yu Tsai, Michael Turquette, Stephen Boyd,
Paul Kocialkowski
According to the datasheet and the reference code from Allwinner, the
bit used to de-assert the TCON reset is bit 4, not bit 3.
Fix it in the V3s CCU driver.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
drivers/clk/sunxi-ng/ccu-sun8i-v3s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-v3s.c b/drivers/clk/sunxi-ng/ccu-sun8i-v3s.c
index 621b1cd996db..ac12f261f8ca 100644
--- a/drivers/clk/sunxi-ng/ccu-sun8i-v3s.c
+++ b/drivers/clk/sunxi-ng/ccu-sun8i-v3s.c
@@ -542,7 +542,7 @@ static struct ccu_reset_map sun8i_v3s_ccu_resets[] = {
[RST_BUS_OHCI0] = { 0x2c0, BIT(29) },
[RST_BUS_VE] = { 0x2c4, BIT(0) },
- [RST_BUS_TCON0] = { 0x2c4, BIT(3) },
+ [RST_BUS_TCON0] = { 0x2c4, BIT(4) },
[RST_BUS_CSI] = { 0x2c4, BIT(8) },
[RST_BUS_DE] = { 0x2c4, BIT(12) },
[RST_BUS_DBG] = { 0x2c4, BIT(31) },
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: sunxi-ng: v3s: Fix TCON reset de-assert bit
2019-01-22 8:16 [PATCH] clk: sunxi-ng: v3s: Fix TCON reset de-assert bit Paul Kocialkowski
@ 2019-01-22 9:03 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2019-01-22 9:03 UTC (permalink / raw)
To: Paul Kocialkowski
Cc: linux-arm-kernel, linux-clk, linux-kernel, Chen-Yu Tsai,
Michael Turquette, Stephen Boyd
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
On Tue, Jan 22, 2019 at 09:16:19AM +0100, Paul Kocialkowski wrote:
> According to the datasheet and the reference code from Allwinner, the
> bit used to de-assert the TCON reset is bit 4, not bit 3.
>
> Fix it in the V3s CCU driver.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-22 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 8:16 [PATCH] clk: sunxi-ng: v3s: Fix TCON reset de-assert bit Paul Kocialkowski
2019-01-22 9:03 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).