* [PATCH 2/2] mbcs: add .owner to mbcs struct file_operations
@ 2019-01-22 13:44 parna.naveenkumar
0 siblings, 0 replies; only message in thread
From: parna.naveenkumar @ 2019-01-22 13:44 UTC (permalink / raw)
To: arnd, gregkh; +Cc: linux-kernel, Naveen Kumar Parna
From: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
Without ".owner = THIS_MODULE" it is possible to crash the kernel
by unloading the mbcs module while someone works with the file.
Fix this by initializing the ‘struct file_operations' ->owner with
THIS_MODULE.
Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
---
drivers/char/mbcs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/mbcs.c b/drivers/char/mbcs.c
index 8c9216a0f62e..0a31b60bee7b 100644
--- a/drivers/char/mbcs.c
+++ b/drivers/char/mbcs.c
@@ -50,6 +50,7 @@ static LIST_HEAD(soft_list);
* file operations
*/
static const struct file_operations mbcs_ops = {
+ .owner = THIS_MODULE,
.open = mbcs_open,
.llseek = mbcs_sram_llseek,
.read = mbcs_sram_read,
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-01-22 13:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 13:44 [PATCH 2/2] mbcs: add .owner to mbcs struct file_operations parna.naveenkumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).