linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] SCSI: fcoe: remove unneeded fcoe_ctlr_destroy_store export
@ 2019-01-22 14:28 Greg Kroah-Hartman
  2019-01-24  7:54 ` Hannes Reinecke
  2019-01-29  5:31 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2019-01-22 14:28 UTC (permalink / raw)
  To: Johannes Thumshirn, James E.J. Bottomley, Martin K. Petersen
  Cc: linux-kernel, linux-scsi

There's no need to export fcoe_ctlr_destroy_store as a symbol, so remove
the EXPORT_SYMBOL() line for it.

Cc: Johannes Thumshirn <jth@kernel.org>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/scsi/fcoe/fcoe_transport.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c
index f4909cd206d3..6d3949b687ef 100644
--- a/drivers/scsi/fcoe/fcoe_transport.c
+++ b/drivers/scsi/fcoe/fcoe_transport.c
@@ -855,7 +855,6 @@ ssize_t fcoe_ctlr_destroy_store(struct bus_type *bus,
 	mutex_unlock(&ft_mutex);
 	return rc;
 }
-EXPORT_SYMBOL(fcoe_ctlr_destroy_store);
 
 /**
  * fcoe_transport_create() - Create a fcoe interface
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] SCSI: fcoe: remove unneeded fcoe_ctlr_destroy_store export
  2019-01-22 14:28 [PATCH] SCSI: fcoe: remove unneeded fcoe_ctlr_destroy_store export Greg Kroah-Hartman
@ 2019-01-24  7:54 ` Hannes Reinecke
  2019-01-29  5:31 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Hannes Reinecke @ 2019-01-24  7:54 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Johannes Thumshirn, James E.J. Bottomley,
	Martin K. Petersen
  Cc: linux-kernel, linux-scsi

On 1/22/19 3:28 PM, Greg Kroah-Hartman wrote:
> There's no need to export fcoe_ctlr_destroy_store as a symbol, so remove
> the EXPORT_SYMBOL() line for it.
> 
> Cc: Johannes Thumshirn <jth@kernel.org>
> Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>   drivers/scsi/fcoe/fcoe_transport.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c
> index f4909cd206d3..6d3949b687ef 100644
> --- a/drivers/scsi/fcoe/fcoe_transport.c
> +++ b/drivers/scsi/fcoe/fcoe_transport.c
> @@ -855,7 +855,6 @@ ssize_t fcoe_ctlr_destroy_store(struct bus_type *bus,
>   	mutex_unlock(&ft_mutex);
>   	return rc;
>   }
> -EXPORT_SYMBOL(fcoe_ctlr_destroy_store);
>   
>   /**
>    * fcoe_transport_create() - Create a fcoe interface
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] SCSI: fcoe: remove unneeded fcoe_ctlr_destroy_store export
  2019-01-22 14:28 [PATCH] SCSI: fcoe: remove unneeded fcoe_ctlr_destroy_store export Greg Kroah-Hartman
  2019-01-24  7:54 ` Hannes Reinecke
@ 2019-01-29  5:31 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-01-29  5:31 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Johannes Thumshirn, James E.J. Bottomley, Martin K. Petersen,
	linux-kernel, linux-scsi


Greg,

> There's no need to export fcoe_ctlr_destroy_store as a symbol, so remove
> the EXPORT_SYMBOL() line for it.

Applied to 5.1/scsi-queue, thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-29  5:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 14:28 [PATCH] SCSI: fcoe: remove unneeded fcoe_ctlr_destroy_store export Greg Kroah-Hartman
2019-01-24  7:54 ` Hannes Reinecke
2019-01-29  5:31 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).