From: Will Deacon <will.deacon@arm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] qspinlock: no need to check return value of debugfs_create functions
Date: Wed, 23 Jan 2019 09:10:18 +0000 [thread overview]
Message-ID: <20190123091016.GA15019@brain-police> (raw)
In-Reply-To: <20190122152151.16139-44-gregkh@linuxfoundation.org>
On Tue, Jan 22, 2019 at 04:21:43PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> kernel/locking/qspinlock_stat.h | 18 ++++--------------
> 1 file changed, 4 insertions(+), 14 deletions(-)
Curious, but are you planning to make these functions return void after
you've modified all of the callers?
Will
next prev parent reply other threads:[~2019-01-23 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:21 [PATCH] qspinlock: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-23 8:14 ` Peter Zijlstra
2019-02-01 9:12 ` Greg Kroah-Hartman
2019-01-23 9:10 ` Will Deacon [this message]
2019-01-23 9:22 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123091016.GA15019@brain-police \
--to=will.deacon@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).