linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oscar Salvador <osalvador@suse.de>
To: Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, david@redhat.com
Subject: Re: [PATCH] mm,memory_hotplug: Fix scan_movable_pages for gigantic hugepages
Date: Wed, 23 Jan 2019 11:18:42 +0100	[thread overview]
Message-ID: <20190123101838.qxsapn4dhcergs6t@d104.suse.de> (raw)
In-Reply-To: <20190123094717.GQ4087@dhcp22.suse.cz>

On Wed, Jan 23, 2019 at 10:47:17AM +0100, Michal Hocko wrote:
> So this should be probably folded into the above patch as it is
> incomplete unless I am missing something.

Well, they are triggered from different paths.
The former error was triggered in:

removable_show
 is_mem_section_removable
  is_pageblock_removable_nolock
   has_unmovable_pages

while this one is triggered when actually doing the offline operation

__offline_pages
 scan_movable_pages
 
But I do agree that one without the other is not really useful, an incomplete.
The truth is that I did not spot this one when fixing [1] because I did not
really try to offline the memblock back then, so my fault.

While I agree that the best approach would be to fold this one into [1],
I am not sure if it is too late for that as it seems that [1] was already
released into mainline, and moreover to stable.

I guess I will have Andrew decide what is the best way to carry on here.

[1] https://patchwork.kernel.org/patch/10739963/

> 
> > Signed-off-by: Oscar Salvador <osalvador@suse.de>
> 
> Other than that the change looks good to me.
> 
> Acked-by: Michal Hocko <mhocko@suse.com>

Thanks!
-- 
Oscar Salvador
SUSE L3

  reply	other threads:[~2019-01-23 10:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 15:44 [PATCH] mm,memory_hotplug: Fix scan_movable_pages for gigantic hugepages Oscar Salvador
2019-01-22 23:47 ` Anthony Yznaga
2019-01-23  9:47 ` Michal Hocko
2019-01-23 10:18   ` Oscar Salvador [this message]
2019-01-23 10:22     ` Michal Hocko
2019-01-23 10:33 ` David Hildenbrand
2019-01-25  7:58   ` Oscar Salvador
2019-01-28 22:53     ` Andrew Morton
2019-01-28 22:56       ` Andrew Morton
2019-01-29  7:33         ` Michal Hocko
2019-01-29  8:27         ` Oscar Salvador
2019-01-29 10:03         ` David Hildenbrand
2019-01-30  7:52           ` Oscar Salvador
2019-01-28 22:53 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190123101838.qxsapn4dhcergs6t@d104.suse.de \
    --to=osalvador@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).