From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Joerg Roedel <joro@8bytes.org>, Jason Wang <jasowang@redhat.com>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, jfehlig@suse.com,
jon.grimm@amd.com, brijesh.singh@amd.com, jroedel@suse.de
Subject: Re: [PATCH 0/5 v3] Fix virtio-blk issue with SWIOTLB
Date: Wed, 23 Jan 2019 16:14:53 -0500 [thread overview]
Message-ID: <20190123211453.GA2474@char.us.oracle.com> (raw)
In-Reply-To: <20190123135000-mutt-send-email-mst@kernel.org>
On Wed, Jan 23, 2019 at 01:51:29PM -0500, Michael S. Tsirkin wrote:
> On Wed, Jan 23, 2019 at 05:30:44PM +0100, Joerg Roedel wrote:
> > Hi,
> >
> > here is the third version of this patch-set. Previous
> > versions can be found here:
> >
> > V1: https://lore.kernel.org/lkml/20190110134433.15672-1-joro@8bytes.org/
> >
> > V2: https://lore.kernel.org/lkml/20190115132257.6426-1-joro@8bytes.org/
> >
> > The problem solved here is a limitation of the SWIOTLB implementation,
> > which does not support allocations larger than 256kb. When the
> > virtio-blk driver tries to read/write a block larger than that, the
> > allocation of the dma-handle fails and an IO error is reported.
>
>
> OK looks good to me.
> I will park this in my tree for now this way it will get
> testing in linux-next.
> Can I get an ack from DMA maintainers on the DMA bits for
> merging this in 5.0?
You got mine (SWIOTBL is my area).
>
> > Changes to v2 are:
> >
> > * Check if SWIOTLB is active before returning its limit in
> > dma_direct_max_mapping_size()
> >
> > * Only apply the maximum segment limit in virtio-blk when
> > DMA-API is used for the vring
> >
> > Please review.
> >
> > Thanks,
> >
> > Joerg
> >
> > Joerg Roedel (5):
> > swiotlb: Introduce swiotlb_max_mapping_size()
> > swiotlb: Add is_swiotlb_active() function
> > dma: Introduce dma_max_mapping_size()
> > virtio: Introduce virtio_max_dma_size()
> > virtio-blk: Consider virtio_max_dma_size() for maximum segment size
> >
> > drivers/block/virtio_blk.c | 10 ++++++----
> > drivers/virtio/virtio_ring.c | 10 ++++++++++
> > include/linux/dma-mapping.h | 16 ++++++++++++++++
> > include/linux/swiotlb.h | 11 +++++++++++
> > include/linux/virtio.h | 2 ++
> > kernel/dma/direct.c | 11 +++++++++++
> > kernel/dma/swiotlb.c | 10 ++++++++++
> > 7 files changed, 66 insertions(+), 4 deletions(-)
> >
> > --
> > 2.17.1
next prev parent reply other threads:[~2019-01-23 21:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 16:30 [PATCH 0/5 v3] Fix virtio-blk issue with SWIOTLB Joerg Roedel
2019-01-23 16:30 ` [PATCH 1/5] swiotlb: Introduce swiotlb_max_mapping_size() Joerg Roedel
2019-01-23 21:28 ` Christoph Hellwig
2019-01-24 8:24 ` Joerg Roedel
2019-01-24 8:47 ` Christoph Hellwig
2019-01-23 16:30 ` [PATCH 2/5] swiotlb: Add is_swiotlb_active() function Joerg Roedel
2019-01-23 21:27 ` Christoph Hellwig
2019-01-24 8:29 ` Joerg Roedel
2019-01-24 8:41 ` Christoph Hellwig
2019-01-24 15:00 ` Joerg Roedel
2019-01-28 17:19 ` Michael S. Tsirkin
2019-01-23 16:30 ` [PATCH 3/5] dma: Introduce dma_max_mapping_size() Joerg Roedel
2019-01-23 21:29 ` Christoph Hellwig
2019-01-23 16:30 ` [PATCH 4/5] virtio: Introduce virtio_max_dma_size() Joerg Roedel
2019-01-23 16:30 ` [PATCH 5/5] virtio-blk: Consider virtio_max_dma_size() for maximum segment size Joerg Roedel
2019-01-23 21:31 ` Christoph Hellwig
2019-01-23 22:25 ` Michael S. Tsirkin
2019-01-24 8:40 ` Joerg Roedel
2019-01-24 8:42 ` Christoph Hellwig
2019-01-24 9:51 ` Joerg Roedel
2019-01-28 8:05 ` Christoph Hellwig
2019-01-28 17:14 ` Michael S. Tsirkin
2019-01-29 7:38 ` Christoph Hellwig
2019-01-23 17:09 ` [PATCH 0/5 v3] Fix virtio-blk issue with SWIOTLB Konrad Rzeszutek Wilk
2019-01-23 18:51 ` Michael S. Tsirkin
2019-01-23 21:14 ` Konrad Rzeszutek Wilk [this message]
2019-01-28 15:20 ` Michael S. Tsirkin
2019-01-28 15:53 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123211453.GA2474@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=axboe@kernel.dk \
--cc=brijesh.singh@amd.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jasowang@redhat.com \
--cc=jfehlig@suse.com \
--cc=jon.grimm@amd.com \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).