linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Evan Green <evgreen@chromium.org>
To: Andy Gross <andy.gross@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>
Cc: Can Guo <cang@codeaurora.org>,
	Douglas Anderson <dianders@chromium.org>,
	Asutosh Das <asutoshd@codeaurora.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	Evan Green <evgreen@chromium.org>,
	devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/9] dt-bindings: phy: qcom-ufs: Add resets property
Date: Wed, 23 Jan 2019 14:11:31 -0800	[thread overview]
Message-ID: <20190123221137.41722-4-evgreen@chromium.org> (raw)
In-Reply-To: <20190123221137.41722-1-evgreen@chromium.org>

Add a resets property to the PHY that represents the PHY reset
register in the UFS controller itself. This better describes the
complete specification of the PHY, and allows the PHY to perform
its initialization in a single function, rather than relying on
back-channel sequencing of initialization through the PHY framework.

Signed-off-by: Evan Green <evgreen@chromium.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---

Changes in v2:
- Added resets to example (Stephen).

 Documentation/devicetree/bindings/ufs/ufs-qcom.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/ufs/ufs-qcom.txt b/Documentation/devicetree/bindings/ufs/ufs-qcom.txt
index 21d9a93db2e97..fd59f93e95562 100644
--- a/Documentation/devicetree/bindings/ufs/ufs-qcom.txt
+++ b/Documentation/devicetree/bindings/ufs/ufs-qcom.txt
@@ -29,6 +29,7 @@ Optional properties:
 - vdda-pll-max-microamp : specifies max. load that can be drawn from pll supply
 - vddp-ref-clk-supply   : phandle to UFS device ref_clk pad power supply
 - vddp-ref-clk-max-microamp : specifies max. load that can be drawn from this supply
+- resets : specifies the PHY reset in the UFS controller
 
 Example:
 
@@ -51,9 +52,11 @@ Example:
 			<&clock_gcc clk_ufs_phy_ldo>,
 			<&clock_gcc clk_gcc_ufs_tx_cfg_clk>,
 			<&clock_gcc clk_gcc_ufs_rx_cfg_clk>;
+		resets = <&ufshc 0>;
 	};
 
-	ufshc@fc598000 {
+	ufshc: ufshc@fc598000 {
+		#reset-cells = <1>;
 		...
 		phys = <&ufsphy1>;
 		phy-names = "ufsphy";
-- 
2.18.1


  parent reply	other threads:[~2019-01-23 22:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 22:11 [PATCH v2 0/9] phy: qcom-ufs: Enable regulators to be off in suspend Evan Green
2019-01-23 22:11 ` [PATCH v2 1/9] dt-bindings: ufs: Add #reset-cells for Qualcomm controllers Evan Green
2019-01-30 18:56   ` Rob Herring
2019-02-01 17:41   ` Stephen Boyd
2019-01-23 22:11 ` [PATCH v2 2/9] dt-bindings: phy-qcom-qmp: Add UFS PHY reset Evan Green
2019-02-01 17:41   ` Stephen Boyd
2019-01-23 22:11 ` Evan Green [this message]
2019-02-01 17:41   ` [PATCH v2 3/9] dt-bindings: phy: qcom-ufs: Add resets property Stephen Boyd
2019-01-23 22:11 ` [PATCH v2 4/9] arm64: dts: sdm845: Add UFS PHY reset Evan Green
2019-01-23 22:11 ` [PATCH v2 5/9] arm64: dts: msm8996: Add UFS PHY reset controller Evan Green
2019-01-23 22:11 ` [PATCH v2 6/9] scsi: ufs: qcom: Expose the reset controller for PHY Evan Green
2019-02-01 17:56   ` Stephen Boyd
2019-02-05 17:59     ` Evan Green
2019-01-23 22:11 ` [PATCH v2 7/9] phy: qcom-qmp: Utilize UFS reset controller Evan Green
2019-02-01 18:00   ` Stephen Boyd
2019-02-05 18:00     ` Evan Green
2019-01-23 22:11 ` [PATCH v2 8/9] phy: qcom-qmp: Move UFS phy to phy_poweron/off Evan Green
2019-01-23 22:11 ` [PATCH v2 9/9] phy: qcom-ufs: Refactor all init steps into phy_poweron Evan Green
2019-02-01 18:43   ` Stephen Boyd
2019-02-05 18:00     ` Evan Green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190123221137.41722-4-evgreen@chromium.org \
    --to=evgreen@chromium.org \
    --cc=andy.gross@linaro.org \
    --cc=asutoshd@codeaurora.org \
    --cc=cang@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).