* [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook
@ 2019-01-23 23:07 Vijay Khemka
2019-01-23 23:07 ` [PATCH 2/2] ARM: dts: aspeed: Add uarts for SoL in Facebook Vijay Khemka
2019-01-30 3:27 ` [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook Joel Stanley
0 siblings, 2 replies; 5+ messages in thread
From: Vijay Khemka @ 2019-01-23 23:07 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Joel Stanley, Andrew Jeffery,
devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
Cc: vijaykhemka, openbmc @ lists . ozlabs . org
Added lpc control for enabling lpc clock, peci for cpu sensors and lpc
snoop devices to Facebook Tiogapass device tree.
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
---
.../arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
index 73e58a821613..d60dbb019f82 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
@@ -54,6 +54,16 @@
};
};
+&lpc_snoop {
+ status = "okay";
+ snoop-ports = <0x80>;
+};
+
+&lpc_ctrl {
+ // Enable lpc clock
+ status = "okay";
+};
+
&uart1 {
// Host Console
status = "okay";
@@ -67,6 +77,10 @@
status = "okay";
};
+&peci0 {
+ status = "okay";
+};
+
&kcs2 {
// BMC KCS channel 2
status = "okay";
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM: dts: aspeed: Add uarts for SoL in Facebook
2019-01-23 23:07 [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook Vijay Khemka
@ 2019-01-23 23:07 ` Vijay Khemka
2019-01-30 3:27 ` Joel Stanley
2019-01-30 3:27 ` [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook Joel Stanley
1 sibling, 1 reply; 5+ messages in thread
From: Vijay Khemka @ 2019-01-23 23:07 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Joel Stanley, Andrew Jeffery,
devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
Cc: vijaykhemka, openbmc @ lists . ozlabs . org
Added uart2 and uart3 in Facebook Tiogapass for routing serial input
from Host to BMC for SoL via LPC.
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
---
arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
index d60dbb019f82..42e0d7a8e8d0 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
@@ -72,6 +72,16 @@
&pinctrl_rxd1_default>;
};
+&uart2 {
+ // SoL Host Console
+ status = "okay";
+};
+
+&uart3 {
+ // SoL BMC Console
+ status = "okay";
+};
+
&uart5 {
// BMC Console
status = "okay";
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook
2019-01-23 23:07 [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook Vijay Khemka
2019-01-23 23:07 ` [PATCH 2/2] ARM: dts: aspeed: Add uarts for SoL in Facebook Vijay Khemka
@ 2019-01-30 3:27 ` Joel Stanley
2019-01-30 18:01 ` Vijay Khemka
1 sibling, 1 reply; 5+ messages in thread
From: Joel Stanley @ 2019-01-30 3:27 UTC (permalink / raw)
To: Vijay Khemka
Cc: Rob Herring, Mark Rutland, Andrew Jeffery, devicetree, Linux ARM,
linux-aspeed, Linux Kernel Mailing List,
openbmc @ lists . ozlabs . org
On Thu, 24 Jan 2019 at 10:07, Vijay Khemka <vijaykhemka@fb.com> wrote:
> index 73e58a821613..d60dbb019f82 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
>
> +&peci0 {
> + status = "okay";
> +};
I don't think we have an upstream tree that contains a node called
peci0. Therefore this does not build.
I have dropped this hunk from your patch. Please make sure you test
before sending patches.
Cheers,
Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] ARM: dts: aspeed: Add uarts for SoL in Facebook
2019-01-23 23:07 ` [PATCH 2/2] ARM: dts: aspeed: Add uarts for SoL in Facebook Vijay Khemka
@ 2019-01-30 3:27 ` Joel Stanley
0 siblings, 0 replies; 5+ messages in thread
From: Joel Stanley @ 2019-01-30 3:27 UTC (permalink / raw)
To: Vijay Khemka
Cc: Rob Herring, Mark Rutland, Andrew Jeffery, devicetree, Linux ARM,
linux-aspeed, Linux Kernel Mailing List,
openbmc @ lists . ozlabs . org
On Thu, 24 Jan 2019 at 10:07, Vijay Khemka <vijaykhemka@fb.com> wrote:
>
> Added uart2 and uart3 in Facebook Tiogapass for routing serial input
> from Host to BMC for SoL via LPC.
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
Applied for 5.1.
Cheers,
Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook
2019-01-30 3:27 ` [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook Joel Stanley
@ 2019-01-30 18:01 ` Vijay Khemka
0 siblings, 0 replies; 5+ messages in thread
From: Vijay Khemka @ 2019-01-30 18:01 UTC (permalink / raw)
To: Joel Stanley
Cc: Rob Herring, Mark Rutland, Andrew Jeffery, devicetree, Linux ARM,
linux-aspeed, Linux Kernel Mailing List,
openbmc @ lists . ozlabs . org
On 1/29/19, 7:27 PM, "Joel Stanley" <joel@jms.id.au> wrote:
On Thu, 24 Jan 2019 at 10:07, Vijay Khemka <vijaykhemka@fb.com> wrote:
> index 73e58a821613..d60dbb019f82 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
>
> +&peci0 {
> + status = "okay";
> +};
I don't think we have an upstream tree that contains a node called
peci0. Therefore this does not build.
I have dropped this hunk from your patch. Please make sure you test
before sending patches.
Thanks Joel, I will be careful.
Cheers,
Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-30 18:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-23 23:07 [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook Vijay Khemka
2019-01-23 23:07 ` [PATCH 2/2] ARM: dts: aspeed: Add uarts for SoL in Facebook Vijay Khemka
2019-01-30 3:27 ` Joel Stanley
2019-01-30 3:27 ` [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook Joel Stanley
2019-01-30 18:01 ` Vijay Khemka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).