* [PATCH] tipc: remove dead code in struct tipc_topsrv
@ 2019-01-24 2:06 Zhaolong Zhang
2019-01-24 2:40 ` Ying Xue
2019-01-25 6:31 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Zhaolong Zhang @ 2019-01-24 2:06 UTC (permalink / raw)
To: jon.maloy, ying.xue, davem, zhangzl2013
Cc: netdev, tipc-discussion, linux-kernel
max_rcvbuf_size is no longer used since commit "414574a0af36".
Signed-off-by: Zhaolong Zhang <zhangzl2013@126.com>
---
net/tipc/topsrv.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/tipc/topsrv.c b/net/tipc/topsrv.c
index efb16f6..4b1c083 100644
--- a/net/tipc/topsrv.c
+++ b/net/tipc/topsrv.c
@@ -60,7 +60,6 @@
* @awork: accept work item
* @rcv_wq: receive workqueue
* @send_wq: send workqueue
- * @max_rcvbuf_size: maximum permitted receive message length
* @listener: topsrv listener socket
* @name: server name
*/
@@ -72,7 +71,6 @@ struct tipc_topsrv {
struct work_struct awork;
struct workqueue_struct *rcv_wq;
struct workqueue_struct *send_wq;
- int max_rcvbuf_size;
struct socket *listener;
char name[TIPC_SERVER_NAME_LEN];
};
@@ -648,7 +646,6 @@ int tipc_topsrv_start(struct net *net)
return -ENOMEM;
srv->net = net;
- srv->max_rcvbuf_size = sizeof(struct tipc_subscr);
INIT_WORK(&srv->awork, tipc_topsrv_accept);
strscpy(srv->name, name, sizeof(srv->name));
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tipc: remove dead code in struct tipc_topsrv
2019-01-24 2:06 [PATCH] tipc: remove dead code in struct tipc_topsrv Zhaolong Zhang
@ 2019-01-24 2:40 ` Ying Xue
2019-01-25 6:31 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Ying Xue @ 2019-01-24 2:40 UTC (permalink / raw)
To: Zhaolong Zhang, jon.maloy, davem; +Cc: netdev, tipc-discussion, linux-kernel
On 1/24/19 10:06 AM, Zhaolong Zhang wrote:
> max_rcvbuf_size is no longer used since commit "414574a0af36".
>
> Signed-off-by: Zhaolong Zhang <zhangzl2013@126.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
> ---
> net/tipc/topsrv.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/net/tipc/topsrv.c b/net/tipc/topsrv.c
> index efb16f6..4b1c083 100644
> --- a/net/tipc/topsrv.c
> +++ b/net/tipc/topsrv.c
> @@ -60,7 +60,6 @@
> * @awork: accept work item
> * @rcv_wq: receive workqueue
> * @send_wq: send workqueue
> - * @max_rcvbuf_size: maximum permitted receive message length
> * @listener: topsrv listener socket
> * @name: server name
> */
> @@ -72,7 +71,6 @@ struct tipc_topsrv {
> struct work_struct awork;
> struct workqueue_struct *rcv_wq;
> struct workqueue_struct *send_wq;
> - int max_rcvbuf_size;
> struct socket *listener;
> char name[TIPC_SERVER_NAME_LEN];
> };
> @@ -648,7 +646,6 @@ int tipc_topsrv_start(struct net *net)
> return -ENOMEM;
>
> srv->net = net;
> - srv->max_rcvbuf_size = sizeof(struct tipc_subscr);
> INIT_WORK(&srv->awork, tipc_topsrv_accept);
>
> strscpy(srv->name, name, sizeof(srv->name));
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tipc: remove dead code in struct tipc_topsrv
2019-01-24 2:06 [PATCH] tipc: remove dead code in struct tipc_topsrv Zhaolong Zhang
2019-01-24 2:40 ` Ying Xue
@ 2019-01-25 6:31 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-01-25 6:31 UTC (permalink / raw)
To: zhangzl2013; +Cc: jon.maloy, ying.xue, netdev, tipc-discussion, linux-kernel
From: Zhaolong Zhang <zhangzl2013@126.com>
Date: Thu, 24 Jan 2019 10:06:41 +0800
> max_rcvbuf_size is no longer used since commit "414574a0af36".
>
> Signed-off-by: Zhaolong Zhang <zhangzl2013@126.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-25 6:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-24 2:06 [PATCH] tipc: remove dead code in struct tipc_topsrv Zhaolong Zhang
2019-01-24 2:40 ` Ying Xue
2019-01-25 6:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).