* [PATCH] benet: remove broken and unused macro
@ 2019-01-28 16:17 Lubomir Rintel
2019-01-28 18:56 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Lubomir Rintel @ 2019-01-28 16:17 UTC (permalink / raw)
To: David S. Miller
Cc: Sathya Perla, Ajit Khaparde, Sriharsha Basavapatna,
Somnath Kotur, netdev, linux-kernel, Lubomir Rintel
is_broadcast_packet() expands to compare_ether_addr() which doesn't
exist since commit 7367d0b573d1 ("drivers/net: Convert uses of
compare_ether_addr to ether_addr_equal"). It turns out it's actually not
used.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
drivers/net/ethernet/emulex/benet/be_main.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index d5026909dec5..3c7c04406a2b 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -1270,10 +1270,6 @@ static void be_xmit_flush(struct be_adapter *adapter, struct be_tx_obj *txo)
#define is_arp_allowed_on_bmc(adapter, skb) \
(is_arp(skb) && is_arp_filt_enabled(adapter))
-#define is_broadcast_packet(eh, adapter) \
- (is_multicast_ether_addr(eh->h_dest) && \
- !compare_ether_addr(eh->h_dest, adapter->netdev->broadcast))
-
#define is_arp(skb) (skb->protocol == htons(ETH_P_ARP))
#define is_arp_filt_enabled(adapter) \
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] benet: remove broken and unused macro
2019-01-28 16:17 [PATCH] benet: remove broken and unused macro Lubomir Rintel
@ 2019-01-28 18:56 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-01-28 18:56 UTC (permalink / raw)
To: lkundrak
Cc: sathya.perla, ajit.khaparde, sriharsha.basavapatna,
somnath.kotur, netdev, linux-kernel
From: Lubomir Rintel <lkundrak@v3.sk>
Date: Mon, 28 Jan 2019 17:17:40 +0100
> is_broadcast_packet() expands to compare_ether_addr() which doesn't
> exist since commit 7367d0b573d1 ("drivers/net: Convert uses of
> compare_ether_addr to ether_addr_equal"). It turns out it's actually not
> used.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Applied to net-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-28 18:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-28 16:17 [PATCH] benet: remove broken and unused macro Lubomir Rintel
2019-01-28 18:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).