* [PATCH v2 1/3] ARM: dts: rockchip: rv1108-elgin: Fix vcc5/6-supply representation
@ 2019-01-31 12:47 Otavio Salvador
2019-01-31 12:47 ` [PATCH v2 2/3] ARM: dts: rockchip: rv1108-elgin: Use the correct regulator properties Otavio Salvador
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Otavio Salvador @ 2019-01-31 12:47 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Jason Zhu, Vicent Chi, Andy Yan, Philipp Tomsic, Tony Xie,
Otavio Salvador, devicetree, Heiko Stuebner, linux-kernel,
linux-rockchip, Rob Herring, Mark Rutland
On rv1108-elgin-r1 board the RK805 VCC5 and VCC6 supplies come from
the BUCK2 regulator at 2.2V, so fix the representation in the
device tree.
While at it, rename it from vdd_cam to vdd_buck2, which is a better
name for the regulator label.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v2: None
arch/arm/boot/dts/rv1108-elgin-r1.dts | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rv1108-elgin-r1.dts
index 658057d871af..66688fdf4fd8 100644
--- a/arch/arm/boot/dts/rv1108-elgin-r1.dts
+++ b/arch/arm/boot/dts/rv1108-elgin-r1.dts
@@ -74,8 +74,8 @@
vcc2-supply = <&vcc_sys>;
vcc3-supply = <&vcc_sys>;
vcc4-supply = <&vcc_sys>;
- vcc5-supply = <&vcc_sys>;
- vcc6-supply = <&vcc_sys>;
+ vcc5-supply = <&vdd_buck2>;
+ vcc6-supply = <&vdd_buck2>;
regulators {
vdd_core: DCDC_REG1 {
@@ -90,10 +90,12 @@
};
};
- vdd_cam: DCDC_REG2 {
- regulator-name= "vdd_cam";
- regulator-min-microvolt = <700000>;
- regulator-max-microvolt = <2000000>;
+ vdd_buck2: DCDC_REG2 {
+ regulator-name= "vdd_buck2";
+ regulator-min-microvolt = <2200000>;
+ regulator-max-microvolt = <2200000>;
+ regulator-always-on;
+ regulator-boot-on;
regulator-state-mem {
regulator-state-disabled;
};
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/3] ARM: dts: rockchip: rv1108-elgin: Use the correct regulator properties
2019-01-31 12:47 [PATCH v2 1/3] ARM: dts: rockchip: rv1108-elgin: Fix vcc5/6-supply representation Otavio Salvador
@ 2019-01-31 12:47 ` Otavio Salvador
2019-01-31 12:47 ` [PATCH v2 3/3] ARM: dts: rockchip: rv1108-evb: " Otavio Salvador
2019-02-03 9:00 ` [PATCH v2 1/3] ARM: dts: rockchip: rv1108-elgin: Fix vcc5/6-supply representation Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Otavio Salvador @ 2019-01-31 12:47 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Jason Zhu, Vicent Chi, Andy Yan, Philipp Tomsic, Tony Xie,
Otavio Salvador, devicetree, Heiko Stuebner, linux-kernel,
linux-rockchip, Rob Herring, Mark Rutland
The following properties:
- regulator-state-enabled
- regulator-state-disabled
- regulator-state-uv
are not valid ones as per
Documentation/devicetree/bindings/regulator/regulator.txt
Fix it by using the correct properties as per the dt bindings.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v2: None
arch/arm/boot/dts/rv1108-elgin-r1.dts | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rv1108-elgin-r1.dts
index 66688fdf4fd8..1c4507b66fdd 100644
--- a/arch/arm/boot/dts/rv1108-elgin-r1.dts
+++ b/arch/arm/boot/dts/rv1108-elgin-r1.dts
@@ -85,8 +85,8 @@
regulator-always-on;
regulator-boot-on;
regulator-state-mem {
- regulator-state-enabled;
- regulator-state-uv = <900000>;
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <900000>;
};
};
@@ -97,7 +97,7 @@
regulator-always-on;
regulator-boot-on;
regulator-state-mem {
- regulator-state-disabled;
+ regulator-off-in-suspend;
};
};
@@ -106,7 +106,7 @@
regulator-always-on;
regulator-boot-on;
regulator-state-mem {
- regulator-state-enabled;
+ regulator-on-in-suspend;
};
};
@@ -117,8 +117,8 @@
regulator-always-on;
regulator-boot-on;
regulator-state-mem {
- regulator-state-enabled;
- regulator-state-uv = <3300000>;
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3300000>;
};
};
@@ -129,7 +129,7 @@
regulator-always-on;
regulator-boot-on;
regulator-state-mem {
- regulator-state-disabled;
+ regulator-off-in-suspend;
};
};
@@ -140,7 +140,7 @@
regulator-always-on;
regulator-boot-on;
regulator-state-mem {
- regulator-state-disabled;
+ regulator-off-in-suspend;
};
};
@@ -151,8 +151,8 @@
regulator-always-on;
regulator-boot-on;
regulator-state-mem {
- regulator-state-enabled;
- regulator-state-uv = <1000000>;
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1000000>;
};
};
};
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 3/3] ARM: dts: rockchip: rv1108-evb: Use the correct regulator properties
2019-01-31 12:47 [PATCH v2 1/3] ARM: dts: rockchip: rv1108-elgin: Fix vcc5/6-supply representation Otavio Salvador
2019-01-31 12:47 ` [PATCH v2 2/3] ARM: dts: rockchip: rv1108-elgin: Use the correct regulator properties Otavio Salvador
@ 2019-01-31 12:47 ` Otavio Salvador
2019-02-03 9:00 ` [PATCH v2 1/3] ARM: dts: rockchip: rv1108-elgin: Fix vcc5/6-supply representation Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Otavio Salvador @ 2019-01-31 12:47 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Jason Zhu, Vicent Chi, Andy Yan, Philipp Tomsic, Tony Xie,
Otavio Salvador, devicetree, Heiko Stuebner, linux-kernel,
linux-rockchip, Rob Herring, Mark Rutland
The following properties:
- regulator-state-enabled
- regulator-state-disabled
- regulator-state-uv
are not valid ones as per
Documentation/devicetree/bindings/regulator/regulator.txt
Fix it by using the correct properties as per the dt bindings.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v2:
- rebase on top of linux-next
arch/arm/boot/dts/rv1108-evb.dts | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/rv1108-evb.dts b/arch/arm/boot/dts/rv1108-evb.dts
index 203d83e3bbf5..30f3d0470ad9 100644
--- a/arch/arm/boot/dts/rv1108-evb.dts
+++ b/arch/arm/boot/dts/rv1108-evb.dts
@@ -97,8 +97,8 @@
regulator-always-on;
regulator-boot-on;
regulator-state-mem {
- regulator-state-enabled;
- regulator-state-uv = <900000>;
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <900000>;
};
};
@@ -107,7 +107,7 @@
regulator-min-microvolt = <700000>;
regulator-max-microvolt = <2000000>;
regulator-state-mem {
- regulator-state-disabled;
+ regulator-off-in-suspend;
};
};
@@ -116,7 +116,7 @@
regulator-always-on;
regulator-boot-on;
regulator-state-mem {
- regulator-state-enabled;
+ regulator-on-in-suspend;
};
};
@@ -127,8 +127,8 @@
regulator-always-on;
regulator-boot-on;
regulator-state-mem {
- regulator-state-enabled;
- regulator-state-uv = <3300000>;
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3300000>;
};
};
@@ -139,7 +139,7 @@
regulator-always-on;
regulator-boot-on;
regulator-state-mem {
- regulator-state-disabled;
+ regulator-off-in-suspend;
};
};
@@ -150,7 +150,7 @@
regulator-always-on;
regulator-boot-on;
regulator-state-mem {
- regulator-state-disabled;
+ regulator-off-in-suspend;
};
};
@@ -161,8 +161,8 @@
regulator-always-on;
regulator-boot-on;
regulator-state-mem {
- regulator-state-enabled;
- regulator-state-uv = <1000000>;
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1000000>;
};
};
};
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/3] ARM: dts: rockchip: rv1108-elgin: Fix vcc5/6-supply representation
2019-01-31 12:47 [PATCH v2 1/3] ARM: dts: rockchip: rv1108-elgin: Fix vcc5/6-supply representation Otavio Salvador
2019-01-31 12:47 ` [PATCH v2 2/3] ARM: dts: rockchip: rv1108-elgin: Use the correct regulator properties Otavio Salvador
2019-01-31 12:47 ` [PATCH v2 3/3] ARM: dts: rockchip: rv1108-evb: " Otavio Salvador
@ 2019-02-03 9:00 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2019-02-03 9:00 UTC (permalink / raw)
To: Otavio Salvador
Cc: linux-arm-kernel, Jason Zhu, Vicent Chi, Andy Yan,
Philipp Tomsic, Tony Xie, devicetree, linux-kernel,
linux-rockchip, Rob Herring, Mark Rutland
Am Donnerstag, 31. Januar 2019, 13:47:07 CET schrieb Otavio Salvador:
> On rv1108-elgin-r1 board the RK805 VCC5 and VCC6 supplies come from
> the BUCK2 regulator at 2.2V, so fix the representation in the
> device tree.
>
> While at it, rename it from vdd_cam to vdd_buck2, which is a better
> name for the regulator label.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
applied all 3 for 5.1
Thanks
Heiko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-03 9:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-31 12:47 [PATCH v2 1/3] ARM: dts: rockchip: rv1108-elgin: Fix vcc5/6-supply representation Otavio Salvador
2019-01-31 12:47 ` [PATCH v2 2/3] ARM: dts: rockchip: rv1108-elgin: Use the correct regulator properties Otavio Salvador
2019-01-31 12:47 ` [PATCH v2 3/3] ARM: dts: rockchip: rv1108-evb: " Otavio Salvador
2019-02-03 9:00 ` [PATCH v2 1/3] ARM: dts: rockchip: rv1108-elgin: Fix vcc5/6-supply representation Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).