* [PATCH] pinctrl: qcom: qcs404: Correct SDC tile
@ 2019-01-31 17:29 Bjorn Andersson
2019-02-04 11:19 ` Vinod Koul
2019-02-06 8:24 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Bjorn Andersson @ 2019-01-31 17:29 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij
Cc: linux-arm-msm, linux-gpio, linux-kernel, stable
The SDC controls live in the south tile, not the north one. Correct this
so that we program the right registers.
Cc: stable@vger.kernel.org
Fixes: 22eb8301dbc1 ("pinctrl: qcom: Add qcs404 pinctrl driver")
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/pinctrl/qcom/pinctrl-qcs404.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-qcs404.c b/drivers/pinctrl/qcom/pinctrl-qcs404.c
index 7aae52a09ff0..4ffd56ff809e 100644
--- a/drivers/pinctrl/qcom/pinctrl-qcs404.c
+++ b/drivers/pinctrl/qcom/pinctrl-qcs404.c
@@ -79,7 +79,7 @@ enum {
.intr_cfg_reg = 0, \
.intr_status_reg = 0, \
.intr_target_reg = 0, \
- .tile = NORTH, \
+ .tile = SOUTH, \
.mux_bit = -1, \
.pull_bit = pull, \
.drv_bit = drv, \
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: qcom: qcs404: Correct SDC tile
2019-01-31 17:29 [PATCH] pinctrl: qcom: qcs404: Correct SDC tile Bjorn Andersson
@ 2019-02-04 11:19 ` Vinod Koul
2019-02-06 8:24 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2019-02-04 11:19 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Linus Walleij, linux-arm-msm, linux-gpio, linux-kernel, stable
On 31-01-19, 09:29, Bjorn Andersson wrote:
> The SDC controls live in the south tile, not the north one. Correct this
> so that we program the right registers.
Reviewed-by: Vinod Koul <vkoul@kernel.org>
>
> Cc: stable@vger.kernel.org
> Fixes: 22eb8301dbc1 ("pinctrl: qcom: Add qcs404 pinctrl driver")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/pinctrl/qcom/pinctrl-qcs404.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-qcs404.c b/drivers/pinctrl/qcom/pinctrl-qcs404.c
> index 7aae52a09ff0..4ffd56ff809e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-qcs404.c
> +++ b/drivers/pinctrl/qcom/pinctrl-qcs404.c
> @@ -79,7 +79,7 @@ enum {
> .intr_cfg_reg = 0, \
> .intr_status_reg = 0, \
> .intr_target_reg = 0, \
> - .tile = NORTH, \
> + .tile = SOUTH, \
> .mux_bit = -1, \
> .pull_bit = pull, \
> .drv_bit = drv, \
> --
> 2.18.0
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: qcom: qcs404: Correct SDC tile
2019-01-31 17:29 [PATCH] pinctrl: qcom: qcs404: Correct SDC tile Bjorn Andersson
2019-02-04 11:19 ` Vinod Koul
@ 2019-02-06 8:24 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-02-06 8:24 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, open list:GPIO SUBSYSTEM, linux-kernel, stable
On Thu, Jan 31, 2019 at 6:30 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> The SDC controls live in the south tile, not the north one. Correct this
> so that we program the right registers.
>
> Cc: stable@vger.kernel.org
> Fixes: 22eb8301dbc1 ("pinctrl: qcom: Add qcs404 pinctrl driver")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Patch applied for fixes with Vinod's review tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-06 8:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-31 17:29 [PATCH] pinctrl: qcom: qcs404: Correct SDC tile Bjorn Andersson
2019-02-04 11:19 ` Vinod Koul
2019-02-06 8:24 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).