linux-next: Fixes tags needs some work in the akpm-current tree

linux-next: Fixes tags needs some work in the akpm-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

Hi all,

In commit

  86c7502b25ed ("mm/vmalloc.c: don't dereference possible NULL pointer in __vunmap()")

Fixes tag

  Fixes: f3c01d2f3ade ("mm: vmalloc: avoid racy handling of debugobjects

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags across more than 1 line.

In commit

  6e9ed490d190 ("mm/page_owner: fix for deferred struct page init")

Fixes tag

  Fixes: fe53ca54270 ("mm: use early_pfn_to_nid in page_ext_init")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags needs some work in the akpm-current tree

[Qian Cai]

On 1/30/19 7:05 PM, Stephen Rothwell wrote:
> In commit
> 
>   6e9ed490d190 ("mm/page_owner: fix for deferred struct page init")
> 
> Fixes tag
> 
>   Fixes: fe53ca54270 ("mm: use early_pfn_to_nid in page_ext_init")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 

I think it is better to replace with this version instead,

https://lore.kernel.org/lkml/20190115202812.75820-1-cai@lca.pw/

Re: linux-next: Fixes tags needs some work in the akpm-current tree

[Liviu Dudau]

On Wed, Jan 30, 2019 at 08:51:42PM -0500, Qian Cai wrote:
> 
> 
> On 1/30/19 7:05 PM, Stephen Rothwell wrote:
> > In commit
> > 
> >   6e9ed490d190 ("mm/page_owner: fix for deferred struct page init")
> > 
> > Fixes tag
> > 
> >   Fixes: fe53ca54270 ("mm: use early_pfn_to_nid in page_ext_init")
> > 
> > has these problem(s):
> > 
> >   - SHA1 should be at least 12 digits long
> >     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> >     or later) just making sure it is not set (or set to "auto").
> > 
> 
> I think it is better to replace with this version instead,
> 
> https://lore.kernel.org/lkml/20190115202812.75820-1-cai@lca.pw/


That patch does not look related, afaict.

Andrew, do you want me to re-send the patch with a fixed commit log, or are you OK to
do some inline editing?

Best regards,
Liviu


-- 
           ________________________________________________________
  ________|                                                        |_______
  \       |  With enough courage, you can do without a reputation  |      /
   \      |                                  -- Rhett Butler       |     /
   /      |________________________________________________________|     \
  /__________)                                                  (_________\

Re: linux-next: Fixes tags needs some work in the akpm-current tree

[Andrew Morton]

On Thu, 31 Jan 2019 22:51:52 +0000 Liviu Dudau <liviu@dudau.co.uk> wrote:

> On Wed, Jan 30, 2019 at 08:51:42PM -0500, Qian Cai wrote:
> > 
> > 
> > On 1/30/19 7:05 PM, Stephen Rothwell wrote:
> > > In commit
> > > 
> > >   6e9ed490d190 ("mm/page_owner: fix for deferred struct page init")
> > > 
> > > Fixes tag
> > > 
> > >   Fixes: fe53ca54270 ("mm: use early_pfn_to_nid in page_ext_init")
> > > 
> > > has these problem(s):
> > > 
> > >   - SHA1 should be at least 12 digits long
> > >     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > >     or later) just making sure it is not set (or set to "auto").
> > > 
> > 
> > I think it is better to replace with this version instead,
> > 
> > https://lore.kernel.org/lkml/20190115202812.75820-1-cai@lca.pw/
> 
> 
> That patch does not look related, afaict.

Confused.

https://lore.kernel.org/lkml/20190115202812.75820-1-cai@lca.pw/
and
https://lore.kernel.org/lkml/20181220203156.43441-1-cai@lca.pw/T/#u

are very much related?

> Andrew, do you want me to re-send the patch with a fixed commit log, or are you OK to
> do some inline editing?

Resend what, exactly?

Re: linux-next: Fixes tags needs some work in the akpm-current tree

[Liviu Dudau]

On Thu, Jan 31, 2019 at 02:57:34PM -0800, Andrew Morton wrote:
> On Thu, 31 Jan 2019 22:51:52 +0000 Liviu Dudau <liviu@dudau.co.uk> wrote:
> 
> > On Wed, Jan 30, 2019 at 08:51:42PM -0500, Qian Cai wrote:
> > > 
> > > 
> > > On 1/30/19 7:05 PM, Stephen Rothwell wrote:
> > > > In commit
> > > > 
> > > >   6e9ed490d190 ("mm/page_owner: fix for deferred struct page init")
> > > > 
> > > > Fixes tag
> > > > 
> > > >   Fixes: fe53ca54270 ("mm: use early_pfn_to_nid in page_ext_init")
> > > > 
> > > > has these problem(s):
> > > > 
> > > >   - SHA1 should be at least 12 digits long
> > > >     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > > >     or later) just making sure it is not set (or set to "auto").
> > > > 
> > > 
> > > I think it is better to replace with this version instead,
> > > 
> > > https://lore.kernel.org/lkml/20190115202812.75820-1-cai@lca.pw/
> > 
> > 
> > That patch does not look related, afaict.
> 
> Confused.
> 
> https://lore.kernel.org/lkml/20190115202812.75820-1-cai@lca.pw/
> and
> https://lore.kernel.org/lkml/20181220203156.43441-1-cai@lca.pw/T/#u
> 
> are very much related?

My bad, I've read the top of the message that was talking about my commit splitting the
Fixes: commit title into multiple lines and assumed that was the only issue reported.


> 
> > Andrew, do you want me to re-send the patch with a fixed commit log, or are you OK to
> > do some inline editing?
> 
> Resend what, exactly?

Content of commit 86c7502b25ed so that the title of the commit it fixes does not spill
over into the next line.

Best regards,
Liviu


-- 
           ________________________________________________________
  ________|                                                        |_______
  \       |  With enough courage, you can do without a reputation  |      /
   \      |                                  -- Rhett Butler       |     /
   /      |________________________________________________________|     \
  /__________)                                                  (_________\