From: Sam Ravnborg <sam@ravnborg.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: DRI Development <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Nicholas Mc Guire <der.herr@hofr.at>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Fabio Rafael da Rosa <fdr@pid42.net>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [PATCH 1/2] staging/vboxvideo: don't set dev_priv_size = 0
Date: Mon, 4 Feb 2019 19:49:11 +0100 [thread overview]
Message-ID: <20190204184911.GB2834@ravnborg.org> (raw)
In-Reply-To: <20190204103114.30772-1-daniel.vetter@ffwll.ch>
Hi Daniel
On Mon, Feb 04, 2019 at 11:31:13AM +0100, Daniel Vetter wrote:
> The compiler already clears this for us.
>
> More important, someone might look what this is actually used for,
> and freak out about the dragon staring back at them.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Nicholas Mc Guire <der.herr@hofr.at>
> Cc: Emil Velikov <emil.velikov@collabora.com>
> Cc: Fabio Rafael da Rosa <fdr@pid42.net>
> ---
> drivers/staging/vboxvideo/vbox_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_drv.c b/drivers/staging/vboxvideo/vbox_drv.c
> index b0d73d5fba5d..43c3d0a4fa1a 100644
> --- a/drivers/staging/vboxvideo/vbox_drv.c
> +++ b/drivers/staging/vboxvideo/vbox_drv.c
> @@ -222,7 +222,6 @@ static void vbox_master_drop(struct drm_device *dev, struct drm_file *file_priv)
> static struct drm_driver driver = {
> .driver_features =
> DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME | DRIVER_ATOMIC,
> - .dev_priv_size = 0,
>
> .lastclose = drm_fb_helper_lastclose,
> .master_set = vbox_master_set,
I have stared at the file for a long time and so far no dragon
was staring back at me. There was a few "#ifdef" that screamed
at me, and a drm_fb_helper_fbdev_setup() that looked
suspicious alas no dragon :-(
As for the change above, dragon or no dragon:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Sam
next prev parent reply other threads:[~2019-02-04 18:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 10:31 [PATCH 1/2] staging/vboxvideo: don't set dev_priv_size = 0 Daniel Vetter
2019-02-04 10:31 ` [PATCH 2/2] staging/vboxvideo: Add TODO Daniel Vetter
2019-02-04 11:05 ` Greg Kroah-Hartman
2019-02-04 18:54 ` Sam Ravnborg
2019-02-06 15:58 ` Daniel Vetter
2019-02-06 16:13 ` Hans de Goede
2019-02-13 18:46 ` Sam Ravnborg
2019-02-13 22:18 ` Hans de Goede
2019-02-04 11:05 ` [PATCH 1/2] staging/vboxvideo: don't set dev_priv_size = 0 Greg Kroah-Hartman
2019-02-04 18:49 ` Sam Ravnborg [this message]
2019-02-04 21:49 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204184911.GB2834@ravnborg.org \
--to=sam@ravnborg.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=der.herr@hofr.at \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=fdr@pid42.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).