From: Daniel Vetter <daniel@ffwll.ch>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Nicholas Mc Guire <der.herr@hofr.at>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Fabio Rafael da Rosa <fdr@pid42.net>
Subject: Re: [PATCH 2/2] staging/vboxvideo: Add TODO
Date: Wed, 6 Feb 2019 16:58:56 +0100 [thread overview]
Message-ID: <20190206155856.GK3271@phenom.ffwll.local> (raw)
In-Reply-To: <20190204185416.GC2834@ravnborg.org>
On Mon, Feb 04, 2019 at 07:54:16PM +0100, Sam Ravnborg wrote:
> Hi Daniel
>
> On Mon, Feb 04, 2019 at 11:31:14AM +0100, Daniel Vetter wrote:
> > Noticed why wonder what vboxvideo is using the ->master_set/drop hooks
> > for.
> Can you improve the gammar a little, I find it hard to read.
>
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Fabio Rafael da Rosa <fdr@pid42.net>
> > Cc: Nicholas Mc Guire <der.herr@hofr.at>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > ---
> > drivers/staging/vboxvideo/TODO | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/staging/vboxvideo/TODO b/drivers/staging/vboxvideo/TODO
> > index 2e0f99c3f10c..2953e7f794fb 100644
> > --- a/drivers/staging/vboxvideo/TODO
> > +++ b/drivers/staging/vboxvideo/TODO
> > @@ -1,5 +1,7 @@
> > TODO:
> > -Get a full review from the drm-maintainers on dri-devel done on this driver
> > +-Drop all the logic around initial_mode_queried/master_set&_drop and everything
> > +related to this. kms clients can handle hotplugs.
> > -Extend this TODO with the results of that review
> >
> > Please send any patches to Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
>
> The syntax around "master_set&_drop" could be better.
> I wondered if the "&" was some rst syntax.
>
> But anyway, despite grammar nit and syntax nit:
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Both patches queued for 5.1 in drm-misc, thanks for taking a look.
> Which bring me back to a question asked a week ago or so.
> What is missing before we can move vboxvideo out of staging/
I think it boils down to someone needs to submit it and we'll take a look.
> Could we carry a few TODO items over in drm/ ar do we need a clean TODO?
We carry todos in drm too, it's going to be a judgement call.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2019-02-06 15:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 10:31 [PATCH 1/2] staging/vboxvideo: don't set dev_priv_size = 0 Daniel Vetter
2019-02-04 10:31 ` [PATCH 2/2] staging/vboxvideo: Add TODO Daniel Vetter
2019-02-04 11:05 ` Greg Kroah-Hartman
2019-02-04 18:54 ` Sam Ravnborg
2019-02-06 15:58 ` Daniel Vetter [this message]
2019-02-06 16:13 ` Hans de Goede
2019-02-13 18:46 ` Sam Ravnborg
2019-02-13 22:18 ` Hans de Goede
2019-02-04 11:05 ` [PATCH 1/2] staging/vboxvideo: don't set dev_priv_size = 0 Greg Kroah-Hartman
2019-02-04 18:49 ` Sam Ravnborg
2019-02-04 21:49 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206155856.GK3271@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=der.herr@hofr.at \
--cc=dri-devel@lists.freedesktop.org \
--cc=fdr@pid42.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).