* [PATCH] fbdev: mxsfb: implement FB_PRE_INIT_FB option
@ 2019-02-06 10:14 ` Martin Kepplinger
2019-04-01 11:44 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Martin Kepplinger @ 2019-02-06 10:14 UTC (permalink / raw)
To: b.zolnierkie, shawnguo, s.hauer, kernel, festevam, linux-imx,
dri-devel, linux-fbdev, linux-arm-kernel
Cc: linux-kernel, Melchior Franz, Manfred Schlaegl
[-- Attachment #1: Type: text/plain, Size: 2386 bytes --]
From: Melchior Franz <melchior.franz@ginzinger.com>
The FB_PRE_INIT_FB option keeps the kernel from reinitializing the display
and prevents flickering during the transition from a bootloader splash
screen to the kernel logo screen.
Make this option available for the mxsfb driver.
Signed-off-by: Melchior Franz <melchior.franz@ginzinger.com>
Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
Signed-off-by: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>
---
drivers/video/fbdev/Kconfig | 2 +-
drivers/video/fbdev/mxsfb.c | 12 ++++++++++++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 58a9590c9db6..0e7ab29c9c70 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -2183,7 +2183,7 @@ config FB_EP93XX
config FB_PRE_INIT_FB
bool "Don't reinitialize, use bootloader's GDC/Display configuration"
- depends on FB && FB_MB862XX_LIME
+ depends on FB && (FB_MB862XX_LIME || FB_MXS)
---help---
Select this option if display contents should be inherited as set by
the bootloader.
diff --git a/drivers/video/fbdev/mxsfb.c b/drivers/video/fbdev/mxsfb.c
index 12c8bd1d24d5..a017200a16b3 100644
--- a/drivers/video/fbdev/mxsfb.c
+++ b/drivers/video/fbdev/mxsfb.c
@@ -181,6 +181,7 @@ struct mxsfb_info {
const struct mxsfb_devdata *devdata;
u32 sync;
struct regulator *reg_lcd;
+ int pre_init;
};
#define mxsfb_is_v3(host) (host->devdata->ipversion == 3)
@@ -419,6 +420,12 @@ static int mxsfb_set_par(struct fb_info *fb_info)
fb_info->fix.line_length = line_size;
+ if (host->pre_init) {
+ mxsfb_enable_controller(fb_info);
+ host->pre_init = 0;
+ return 0;
+ }
+
/*
* It seems, you can't re-program the controller if it is still running.
* This may lead into shifted pictures (FIFO issue?).
@@ -931,6 +938,10 @@ static int mxsfb_probe(struct platform_device *pdev)
if (IS_ERR(host->reg_lcd))
host->reg_lcd = NULL;
+#if defined(CONFIG_FB_PRE_INIT_FB)
+ host->pre_init = 1;
+#endif
+
fb_info->pseudo_palette = devm_kcalloc(&pdev->dev, 16, sizeof(u32),
GFP_KERNEL);
if (!fb_info->pseudo_palette) {
@@ -963,6 +974,7 @@ static int mxsfb_probe(struct platform_device *pdev)
mxsfb_enable_controller(fb_info);
}
+ host->pre_init = 0;
dev_info(&pdev->dev, "initialized\n");
return 0;
--
2.20.1
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3616 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: mxsfb: implement FB_PRE_INIT_FB option
2019-02-06 10:14 ` [PATCH] fbdev: mxsfb: implement FB_PRE_INIT_FB option Martin Kepplinger
@ 2019-04-01 11:44 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-04-01 11:44 UTC (permalink / raw)
To: Martin Kepplinger
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, dri-devel,
linux-fbdev, linux-arm-kernel, linux-kernel, Melchior Franz,
Manfred Schlaegl
On 02/06/2019 11:14 AM, Martin Kepplinger wrote:
> From: Melchior Franz <melchior.franz@ginzinger.com>
>
> The FB_PRE_INIT_FB option keeps the kernel from reinitializing the display
> and prevents flickering during the transition from a bootloader splash
> screen to the kernel logo screen.
>
> Make this option available for the mxsfb driver.
>
> Signed-off-by: Melchior Franz <melchior.franz@ginzinger.com>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> Signed-off-by: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>
Patch queued for v5.2, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-01 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190206101522epcas5p34bb82638cabf533f54e4b64cbbfc286e@epcas5p3.samsung.com>
2019-02-06 10:14 ` [PATCH] fbdev: mxsfb: implement FB_PRE_INIT_FB option Martin Kepplinger
2019-04-01 11:44 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).