* [PATCH] dt-bindings: regulator: update fixed-regulator example
@ 2019-02-08 14:04 Johan Hovold
2019-02-11 17:36 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2019-02-08 14:04 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, Rob Herring, Mark Rutland, devicetree,
linux-kernel, Johan Hovold
Fixed regulators do not have associated bus addresses and are typically
placed directly under the root node where their names must still be
unique despite not having a unit address.
Fix the malformed example node which had a unit address but no "reg"
property by dropping the unit address.
Also, try to make the example more useful by using the recommended
generic node name "regulator", but with a suffix reflecting the
regulator name in order to make it unique.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
.../devicetree/bindings/regulator/fixed-regulator.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
index a7607b0baab7..d289c2f7455a 100644
--- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
@@ -52,9 +52,9 @@ required:
examples:
- |
- abc: fixedregulator@0 {
+ reg_1v8: regulator-1v8 {
compatible = "regulator-fixed";
- regulator-name = "fixed-supply";
+ regulator-name = "1v8";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
gpio = <&gpio1 16 0>;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: regulator: update fixed-regulator example
2019-02-08 14:04 [PATCH] dt-bindings: regulator: update fixed-regulator example Johan Hovold
@ 2019-02-11 17:36 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2019-02-11 17:36 UTC (permalink / raw)
To: Johan Hovold
Cc: Mark Brown, Liam Girdwood, Mark Rutland, devicetree, linux-kernel
On Fri, Feb 8, 2019 at 8:05 AM Johan Hovold <johan@kernel.org> wrote:
>
> Fixed regulators do not have associated bus addresses and are typically
> placed directly under the root node where their names must still be
> unique despite not having a unit address.
>
> Fix the malformed example node which had a unit address but no "reg"
> property by dropping the unit address.
>
> Also, try to make the example more useful by using the recommended
> generic node name "regulator", but with a suffix reflecting the
> regulator name in order to make it unique.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> .../devicetree/bindings/regulator/fixed-regulator.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-11 17:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-08 14:04 [PATCH] dt-bindings: regulator: update fixed-regulator example Johan Hovold
2019-02-11 17:36 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).