linux-next: build failure after merge of the rtc tree

linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1449 bytes --]

Hi Alexandre,

After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/rtc/rtc-x1205: struct of_device_id is 200 bytes.  The last of 1 is:
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x78 0x69 0x72 0x63 0x6f 0x6d 0x2c 0x78 0x31 0x32 0x30 0x35 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
FATAL: drivers/rtc/rtc-x1205: struct of_device_id is not terminated with a NULL entry!

Caused by commit

  08bb868190c2 ("rtc: x1205: Add DT probing support")

I have used the rtc tree from next-20190207 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the rtc tree

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

Hello,

On Mon, Oct 16, 2023 at 03:15:22PM +1100, Stephen Rothwell wrote:
> After merging the rtc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/rtc/rtc-at91rm9200.c:561:13: error: 'at91_rtc_remove' defined but not used [-Werror=unused-function]
>   561 | static void at91_rtc_remove(struct platform_device *pdev)
>       |             ^~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   48bc8830fbed ("rtc: at91rm9200: Convert to platform remove callback returning void")

Ah, yes, sorry I missed that. That's what my coccinelle patch does (for
reasons unknown to me). For some other patches I noticed that, but this
one slipped through.

> This function lost its __exit attribute (which includes a "used"
> attribute) and exit_p(x) is NULL when not being built with
> CONFIG_MODULE set.  This build has CONFIG_RTC_DRV_AT91RM9200=y

The better fix is to add the __exit again and I see that's what
Alexandre did in his rtc-next already.

Thanks for cleaning up after me,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the rtc tree

[Alexandre Belloni]

On 16/10/2023 15:15:22+1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the rtc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/rtc/rtc-at91rm9200.c:561:13: error: 'at91_rtc_remove' defined but not used [-Werror=unused-function]
>   561 | static void at91_rtc_remove(struct platform_device *pdev)
>       |             ^~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   48bc8830fbed ("rtc: at91rm9200: Convert to platform remove callback returning void")
> 
> This function lost its __exit attribute (which includes a "used"
> attribute) and exit_p(x) is NULL when not being built with
> CONFIG_MODULE set.  This build has CONFIG_RTC_DRV_AT91RM9200=y
> 
> I have reverted that commit for today.
> 

Thanks for the report, this is fixed now.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

Hi all,

After merging the rtc tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/rtc/rtc-at91rm9200.c:561:13: error: 'at91_rtc_remove' defined but not used [-Werror=unused-function]
  561 | static void at91_rtc_remove(struct platform_device *pdev)
      |             ^~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  48bc8830fbed ("rtc: at91rm9200: Convert to platform remove callback returning void")

This function lost its __exit attribute (which includes a "used"
attribute) and exit_p(x) is NULL when not being built with
CONFIG_MODULE set.  This build has CONFIG_RTC_DRV_AT91RM9200=y

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the rtc tree

[Romain Perier]

Hi,

Whoops, my bad, it is probably caused by missing CONFIG_WERROR on my side.
It seems to be fixed by
https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?id=27ff63eb076c31086e0a72d41b5c635193a58516

Regards,
Romain

Le lun. 27 sept. 2021 à 05:10, Stephen Rothwell <sfr@canb.auug.org.au> a écrit :
>
> Hi all,
>
> After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/rtc/rtc-msc313.c: In function 'msc313_rtc_read_alarm':
> drivers/rtc/rtc-msc313.c:54:12: error: implicit declaration of function 'readw' [-Werror=implicit-function-declaration]
>    54 |  seconds = readw(priv->rtc_base + REG_RTC_MATCH_VAL_L)
>       |            ^~~~~
> drivers/rtc/rtc-msc313.c: In function 'msc313_rtc_alarm_irq_enable':
> drivers/rtc/rtc-msc313.c:75:2: error: implicit declaration of function 'writew' [-Werror=implicit-function-declaration]
>    75 |  writew(reg, priv->rtc_base + REG_RTC_CTRL);
>       |  ^~~~~~
>
> Caused by commit
>
>   be7d9c9161b9 ("rtc: Add support for the MSTAR MSC313 RTC")
>
> I have used the rtc tree from next-20210924 for today.
>
> --
> Cheers,
> Stephen Rothwell

linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 821 bytes --]

Hi all,

After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/rtc/rtc-msc313.c: In function 'msc313_rtc_read_alarm':
drivers/rtc/rtc-msc313.c:54:12: error: implicit declaration of function 'readw' [-Werror=implicit-function-declaration]
   54 |  seconds = readw(priv->rtc_base + REG_RTC_MATCH_VAL_L)
      |            ^~~~~
drivers/rtc/rtc-msc313.c: In function 'msc313_rtc_alarm_irq_enable':
drivers/rtc/rtc-msc313.c:75:2: error: implicit declaration of function 'writew' [-Werror=implicit-function-declaration]
   75 |  writew(reg, priv->rtc_base + REG_RTC_CTRL);
      |  ^~~~~~

Caused by commit

  be7d9c9161b9 ("rtc: Add support for the MSTAR MSC313 RTC")

I have used the rtc tree from next-20210924 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Hi all,

After merging the rtc tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

ERROR: modpost: missing MODULE_LICENSE() in drivers/rtc/lib_test.o

Caused by commit

  1d1bb12a8b18 ("rtc: Improve performance of rtc_time64_to_tm(). Add tests.")

I have used the rtc tree from next-20210809 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the rtc tree

[Alexandre Belloni]

Hi,

On 16/03/2020 14:58:42+0800, Ran Bi wrote:
> > Caused by commit
> > 
> >   00c36d73171b ("rtc: add support for the MediaTek MT2712 RTC")
> > 
> > I have used the version from next-20200313 for today.
> > 
> 
> This build fail only happen if rtc-mt2712 build as module which I
> haven't try. It because ";" was missed after "MODULE_DEVICE_TABLE(of,
> mt2712_rtc_of_match)". Should I send a fix patch for this or resend the
> whole rtc-mt2712 driver?
> 

I fixed it in my tree.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: linux-next: build failure after merge of the rtc tree

[Ran Bi]

Hi Belloni,

On Mon, 2020-03-16 at 16:15 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/rtc/rtc-mt2712.c: In function 'mt2712_rtc_set_alarm':
> drivers/rtc/rtc-mt2712.c:235:6: warning: unused variable 'irqen' [-Wunused-variable]
>   235 |  u16 irqen;
>       |      ^~~~~
> drivers/rtc/rtc-mt2712.c: At top level:
> drivers/rtc/rtc-mt2712.c:409:1: error: expected ',' or ';' before 'static'
>   409 | static struct platform_driver mt2712_rtc_driver = {
>       | ^~~~~~
> In file included from drivers/rtc/rtc-mt2712.c:14:
> drivers/rtc/rtc-mt2712.c: In function 'mt2712_rtc_driver_init':
> drivers/rtc/rtc-mt2712.c:418:24: error: 'mt2712_rtc_driver' undeclared (first use in this function); did you mean 'mt2712_rtc_probe'?
>   418 | module_platform_driver(mt2712_rtc_driver);
>       |                        ^~~~~~~~~~~~~~~~~
> include/linux/platform_device.h:214:29: note: in definition of macro 'platform_driver_register'
>   214 |  __platform_driver_register(drv, THIS_MODULE)
>       |                             ^~~
> include/linux/platform_device.h:244:2: note: in expansion of macro 'module_driver'
>   244 |  module_driver(__platform_driver, platform_driver_register, \
>       |  ^~~~~~~~~~~~~
> drivers/rtc/rtc-mt2712.c:418:1: note: in expansion of macro 'module_platform_driver'
>   418 | module_platform_driver(mt2712_rtc_driver);
>       | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/rtc/rtc-mt2712.c:418:24: note: each undeclared identifier is reported only once for each function it appears in
>   418 | module_platform_driver(mt2712_rtc_driver);
>       |                        ^~~~~~~~~~~~~~~~~
> include/linux/platform_device.h:214:29: note: in definition of macro 'platform_driver_register'
>   214 |  __platform_driver_register(drv, THIS_MODULE)
>       |                             ^~~
> include/linux/platform_device.h:244:2: note: in expansion of macro 'module_driver'
>   244 |  module_driver(__platform_driver, platform_driver_register, \
>       |  ^~~~~~~~~~~~~
> drivers/rtc/rtc-mt2712.c:418:1: note: in expansion of macro 'module_platform_driver'
>   418 | module_platform_driver(mt2712_rtc_driver);
>       | ^~~~~~~~~~~~~~~~~~~~~~
> In file included from include/linux/device.h:31,
>                  from include/linux/platform_device.h:13,
>                  from drivers/rtc/rtc-mt2712.c:14:
> drivers/rtc/rtc-mt2712.c: In function 'mt2712_rtc_driver_exit':
> drivers/rtc/rtc-mt2712.c:418:24: error: 'mt2712_rtc_driver' undeclared (first use in this function); did you mean 'mt2712_rtc_probe'?
>   418 | module_platform_driver(mt2712_rtc_driver);
>       |                        ^~~~~~~~~~~~~~~~~
> include/linux/device/driver.h:266:17: note: in definition of macro 'module_driver'
>   266 |  __unregister(&(__driver) , ##__VA_ARGS__); \
>       |                 ^~~~~~~~
> drivers/rtc/rtc-mt2712.c:418:1: note: in expansion of macro 'module_platform_driver'
>   418 | module_platform_driver(mt2712_rtc_driver);
>       | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/rtc/rtc-mt2712.c: In function 'mt2712_rtc_driver_init':
> drivers/rtc/rtc-mt2712.c:418:1: warning: control reaches end of non-void function [-Wreturn-type]
>   418 | module_platform_driver(mt2712_rtc_driver);
>       | ^~~~~~~~~~~~~~~~~~~~~~
> At top level:
> drivers/rtc/rtc-mt2712.c:312:12: warning: 'mt2712_rtc_probe' defined but not used [-Wunused-function]
>   312 | static int mt2712_rtc_probe(struct platform_device *pdev)
>       |            ^~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   00c36d73171b ("rtc: add support for the MediaTek MT2712 RTC")
> 
> I have used the version from next-20200313 for today.
> 

This build fail only happen if rtc-mt2712 build as module which I
haven't try. It because ";" was missed after "MODULE_DEVICE_TABLE(of,
mt2712_rtc_of_match)". Should I send a fix patch for this or resend the
whole rtc-mt2712 driver?

Regards,
Ran

linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3607 bytes --]

Hi all,

After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/rtc/rtc-mt2712.c: In function 'mt2712_rtc_set_alarm':
drivers/rtc/rtc-mt2712.c:235:6: warning: unused variable 'irqen' [-Wunused-variable]
  235 |  u16 irqen;
      |      ^~~~~
drivers/rtc/rtc-mt2712.c: At top level:
drivers/rtc/rtc-mt2712.c:409:1: error: expected ',' or ';' before 'static'
  409 | static struct platform_driver mt2712_rtc_driver = {
      | ^~~~~~
In file included from drivers/rtc/rtc-mt2712.c:14:
drivers/rtc/rtc-mt2712.c: In function 'mt2712_rtc_driver_init':
drivers/rtc/rtc-mt2712.c:418:24: error: 'mt2712_rtc_driver' undeclared (first use in this function); did you mean 'mt2712_rtc_probe'?
  418 | module_platform_driver(mt2712_rtc_driver);
      |                        ^~~~~~~~~~~~~~~~~
include/linux/platform_device.h:214:29: note: in definition of macro 'platform_driver_register'
  214 |  __platform_driver_register(drv, THIS_MODULE)
      |                             ^~~
include/linux/platform_device.h:244:2: note: in expansion of macro 'module_driver'
  244 |  module_driver(__platform_driver, platform_driver_register, \
      |  ^~~~~~~~~~~~~
drivers/rtc/rtc-mt2712.c:418:1: note: in expansion of macro 'module_platform_driver'
  418 | module_platform_driver(mt2712_rtc_driver);
      | ^~~~~~~~~~~~~~~~~~~~~~
drivers/rtc/rtc-mt2712.c:418:24: note: each undeclared identifier is reported only once for each function it appears in
  418 | module_platform_driver(mt2712_rtc_driver);
      |                        ^~~~~~~~~~~~~~~~~
include/linux/platform_device.h:214:29: note: in definition of macro 'platform_driver_register'
  214 |  __platform_driver_register(drv, THIS_MODULE)
      |                             ^~~
include/linux/platform_device.h:244:2: note: in expansion of macro 'module_driver'
  244 |  module_driver(__platform_driver, platform_driver_register, \
      |  ^~~~~~~~~~~~~
drivers/rtc/rtc-mt2712.c:418:1: note: in expansion of macro 'module_platform_driver'
  418 | module_platform_driver(mt2712_rtc_driver);
      | ^~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/device.h:31,
                 from include/linux/platform_device.h:13,
                 from drivers/rtc/rtc-mt2712.c:14:
drivers/rtc/rtc-mt2712.c: In function 'mt2712_rtc_driver_exit':
drivers/rtc/rtc-mt2712.c:418:24: error: 'mt2712_rtc_driver' undeclared (first use in this function); did you mean 'mt2712_rtc_probe'?
  418 | module_platform_driver(mt2712_rtc_driver);
      |                        ^~~~~~~~~~~~~~~~~
include/linux/device/driver.h:266:17: note: in definition of macro 'module_driver'
  266 |  __unregister(&(__driver) , ##__VA_ARGS__); \
      |                 ^~~~~~~~
drivers/rtc/rtc-mt2712.c:418:1: note: in expansion of macro 'module_platform_driver'
  418 | module_platform_driver(mt2712_rtc_driver);
      | ^~~~~~~~~~~~~~~~~~~~~~
drivers/rtc/rtc-mt2712.c: In function 'mt2712_rtc_driver_init':
drivers/rtc/rtc-mt2712.c:418:1: warning: control reaches end of non-void function [-Wreturn-type]
  418 | module_platform_driver(mt2712_rtc_driver);
      | ^~~~~~~~~~~~~~~~~~~~~~
At top level:
drivers/rtc/rtc-mt2712.c:312:12: warning: 'mt2712_rtc_probe' defined but not used [-Wunused-function]
  312 | static int mt2712_rtc_probe(struct platform_device *pdev)
      |            ^~~~~~~~~~~~~~~~

Caused by commit

  00c36d73171b ("rtc: add support for the MediaTek MT2712 RTC")

I have used the version from next-20200313 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1453 bytes --]

Hi all,

After merging the rtc tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/rtc/rtc-mc146818-lib.c: In function 'mc146818_set_time':
drivers/rtc/rtc-mc146818-lib.c:176:6: error: 'boot_cpu_data' undeclared (first use in this function); did you mean 'bootmem_data'?
  176 |  if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD ||
      |      ^~~~~~~~~~~~~
      |      bootmem_data
drivers/rtc/rtc-mc146818-lib.c:176:6: note: each undeclared identifier is reported only once for each function it appears in
drivers/rtc/rtc-mc146818-lib.c:176:34: error: 'X86_VENDOR_AMD' undeclared (first use in this function); did you mean 'X86_VENDOR_ANY'?
  176 |  if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD ||
      |                                  ^~~~~~~~~~~~~~
      |                                  X86_VENDOR_ANY
drivers/rtc/rtc-mc146818-lib.c:177:34: error: 'X86_VENDOR_HYGON' undeclared (first use in this function); did you mean 'X86_VENDOR_ANY'?
  177 |      boot_cpu_data.x86_vendor == X86_VENDOR_HYGON)
      |                                  ^~~~~~~~~~~~~~~~
      |                                  X86_VENDOR_ANY

Caused by commit

  1e2c8aadedbe ("rtc: cmos: fix the AltCentury value on AMD/Hygon platform")

This driver file is built for several different architecture, but
the added code is X86 specific :-(

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

Hi all,

After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "rtc_nvmem_unregister" [drivers/rtc/rtc-meson.ko] undefined!

Caused by commit

  21358403bb29 ("rtc: support for the Amlogic Meson RTC")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the rtc tree

[Alexandre Belloni]

Hi,

On 31/05/2017 at 07:45:07 +0200, Heiner Kallweit wrote:
> Am 31.05.2017 um 06:33 schrieb Stephen Rothwell:
> > Hi Alexandre,
> > 
> > After merging the rtc tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> > 
> > drivers/rtc/rtc-ds1307.c: In function 'ds1307_probe':
> > drivers/rtc/rtc-ds1307.c:1410:29: error: 'struct ds1307' has no member named 'client'
> >    if (chip->alarm && (ds1307->client->irq > 0 ||
> >                              ^
> ds1307->client->irq would have to be replaced with ds1307->irq.
> Same what the regmap patch does e.g. at line 1477.
> The regmap patch removes member client from struct ds1307.
> 

Yep, I did that. I actually forgot to push after fixing it up... Sorry
about that!

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: linux-next: build failure after merge of the rtc tree

[Heiner Kallweit]

Am 31.05.2017 um 06:33 schrieb Stephen Rothwell:
> Hi Alexandre,
> 
> After merging the rtc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/rtc/rtc-ds1307.c: In function 'ds1307_probe':
> drivers/rtc/rtc-ds1307.c:1410:29: error: 'struct ds1307' has no member named 'client'
>    if (chip->alarm && (ds1307->client->irq > 0 ||
>                              ^
ds1307->client->irq would have to be replaced with ds1307->irq.
Same what the regmap patch does e.g. at line 1477.
The regmap patch removes member client from struct ds1307.

Rgds, Heiner

> 
> Caused by commit
> 
>   345b89453dda ("rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ")
> 
> interacting with commit
> 
>   11e5890b5342 ("rtc: ds1307: convert driver to regmap")
> 
> I have used the rtc tree from next-20170530 for today.
> 

linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

Hi Alexandre,

After merging the rtc tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/rtc/rtc-ds1307.c: In function 'ds1307_probe':
drivers/rtc/rtc-ds1307.c:1410:29: error: 'struct ds1307' has no member named 'client'
   if (chip->alarm && (ds1307->client->irq > 0 ||
                             ^

Caused by commit

  345b89453dda ("rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ")

interacting with commit

  11e5890b5342 ("rtc: ds1307: convert driver to regmap")

I have used the rtc tree from next-20170530 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

Hi Alexandre,

On Fri, 14 Apr 2017 12:09:47 +0200 Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
>
> On 11/04/2017 at 17:52:20 +1000, Stephen Rothwell wrote:
> > But it is a fix for a build failure caused by a commit in your tree ...
> > so you should probably get an ack from the x86 maintainers and add it
> > to your tree.  Or do some other fix in your tree.
> >   
> 
> It is now in my tree.

Thanks.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the rtc tree

[Alexandre Belloni]

On 11/04/2017 at 17:52:20 +1000, Stephen Rothwell wrote:
> But it is a fix for a build failure caused by a commit in your tree ...
> so you should probably get an ack from the x86 maintainers and add it
> to your tree.  Or do some other fix in your tree.
> 

It is now in my tree.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

Hi Alexandre,

On Tue, 11 Apr 2017 07:55:09 +0200 Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
>
> On 11/04/2017 at 10:22:38 +1000, Stephen Rothwell wrote:
> > 
> > On Mon, 10 Apr 2017 09:45:45 +0200 Hans de Goede <hdegoede@redhat.com> wrote:  
> > >
> > > On 10-04-17 08:04, Stephen Rothwell wrote:  
> > > >
> > > > After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> > > > failed like this:
> > > >
> > > > ERROR: "legacy_pic" [drivers/rtc/rtc-cmos.ko] undefined!
> > > >
> > > > Caused by commit
> > > >
> > > >   d3e3a65c6a96 ("rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs")
> > > >
> > > > "legacy_pic" is not exported to modules.
> > > >
> > > > I have used the rtc tree from next-20170407 for today.    
> > > 
> > > I already send out a patch to fix this yesterday. I've attached a copy.  
> > 
> > I will add that to linux-next today and will drop it when Alexandre
> > adds it (or some other fix).
> 
> I think the x86 maintainers will take it as it is fairly independent.

But it is a fix for a build failure caused by a commit in your tree ...
so you should probably get an ack from the x86 maintainers and add it
to your tree.  Or do some other fix in your tree.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the rtc tree

[Alexandre Belloni]

On 11/04/2017 at 10:22:38 +1000, Stephen Rothwell wrote:
> Hi Hans,
> 
> On Mon, 10 Apr 2017 09:45:45 +0200 Hans de Goede <hdegoede@redhat.com> wrote:
> >
> > On 10-04-17 08:04, Stephen Rothwell wrote:
> > >
> > > After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > >
> > > ERROR: "legacy_pic" [drivers/rtc/rtc-cmos.ko] undefined!
> > >
> > > Caused by commit
> > >
> > >   d3e3a65c6a96 ("rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs")
> > >
> > > "legacy_pic" is not exported to modules.
> > >
> > > I have used the rtc tree from next-20170407 for today.  
> > 
> > I already send out a patch to fix this yesterday. I've attached a copy.
> 
> I will add that to linux-next today and will drop it when Alexandre
> adds it (or some other fix).
> 

I think the x86 maintainers will take it as it is fairly independent.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

Hi Hans,

On Mon, 10 Apr 2017 09:45:45 +0200 Hans de Goede <hdegoede@redhat.com> wrote:
>
> On 10-04-17 08:04, Stephen Rothwell wrote:
> >
> > After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > ERROR: "legacy_pic" [drivers/rtc/rtc-cmos.ko] undefined!
> >
> > Caused by commit
> >
> >   d3e3a65c6a96 ("rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs")
> >
> > "legacy_pic" is not exported to modules.
> >
> > I have used the rtc tree from next-20170407 for today.  
> 
> I already send out a patch to fix this yesterday. I've attached a copy.

I will add that to linux-next today and will drop it when Alexandre
adds it (or some other fix).

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the rtc tree

[Hans de Goede]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

Hi,

On 10-04-17 08:04, Stephen Rothwell wrote:
> Hi Alexandre,
>
> After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> ERROR: "legacy_pic" [drivers/rtc/rtc-cmos.ko] undefined!
>
> Caused by commit
>
>   d3e3a65c6a96 ("rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs")
>
> "legacy_pic" is not exported to modules.
>
> I have used the rtc tree from next-20170407 for today.

I already send out a patch to fix this yesterday. I've attached a copy.

Regards,

Hans

[-- Attachment #2: 0001-x86-i8259-export-legacy_pic-symbol.patch --]
[-- Type: text/x-patch, Size: 1382 bytes --]

>From e869aedc4f19c17057d936f408998da230b92d2f Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdegoede@redhat.com>
Date: Sat, 8 Apr 2017 19:47:45 +0200
Subject: [RFC] x86: i8259: export legacy_pic symbol

The classic PC rtc-coms driver has a workaround for broken ACPI device
nodes for it which lack an irq resource. This workaround used to
unconditionally hardcode the irq to 8 in these cases.

This was causing irq conflict problems on systems without a legacy-pic
so a recent patch added an if (nr_legacy_irqs()) guard to the
workaround to avoid this irq conflict.

nr_legacy_irqs() uses the legacy_pic symbol under the hood causing
an undefined symbol error if the rtc-cmos code is build as a module.

This commit exports the legacy_pic symbol to fix this.

Cc: rtc-linux@googlegroups.com
Cc: alexandre.belloni@free-electrons.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Changes in v2:
-Use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL
---
 arch/x86/kernel/i8259.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c
index be22f5a..0bcf43d 100644
--- a/arch/x86/kernel/i8259.c
+++ b/arch/x86/kernel/i8259.c
@@ -418,6 +418,7 @@ struct legacy_pic default_legacy_pic = {
 };
 
 struct legacy_pic *legacy_pic = &default_legacy_pic;
+EXPORT_SYMBOL_GPL(legacy_pic);
 
 static int __init i8259A_init_ops(void)
 {
-- 
2.9.3

linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

Hi Alexandre,

After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "legacy_pic" [drivers/rtc/rtc-cmos.ko] undefined!

Caused by commit

  d3e3a65c6a96 ("rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs")

"legacy_pic" is not exported to modules.

I have used the rtc tree from next-20170407 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the rtc tree

[Alexandre Belloni]

Hi,

On 08/11/2016 at 17:41:52 +1100, Stephen Rothwell wrote :
> Hi Alexandre,
> 
> After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> 
> Caused by commit
> 
>   f9eb69d1ae2f ("rtc: jz4740: Add support for acting as the system power controller")
> 
> I have used the rtc tree from next-20161028 for today.
> 

Thanks for the report it is fixed in rtc-next now.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

Hi Alexandre,

After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
failed like this:


Caused by commit

  f9eb69d1ae2f ("rtc: jz4740: Add support for acting as the system power controller")

I have used the rtc tree from next-20161028 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the rtc tree

[Alexandre Belloni]

Hi Sasha,

On 18/12/2015 at 17:43:41 +0100, Alexandre Belloni wrote :
> > > Sasha, I think I prefer having 32 bit platforms fail on the 21st of
> > > January 11761191 rather than adding more uses of do_div in the function.
> > > I'll have a look at the performance impact on 32 bit platforms.
> > 
> > I'm really fine with just adding a WARN_ON() and aborting if it's the year
> > 11761191 :)
> > 
> 
> One simple way to solve it for 64bit platforms is to define days as
> unsigned long. Maybe throw a comment that it will fail for 32bit
> platforms in January 11761191 ;).
> 

I did that:

http://git.kernel.org/cgit/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=0d3da1806b985f1100615c2c09033b404941b63e

Unless you disagree, that is what I'm planning to send to Linus.

I wish you a happy end of year.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: linux-next: build failure after merge of the rtc tree

[Alexandre Belloni]

On 18/12/2015 at 10:30:22 -0500, Sasha Levin wrote :
> On 12/17/2015 06:21 AM, Alexandre Belloni wrote:
> > On 17/12/2015 at 16:03:44 +1100, Stephen Rothwell wrote :
> >> > Hi Alexandre,
> >> > 
> >> > After merging the rtc tree, today's linux-next build (arm
> >> > multi_v7_defconfig) failed like this:
> >> > 
> >> > drivers/built-in.o: In function `rtc_time64_to_tm':
> >> > sunxi_sid.c:(.text+0x366e54): undefined reference to `__aeabi_ldivmod'
> >> > sunxi_sid.c:(.text+0x366e6c): undefined reference to `__aeabi_ldivmod'
> >> > 
> >> > Caused by commit
> >> > 
> >> >   bfad4c280be0 ("rtc: fix overflow and incorrect calculation in rtc_time64_to_tm")
> >> > 
> >> > I have used the rtc tree from next-20151216 for today.
> >> > 
> > Well, the kbuild test robot didn't complain at the time so I assumed
> > that it was ok to take the patch but indeed, there are more division
> > further in the function.
> 
> Yeah, I'm not sure what happened here. Compiler optimizations?
> 
> > Sasha, I think I prefer having 32 bit platforms fail on the 21st of
> > January 11761191 rather than adding more uses of do_div in the function.
> > I'll have a look at the performance impact on 32 bit platforms.
> 
> I'm really fine with just adding a WARN_ON() and aborting if it's the year
> 11761191 :)
> 

One simple way to solve it for 64bit platforms is to define days as
unsigned long. Maybe throw a comment that it will fail for 32bit
platforms in January 11761191 ;).

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: linux-next: build failure after merge of the rtc tree

[Sasha Levin]

On 12/17/2015 06:21 AM, Alexandre Belloni wrote:
> On 17/12/2015 at 16:03:44 +1100, Stephen Rothwell wrote :
>> > Hi Alexandre,
>> > 
>> > After merging the rtc tree, today's linux-next build (arm
>> > multi_v7_defconfig) failed like this:
>> > 
>> > drivers/built-in.o: In function `rtc_time64_to_tm':
>> > sunxi_sid.c:(.text+0x366e54): undefined reference to `__aeabi_ldivmod'
>> > sunxi_sid.c:(.text+0x366e6c): undefined reference to `__aeabi_ldivmod'
>> > 
>> > Caused by commit
>> > 
>> >   bfad4c280be0 ("rtc: fix overflow and incorrect calculation in rtc_time64_to_tm")
>> > 
>> > I have used the rtc tree from next-20151216 for today.
>> > 
> Well, the kbuild test robot didn't complain at the time so I assumed
> that it was ok to take the patch but indeed, there are more division
> further in the function.

Yeah, I'm not sure what happened here. Compiler optimizations?

> Sasha, I think I prefer having 32 bit platforms fail on the 21st of
> January 11761191 rather than adding more uses of do_div in the function.
> I'll have a look at the performance impact on 32 bit platforms.

I'm really fine with just adding a WARN_ON() and aborting if it's the year
11761191 :)


Thanks,
Sasha

Re: linux-next: build failure after merge of the rtc tree

[Alexandre Belloni]

On 17/12/2015 at 16:03:44 +1100, Stephen Rothwell wrote :
> Hi Alexandre,
> 
> After merging the rtc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/built-in.o: In function `rtc_time64_to_tm':
> sunxi_sid.c:(.text+0x366e54): undefined reference to `__aeabi_ldivmod'
> sunxi_sid.c:(.text+0x366e6c): undefined reference to `__aeabi_ldivmod'
> 
> Caused by commit
> 
>   bfad4c280be0 ("rtc: fix overflow and incorrect calculation in rtc_time64_to_tm")
> 
> I have used the rtc tree from next-20151216 for today.
> 

Well, the kbuild test robot didn't complain at the time so I assumed
that it was ok to take the patch but indeed, there are more division
further in the function.

Sasha, I think I prefer having 32 bit platforms fail on the 21st of
January 11761191 rather than adding more uses of do_div in the function.
I'll have a look at the performance impact on 32 bit platforms.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

linux-next: build failure after merge of the rtc tree

[Stephen Rothwell]

Hi Alexandre,

After merging the rtc tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/built-in.o: In function `rtc_time64_to_tm':
sunxi_sid.c:(.text+0x366e54): undefined reference to `__aeabi_ldivmod'
sunxi_sid.c:(.text+0x366e6c): undefined reference to `__aeabi_ldivmod'

Caused by commit

  bfad4c280be0 ("rtc: fix overflow and incorrect calculation in rtc_time64_to_tm")

I have used the rtc tree from next-20151216 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au