From: Oleg Nesterov <oleg@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Dmitry Vyukov <dvyukov@google.com>,
Jack Andersen <jackoalan@gmail.com>,
Christian Brauner <christian@brauner.io>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [GIT PULL] signal fixes for v5.0-rc6
Date: Mon, 11 Feb 2019 17:47:56 +0100 [thread overview]
Message-ID: <20190211164755.GD21430@redhat.com> (raw)
In-Reply-To: <87mun6nuql.fsf@xmission.com>
On 02/08, Eric W. Biederman wrote:
>
> signal: Always notice exiting tasks
Sorry, I could not look at these patches before...
So I think this one should be reverted, it makes PTRACE_EVENT_EXIT even more broken.
Once again, why we can't do something like
--- x/kernel/signal.c
+++ x/kernel/signal.c
@@ -209,6 +209,8 @@ int next_signal(struct sigpending *pendi
*/
x = *s &~ *m;
if (x) {
+ if (x & sigmask(SIGKILL))
+ return SIGKILL;
if (x & SYNCHRONOUS_MASK)
x &= SYNCHRONOUS_MASK;
sig = ffz(~x) + 1;
instead? at least for the start.
Oleg.
prev parent reply other threads:[~2019-02-11 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 15:52 [GIT PULL] signal fixes for v5.0-rc6 Eric W. Biederman
2019-02-09 0:40 ` pr-tracker-bot
2019-02-11 16:47 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211164755.GD21430@redhat.com \
--to=oleg@redhat.com \
--cc=christian@brauner.io \
--cc=dvyukov@google.com \
--cc=ebiederm@xmission.com \
--cc=jackoalan@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).