* [GIT PULL] signal fixes for v5.0-rc6
@ 2019-02-08 15:52 Eric W. Biederman
2019-02-09 0:40 ` pr-tracker-bot
2019-02-11 16:47 ` Oleg Nesterov
0 siblings, 2 replies; 3+ messages in thread
From: Eric W. Biederman @ 2019-02-08 15:52 UTC (permalink / raw)
To: Linus Torvalds
Cc: linux-kernel, Oleg Nesterov, Dmitry Vyukov, Jack Andersen,
Christian Brauner, Kees Cook, Thomas Gleixner
Linus,
Please pull the for-linus branch from the git tree:
git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-linus
HEAD:7146db3317c67b517258cb5e1b08af387da0618b signal: Better detection of synchronous signals
This contains 4 small fixes for signal handling. A missing range check,
a regression fix, prioritizing signals we have already started a signal
group exit for, and better detection of synchronous signals.
The confused decision of which signals to handle failed spectacularly
when a timer was pointed at SIGBUS and the stack overflowed. Resulting
in an unkillable process in an infinite loop instead of a SIGSEGV and
core dump.
Eric W. Biederman (4):
signal: Make siginmask safe when passed a signal of 0
signal: Always attempt to allocate siginfo for SIGSTOP
signal: Always notice exiting tasks
signal: Better detection of synchronous signals
include/linux/signal.h | 2 +-
kernel/signal.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++----
2 files changed, 60 insertions(+), 5 deletions(-)
Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL] signal fixes for v5.0-rc6
2019-02-08 15:52 [GIT PULL] signal fixes for v5.0-rc6 Eric W. Biederman
@ 2019-02-09 0:40 ` pr-tracker-bot
2019-02-11 16:47 ` Oleg Nesterov
1 sibling, 0 replies; 3+ messages in thread
From: pr-tracker-bot @ 2019-02-09 0:40 UTC (permalink / raw)
To: Eric W. Biederman
Cc: Linus Torvalds, linux-kernel, Oleg Nesterov, Dmitry Vyukov,
Jack Andersen, Christian Brauner, Kees Cook, Thomas Gleixner
The pull request you sent on Fri, 08 Feb 2019 09:52:02 -0600:
> git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/6b2912cedc238c984e6a4039836ed9c911121076
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL] signal fixes for v5.0-rc6
2019-02-08 15:52 [GIT PULL] signal fixes for v5.0-rc6 Eric W. Biederman
2019-02-09 0:40 ` pr-tracker-bot
@ 2019-02-11 16:47 ` Oleg Nesterov
1 sibling, 0 replies; 3+ messages in thread
From: Oleg Nesterov @ 2019-02-11 16:47 UTC (permalink / raw)
To: Eric W. Biederman
Cc: Linus Torvalds, linux-kernel, Dmitry Vyukov, Jack Andersen,
Christian Brauner, Kees Cook, Thomas Gleixner
On 02/08, Eric W. Biederman wrote:
>
> signal: Always notice exiting tasks
Sorry, I could not look at these patches before...
So I think this one should be reverted, it makes PTRACE_EVENT_EXIT even more broken.
Once again, why we can't do something like
--- x/kernel/signal.c
+++ x/kernel/signal.c
@@ -209,6 +209,8 @@ int next_signal(struct sigpending *pendi
*/
x = *s &~ *m;
if (x) {
+ if (x & sigmask(SIGKILL))
+ return SIGKILL;
if (x & SYNCHRONOUS_MASK)
x &= SYNCHRONOUS_MASK;
sig = ffz(~x) + 1;
instead? at least for the start.
Oleg.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-11 16:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-08 15:52 [GIT PULL] signal fixes for v5.0-rc6 Eric W. Biederman
2019-02-09 0:40 ` pr-tracker-bot
2019-02-11 16:47 ` Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).