linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] uio:remove unneeded variable ret
@ 2019-01-22 14:33 Bo Wang
  2019-02-12  9:18 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Bo Wang @ 2019-01-22 14:33 UTC (permalink / raw)
  To: linux-kernel; +Cc: gregkh, wang.bo116, wangbo

From: wangbo <wdjjwb@163.com>

In uio_dmem_genirq_open the variable ret is unneeded,remove it now.

Signed-off-by: Bo Wang <wang.bo116@zte.com.cn>
---
 drivers/uio/uio_dmem_genirq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
index 003bada..2be7569 100644
--- a/drivers/uio/uio_dmem_genirq.c
+++ b/drivers/uio/uio_dmem_genirq.c
@@ -47,7 +47,6 @@ static int uio_dmem_genirq_open(struct uio_info *info, struct inode *inode)
 {
 	struct uio_dmem_genirq_platdata *priv = info->priv;
 	struct uio_mem *uiomem;
-	int ret = 0;
 	int dmem_region = priv->dmem_region_start;
 
 	uiomem = &priv->uioinfo->mem[priv->dmem_region_start];
@@ -71,7 +70,7 @@ static int uio_dmem_genirq_open(struct uio_info *info, struct inode *inode)
 	mutex_unlock(&priv->alloc_lock);
 	/* Wait until the Runtime PM code has woken up the device */
 	pm_runtime_get_sync(&priv->pdev->dev);
-	return ret;
+	return 0;
 }
 
 static int uio_dmem_genirq_release(struct uio_info *info, struct inode *inode)
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] uio:remove unneeded variable ret
  2019-01-22 14:33 [PATCH v2] uio:remove unneeded variable ret Bo Wang
@ 2019-02-12  9:18 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-02-12  9:18 UTC (permalink / raw)
  To: Bo Wang; +Cc: linux-kernel, wang.bo116

On Tue, Jan 22, 2019 at 10:33:57PM +0800, Bo Wang wrote:
> From: wangbo <wdjjwb@163.com>
> 
> In uio_dmem_genirq_open the variable ret is unneeded,remove it now.
> 
> Signed-off-by: Bo Wang <wang.bo116@zte.com.cn>

This name does not match up with the "From:" line :(

Please fix up and resend.

thanks

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-12  9:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 14:33 [PATCH v2] uio:remove unneeded variable ret Bo Wang
2019-02-12  9:18 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).