* [PATCH] dt-bindings: clock: axg-audio: unexpose controller inputs
@ 2019-02-13 9:58 Jerome Brunet
2019-02-13 11:40 ` Maxime Jourdan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jerome Brunet @ 2019-02-13 9:58 UTC (permalink / raw)
To: Neil Armstrong, Stephen Boyd, Michael Turquette
Cc: Jerome Brunet, Kevin Hilman, linux-kernel, linux-clk,
linux-amlogic, linux-arm-kernel, devicetree, Maxime Jourdan
Remove the bindings ID of the clock input of the controller. These
clocks are purely internal to the controller, exposing them was a
mistake. Actually, these should not even be in the provider and have
IDs to begin with.
Unexpose these IDs before:
* someone starts using them (even if there no valid reason to do so)
* the actual clocks are removed. The fact that they exist is just the
result of an ugly hack. This will be resolved in CCF when we can
reference DT directly in parent table.
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/clk/meson/axg-audio.h | 20 ++++++++++++++++++++
include/dt-bindings/clock/axg-audio-clkc.h | 20 --------------------
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/clk/meson/axg-audio.h b/drivers/clk/meson/axg-audio.h
index 7191b39c9d65..644f0b0fddf2 100644
--- a/drivers/clk/meson/axg-audio.h
+++ b/drivers/clk/meson/axg-audio.h
@@ -60,6 +60,26 @@
#define AUD_CLKID_MST5 6
#define AUD_CLKID_MST6 7
#define AUD_CLKID_MST7 8
+#define AUD_CLKID_SLV_SCLK0 9
+#define AUD_CLKID_SLV_SCLK1 10
+#define AUD_CLKID_SLV_SCLK2 11
+#define AUD_CLKID_SLV_SCLK3 12
+#define AUD_CLKID_SLV_SCLK4 13
+#define AUD_CLKID_SLV_SCLK5 14
+#define AUD_CLKID_SLV_SCLK6 15
+#define AUD_CLKID_SLV_SCLK7 16
+#define AUD_CLKID_SLV_SCLK8 17
+#define AUD_CLKID_SLV_SCLK9 18
+#define AUD_CLKID_SLV_LRCLK0 19
+#define AUD_CLKID_SLV_LRCLK1 20
+#define AUD_CLKID_SLV_LRCLK2 21
+#define AUD_CLKID_SLV_LRCLK3 22
+#define AUD_CLKID_SLV_LRCLK4 23
+#define AUD_CLKID_SLV_LRCLK5 24
+#define AUD_CLKID_SLV_LRCLK6 25
+#define AUD_CLKID_SLV_LRCLK7 26
+#define AUD_CLKID_SLV_LRCLK8 27
+#define AUD_CLKID_SLV_LRCLK9 28
#define AUD_CLKID_MST_A_MCLK_SEL 59
#define AUD_CLKID_MST_B_MCLK_SEL 60
#define AUD_CLKID_MST_C_MCLK_SEL 61
diff --git a/include/dt-bindings/clock/axg-audio-clkc.h b/include/dt-bindings/clock/axg-audio-clkc.h
index fd9c362099d9..eafb0de8466b 100644
--- a/include/dt-bindings/clock/axg-audio-clkc.h
+++ b/include/dt-bindings/clock/axg-audio-clkc.h
@@ -7,26 +7,6 @@
#ifndef __AXG_AUDIO_CLKC_BINDINGS_H
#define __AXG_AUDIO_CLKC_BINDINGS_H
-#define AUD_CLKID_SLV_SCLK0 9
-#define AUD_CLKID_SLV_SCLK1 10
-#define AUD_CLKID_SLV_SCLK2 11
-#define AUD_CLKID_SLV_SCLK3 12
-#define AUD_CLKID_SLV_SCLK4 13
-#define AUD_CLKID_SLV_SCLK5 14
-#define AUD_CLKID_SLV_SCLK6 15
-#define AUD_CLKID_SLV_SCLK7 16
-#define AUD_CLKID_SLV_SCLK8 17
-#define AUD_CLKID_SLV_SCLK9 18
-#define AUD_CLKID_SLV_LRCLK0 19
-#define AUD_CLKID_SLV_LRCLK1 20
-#define AUD_CLKID_SLV_LRCLK2 21
-#define AUD_CLKID_SLV_LRCLK3 22
-#define AUD_CLKID_SLV_LRCLK4 23
-#define AUD_CLKID_SLV_LRCLK5 24
-#define AUD_CLKID_SLV_LRCLK6 25
-#define AUD_CLKID_SLV_LRCLK7 26
-#define AUD_CLKID_SLV_LRCLK8 27
-#define AUD_CLKID_SLV_LRCLK9 28
#define AUD_CLKID_DDR_ARB 29
#define AUD_CLKID_PDM 30
#define AUD_CLKID_TDMIN_A 31
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: clock: axg-audio: unexpose controller inputs
2019-02-13 9:58 [PATCH] dt-bindings: clock: axg-audio: unexpose controller inputs Jerome Brunet
@ 2019-02-13 11:40 ` Maxime Jourdan
2019-02-28 18:27 ` Rob Herring
2019-03-20 8:49 ` Neil Armstrong
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Jourdan @ 2019-02-13 11:40 UTC (permalink / raw)
To: Jerome Brunet
Cc: Neil Armstrong, Stephen Boyd, Michael Turquette, Kevin Hilman,
linux-kernel, linux-clk, linux-amlogic, linux-arm-kernel,
devicetree
On Wed, Feb 13, 2019 at 10:59 AM Jerome Brunet <jbrunet@baylibre.com> wrote:
>
> Remove the bindings ID of the clock input of the controller. These
> clocks are purely internal to the controller, exposing them was a
> mistake. Actually, these should not even be in the provider and have
> IDs to begin with.
>
> Unexpose these IDs before:
> * someone starts using them (even if there no valid reason to do so)
> * the actual clocks are removed. The fact that they exist is just the
> result of an ugly hack. This will be resolved in CCF when we can
> reference DT directly in parent table.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/clk/meson/axg-audio.h | 20 ++++++++++++++++++++
> include/dt-bindings/clock/axg-audio-clkc.h | 20 --------------------
> 2 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/clk/meson/axg-audio.h b/drivers/clk/meson/axg-audio.h
> index 7191b39c9d65..644f0b0fddf2 100644
> --- a/drivers/clk/meson/axg-audio.h
> +++ b/drivers/clk/meson/axg-audio.h
> @@ -60,6 +60,26 @@
> #define AUD_CLKID_MST5 6
> #define AUD_CLKID_MST6 7
> #define AUD_CLKID_MST7 8
> +#define AUD_CLKID_SLV_SCLK0 9
> +#define AUD_CLKID_SLV_SCLK1 10
> +#define AUD_CLKID_SLV_SCLK2 11
> +#define AUD_CLKID_SLV_SCLK3 12
> +#define AUD_CLKID_SLV_SCLK4 13
> +#define AUD_CLKID_SLV_SCLK5 14
> +#define AUD_CLKID_SLV_SCLK6 15
> +#define AUD_CLKID_SLV_SCLK7 16
> +#define AUD_CLKID_SLV_SCLK8 17
> +#define AUD_CLKID_SLV_SCLK9 18
> +#define AUD_CLKID_SLV_LRCLK0 19
> +#define AUD_CLKID_SLV_LRCLK1 20
> +#define AUD_CLKID_SLV_LRCLK2 21
> +#define AUD_CLKID_SLV_LRCLK3 22
> +#define AUD_CLKID_SLV_LRCLK4 23
> +#define AUD_CLKID_SLV_LRCLK5 24
> +#define AUD_CLKID_SLV_LRCLK6 25
> +#define AUD_CLKID_SLV_LRCLK7 26
> +#define AUD_CLKID_SLV_LRCLK8 27
> +#define AUD_CLKID_SLV_LRCLK9 28
> #define AUD_CLKID_MST_A_MCLK_SEL 59
> #define AUD_CLKID_MST_B_MCLK_SEL 60
> #define AUD_CLKID_MST_C_MCLK_SEL 61
> diff --git a/include/dt-bindings/clock/axg-audio-clkc.h b/include/dt-bindings/clock/axg-audio-clkc.h
> index fd9c362099d9..eafb0de8466b 100644
> --- a/include/dt-bindings/clock/axg-audio-clkc.h
> +++ b/include/dt-bindings/clock/axg-audio-clkc.h
> @@ -7,26 +7,6 @@
> #ifndef __AXG_AUDIO_CLKC_BINDINGS_H
> #define __AXG_AUDIO_CLKC_BINDINGS_H
>
> -#define AUD_CLKID_SLV_SCLK0 9
> -#define AUD_CLKID_SLV_SCLK1 10
> -#define AUD_CLKID_SLV_SCLK2 11
> -#define AUD_CLKID_SLV_SCLK3 12
> -#define AUD_CLKID_SLV_SCLK4 13
> -#define AUD_CLKID_SLV_SCLK5 14
> -#define AUD_CLKID_SLV_SCLK6 15
> -#define AUD_CLKID_SLV_SCLK7 16
> -#define AUD_CLKID_SLV_SCLK8 17
> -#define AUD_CLKID_SLV_SCLK9 18
> -#define AUD_CLKID_SLV_LRCLK0 19
> -#define AUD_CLKID_SLV_LRCLK1 20
> -#define AUD_CLKID_SLV_LRCLK2 21
> -#define AUD_CLKID_SLV_LRCLK3 22
> -#define AUD_CLKID_SLV_LRCLK4 23
> -#define AUD_CLKID_SLV_LRCLK5 24
> -#define AUD_CLKID_SLV_LRCLK6 25
> -#define AUD_CLKID_SLV_LRCLK7 26
> -#define AUD_CLKID_SLV_LRCLK8 27
> -#define AUD_CLKID_SLV_LRCLK9 28
> #define AUD_CLKID_DDR_ARB 29
> #define AUD_CLKID_PDM 30
> #define AUD_CLKID_TDMIN_A 31
> --
> 2.20.1
>
Acked-by: Maxime Jourdan <mjourdan@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: clock: axg-audio: unexpose controller inputs
2019-02-13 9:58 [PATCH] dt-bindings: clock: axg-audio: unexpose controller inputs Jerome Brunet
2019-02-13 11:40 ` Maxime Jourdan
@ 2019-02-28 18:27 ` Rob Herring
2019-03-20 8:49 ` Neil Armstrong
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2019-02-28 18:27 UTC (permalink / raw)
To: Jerome Brunet
Cc: Neil Armstrong, Stephen Boyd, Michael Turquette, Jerome Brunet,
Kevin Hilman, linux-kernel, linux-clk, linux-amlogic,
linux-arm-kernel, devicetree, Maxime Jourdan
On Wed, 13 Feb 2019 10:58:35 +0100, Jerome Brunet wrote:
> Remove the bindings ID of the clock input of the controller. These
> clocks are purely internal to the controller, exposing them was a
> mistake. Actually, these should not even be in the provider and have
> IDs to begin with.
>
> Unexpose these IDs before:
> * someone starts using them (even if there no valid reason to do so)
> * the actual clocks are removed. The fact that they exist is just the
> result of an ugly hack. This will be resolved in CCF when we can
> reference DT directly in parent table.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/clk/meson/axg-audio.h | 20 ++++++++++++++++++++
> include/dt-bindings/clock/axg-audio-clkc.h | 20 --------------------
> 2 files changed, 20 insertions(+), 20 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: clock: axg-audio: unexpose controller inputs
2019-02-13 9:58 [PATCH] dt-bindings: clock: axg-audio: unexpose controller inputs Jerome Brunet
2019-02-13 11:40 ` Maxime Jourdan
2019-02-28 18:27 ` Rob Herring
@ 2019-03-20 8:49 ` Neil Armstrong
2 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2019-03-20 8:49 UTC (permalink / raw)
To: Jerome Brunet, Stephen Boyd, Michael Turquette
Cc: Kevin Hilman, linux-kernel, linux-clk, linux-amlogic,
linux-arm-kernel, devicetree, Maxime Jourdan
On 13/02/2019 10:58, Jerome Brunet wrote:
> Remove the bindings ID of the clock input of the controller. These
> clocks are purely internal to the controller, exposing them was a
> mistake. Actually, these should not even be in the provider and have
> IDs to begin with.
>
> Unexpose these IDs before:
> * someone starts using them (even if there no valid reason to do so)
> * the actual clocks are removed. The fact that they exist is just the
> result of an ugly hack. This will be resolved in CCF when we can
> reference DT directly in parent table.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/clk/meson/axg-audio.h | 20 ++++++++++++++++++++
> include/dt-bindings/clock/axg-audio-clkc.h | 20 --------------------
> 2 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/clk/meson/axg-audio.h b/drivers/clk/meson/axg-audio.h
> index 7191b39c9d65..644f0b0fddf2 100644
> --- a/drivers/clk/meson/axg-audio.h
> +++ b/drivers/clk/meson/axg-audio.h
> @@ -60,6 +60,26 @@
> #define AUD_CLKID_MST5 6
> #define AUD_CLKID_MST6 7
> #define AUD_CLKID_MST7 8
> +#define AUD_CLKID_SLV_SCLK0 9
> +#define AUD_CLKID_SLV_SCLK1 10
> +#define AUD_CLKID_SLV_SCLK2 11
> +#define AUD_CLKID_SLV_SCLK3 12
> +#define AUD_CLKID_SLV_SCLK4 13
> +#define AUD_CLKID_SLV_SCLK5 14
> +#define AUD_CLKID_SLV_SCLK6 15
> +#define AUD_CLKID_SLV_SCLK7 16
> +#define AUD_CLKID_SLV_SCLK8 17
> +#define AUD_CLKID_SLV_SCLK9 18
> +#define AUD_CLKID_SLV_LRCLK0 19
> +#define AUD_CLKID_SLV_LRCLK1 20
> +#define AUD_CLKID_SLV_LRCLK2 21
> +#define AUD_CLKID_SLV_LRCLK3 22
> +#define AUD_CLKID_SLV_LRCLK4 23
> +#define AUD_CLKID_SLV_LRCLK5 24
> +#define AUD_CLKID_SLV_LRCLK6 25
> +#define AUD_CLKID_SLV_LRCLK7 26
> +#define AUD_CLKID_SLV_LRCLK8 27
> +#define AUD_CLKID_SLV_LRCLK9 28
> #define AUD_CLKID_MST_A_MCLK_SEL 59
> #define AUD_CLKID_MST_B_MCLK_SEL 60
> #define AUD_CLKID_MST_C_MCLK_SEL 61
> diff --git a/include/dt-bindings/clock/axg-audio-clkc.h b/include/dt-bindings/clock/axg-audio-clkc.h
> index fd9c362099d9..eafb0de8466b 100644
> --- a/include/dt-bindings/clock/axg-audio-clkc.h
> +++ b/include/dt-bindings/clock/axg-audio-clkc.h
> @@ -7,26 +7,6 @@
> #ifndef __AXG_AUDIO_CLKC_BINDINGS_H
> #define __AXG_AUDIO_CLKC_BINDINGS_H
>
> -#define AUD_CLKID_SLV_SCLK0 9
> -#define AUD_CLKID_SLV_SCLK1 10
> -#define AUD_CLKID_SLV_SCLK2 11
> -#define AUD_CLKID_SLV_SCLK3 12
> -#define AUD_CLKID_SLV_SCLK4 13
> -#define AUD_CLKID_SLV_SCLK5 14
> -#define AUD_CLKID_SLV_SCLK6 15
> -#define AUD_CLKID_SLV_SCLK7 16
> -#define AUD_CLKID_SLV_SCLK8 17
> -#define AUD_CLKID_SLV_SCLK9 18
> -#define AUD_CLKID_SLV_LRCLK0 19
> -#define AUD_CLKID_SLV_LRCLK1 20
> -#define AUD_CLKID_SLV_LRCLK2 21
> -#define AUD_CLKID_SLV_LRCLK3 22
> -#define AUD_CLKID_SLV_LRCLK4 23
> -#define AUD_CLKID_SLV_LRCLK5 24
> -#define AUD_CLKID_SLV_LRCLK6 25
> -#define AUD_CLKID_SLV_LRCLK7 26
> -#define AUD_CLKID_SLV_LRCLK8 27
> -#define AUD_CLKID_SLV_LRCLK9 28
> #define AUD_CLKID_DDR_ARB 29
> #define AUD_CLKID_PDM 30
> #define AUD_CLKID_TDMIN_A 31
>
Applied to next/drivers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-20 8:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-13 9:58 [PATCH] dt-bindings: clock: axg-audio: unexpose controller inputs Jerome Brunet
2019-02-13 11:40 ` Maxime Jourdan
2019-02-28 18:27 ` Rob Herring
2019-03-20 8:49 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).