From: Greg KH <gregkh@linuxfoundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Liu Bo <bo.liu@linux.alibaba.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] mm: Fix the pgtable leak
Date: Wed, 13 Feb 2019 14:36:24 +0100 [thread overview]
Message-ID: <20190213133624.GB9460@kroah.com> (raw)
In-Reply-To: <20190213112900.33963-1-minchan@kernel.org>
On Wed, Feb 13, 2019 at 08:29:00PM +0900, Minchan Kim wrote:
> [1] was backported to v4.9 stable tree but it introduces pgtable
> memory leak because with fault retrial, preallocated pagetable
> could be leaked in second iteration.
> To fix the problem, this patch backport [2].
>
> [1] 5cf3e5ff95876, mm, memcg: fix reclaim deadlock with writeback
This is really commit 63f3655f9501 ("mm, memcg: fix reclaim deadlock
with writeback") which was in 4.9.152, 4.14.94, 4.19.16, and 4.20.3 as
well as 5.0-rc2.
> [2] b0b9b3df27d10, mm: stop leaking PageTables
This commit was in 4.10, so I am guessing that this really is just a
backport of that commit?
If so, it's not the full backport, why not take the whole thing? Why
only cherry-pick one chunk of it? Why do we not need the other parts?
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-13 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 11:29 [PATCH] mm: Fix the pgtable leak Minchan Kim
2019-02-13 11:33 ` Minchan Kim
2019-02-13 12:03 ` Michal Hocko
2019-02-13 12:12 ` Minchan Kim
2019-02-13 12:24 ` Michal Hocko
2019-02-14 7:25 ` Minchan Kim
2019-02-13 13:36 ` Greg KH [this message]
2019-02-14 7:23 ` Minchan Kim
2019-02-18 8:20 ` Minchan Kim
2019-02-18 8:33 ` Greg KH
2019-02-18 13:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213133624.GB9460@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=bo.liu@linux.alibaba.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).