From: Minchan Kim <minchan@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Liu Bo <bo.liu@linux.alibaba.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] mm: Fix the pgtable leak
Date: Mon, 18 Feb 2019 17:20:26 +0900 [thread overview]
Message-ID: <20190218082026.GA88360@google.com> (raw)
In-Reply-To: <20190214072352.GA15820@google.com>
On Thu, Feb 14, 2019 at 04:23:52PM +0900, Minchan Kim wrote:
> On Wed, Feb 13, 2019 at 02:36:24PM +0100, Greg KH wrote:
> > On Wed, Feb 13, 2019 at 08:29:00PM +0900, Minchan Kim wrote:
> > > [1] was backported to v4.9 stable tree but it introduces pgtable
> > > memory leak because with fault retrial, preallocated pagetable
> > > could be leaked in second iteration.
> > > To fix the problem, this patch backport [2].
> > >
> > > [1] 5cf3e5ff95876, mm, memcg: fix reclaim deadlock with writeback
> >
> > This is really commit 63f3655f9501 ("mm, memcg: fix reclaim deadlock
> > with writeback") which was in 4.9.152, 4.14.94, 4.19.16, and 4.20.3 as
> > well as 5.0-rc2.
>
> Since 4.10, we has [2] so it should be okay other (tree > 4.10)
>
> >
> > > [2] b0b9b3df27d10, mm: stop leaking PageTables
> >
> > This commit was in 4.10, so I am guessing that this really is just a
> > backport of that commit?
>
> Yub.
>
> >
> > If so, it's not the full backport, why not take the whole thing? Why
> > only cherry-pick one chunk of it? Why do we not need the other parts?
>
> Because [2] actually aims for fixing [3] which was introduced at 4.10.
> Since then, [1] relies on the chunk I sent. Thus we don't need other part
> for 4.9.
>
> [3] 953c66c2b22a ("mm: THP page cache support for ppc64")
Hi Greg,
Any chance to look into this patch?
next prev parent reply other threads:[~2019-02-18 8:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 11:29 [PATCH] mm: Fix the pgtable leak Minchan Kim
2019-02-13 11:33 ` Minchan Kim
2019-02-13 12:03 ` Michal Hocko
2019-02-13 12:12 ` Minchan Kim
2019-02-13 12:24 ` Michal Hocko
2019-02-14 7:25 ` Minchan Kim
2019-02-13 13:36 ` Greg KH
2019-02-14 7:23 ` Minchan Kim
2019-02-18 8:20 ` Minchan Kim [this message]
2019-02-18 8:33 ` Greg KH
2019-02-18 13:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218082026.GA88360@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bo.liu@linux.alibaba.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).