* [PATCH] isdn:hisax: Replace dev_kfree_skb_any by dev_consume_skb_any
@ 2019-02-14 6:39 Huang Zijiang
2019-02-14 17:22 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Huang Zijiang @ 2019-02-14 6:39 UTC (permalink / raw)
To: isdn
Cc: davem, natechancellor, yuehaibing, baijiaju1990, netdev,
linux-kernel, wang.yi59, Huang Zijiang
The skb should be freed by dev_consume_skb_any() in hfcpci_fill_fifo()
when bcs->tx_skb is still used. The bcs->tx_skb is be replaced by
skb_dequeue(&bcs->squeue), so the original bcs->tx_skb should
be consumed(not drop).
Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>
---
drivers/isdn/hisax/hfc_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hisax/hfc_pci.c b/drivers/isdn/hisax/hfc_pci.c
index ea0e4c6..7f9e8cc 100644
--- a/drivers/isdn/hisax/hfc_pci.c
+++ b/drivers/isdn/hisax/hfc_pci.c
@@ -657,7 +657,7 @@ hfcpci_fill_fifo(struct BCState *bcs)
schedule_event(bcs, B_ACKPENDING);
}
- dev_kfree_skb_any(bcs->tx_skb);
+ dev_consume_skb_any(bcs->tx_skb);
bcs->tx_skb = skb_dequeue(&bcs->squeue); /* fetch next data */
}
test_and_clear_bit(BC_FLG_BUSY, &bcs->Flag);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] isdn:hisax: Replace dev_kfree_skb_any by dev_consume_skb_any
2019-02-14 6:39 [PATCH] isdn:hisax: Replace dev_kfree_skb_any by dev_consume_skb_any Huang Zijiang
@ 2019-02-14 17:22 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-02-14 17:22 UTC (permalink / raw)
To: huang.zijiang
Cc: isdn, natechancellor, yuehaibing, baijiaju1990, netdev,
linux-kernel, wang.yi59
From: Huang Zijiang <huang.zijiang@zte.com.cn>
Date: Thu, 14 Feb 2019 14:39:59 +0800
> The skb should be freed by dev_consume_skb_any() in hfcpci_fill_fifo()
> when bcs->tx_skb is still used. The bcs->tx_skb is be replaced by
> skb_dequeue(&bcs->squeue), so the original bcs->tx_skb should
> be consumed(not drop).
>
> Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-14 17:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 6:39 [PATCH] isdn:hisax: Replace dev_kfree_skb_any by dev_consume_skb_any Huang Zijiang
2019-02-14 17:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).