linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] liquidio: using NULL instead of plain integer
@ 2019-02-16  9:53 YueHaibing
  2019-02-19  0:42 ` David Miller
  0 siblings, 1 reply; 4+ messages in thread
From: YueHaibing @ 2019-02-16  9:53 UTC (permalink / raw)
  To: davem, dchickles, sburla, fmanlunas; +Cc: linux-kernel, netdev, YueHaibing

Fix following warning:

drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c:1453:35: warning: Using plain integer as NULL pointer
drivers/net/ethernet/cavium/liquidio/lio_main.c:2910:23: warning: Using plain integer as NULL pointer

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c | 2 +-
 drivers/net/ethernet/cavium/liquidio/lio_main.c         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c
index 9f4f3c1d..43d11c3 100644
--- a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c
+++ b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c
@@ -1450,7 +1450,7 @@ void cn23xx_tell_vf_its_macaddr_changed(struct octeon_device *oct, int vfidx,
 		mbox_cmd.recv_len = 0;
 		mbox_cmd.recv_status = 0;
 		mbox_cmd.fn = NULL;
-		mbox_cmd.fn_arg = 0;
+		mbox_cmd.fn_arg = NULL;
 		ether_addr_copy(mbox_cmd.msg.s.params, mac);
 		mbox_cmd.q_no = vfidx * oct->sriov_info.rings_per_vf;
 		octeon_mbox_write(oct, &mbox_cmd);
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index e97e675..9b7819f 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
@@ -2907,7 +2907,7 @@ static int liquidio_set_vf_spoofchk(struct net_device *netdev, int vfidx,
 	nctrl.ncmd.s.param2 = enable;
 	nctrl.ncmd.s.more = 0;
 	nctrl.iq_no = lio->linfo.txpciq[0].s.q_no;
-	nctrl.cb_fn = 0;
+	nctrl.cb_fn = NULL;
 
 	retval = octnet_send_nic_ctrl_pkt(oct, &nctrl);
 
-- 
2.7.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH net-next] liquidio: using NULL instead of plain integer
  2019-02-16  9:53 [PATCH net-next] liquidio: using NULL instead of plain integer YueHaibing
@ 2019-02-19  0:42 ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-02-19  0:42 UTC (permalink / raw)
  To: yuehaibing; +Cc: dchickles, sburla, fmanlunas, linux-kernel, netdev

From: YueHaibing <yuehaibing@huawei.com>
Date: Sat, 16 Feb 2019 17:53:10 +0800

> Fix following warning:
> 
> drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c:1453:35: warning: Using plain integer as NULL pointer
> drivers/net/ethernet/cavium/liquidio/lio_main.c:2910:23: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH net-next] liquidio: Using NULL instead of plain integer
  2018-07-17  9:27 [PATCH net-next] liquidio: Using " YueHaibing
@ 2018-07-18 20:41 ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-07-18 20:41 UTC (permalink / raw)
  To: yuehaibing
  Cc: derek.chickles, satananda.burla, linux-kernel, netdev,
	felix.manlunas, raghu.vatsavayi

From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 17 Jul 2018 17:27:13 +0800

> Fixes the following sparse warnings:
> 
> drivers/net/ethernet/cavium/liquidio/lio_main.c:3068:23: warning:
>  Using plain integer as NULL pointer
> drivers/net/ethernet/cavium/liquidio/lio_main.c:2909:23: warning:
>  Using plain integer as NULL pointer
> drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c:385:27: warning:
>  Using plain integer as NULL pointer
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH net-next] liquidio: Using NULL instead of plain integer
@ 2018-07-17  9:27 YueHaibing
  2018-07-18 20:41 ` David Miller
  0 siblings, 1 reply; 4+ messages in thread
From: YueHaibing @ 2018-07-17  9:27 UTC (permalink / raw)
  To: derek.chickles, satananda.burla
  Cc: linux-kernel, netdev, felix.manlunas, raghu.vatsavayi, davem, YueHaibing

Fixes the following sparse warnings:

drivers/net/ethernet/cavium/liquidio/lio_main.c:3068:23: warning:
 Using plain integer as NULL pointer
drivers/net/ethernet/cavium/liquidio/lio_main.c:2909:23: warning:
 Using plain integer as NULL pointer
drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c:385:27: warning:
 Using plain integer as NULL pointer

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c | 2 +-
 drivers/net/ethernet/cavium/liquidio/lio_main.c         | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c b/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c
index 1f8b7f6..91dce8b 100644
--- a/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c
+++ b/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c
@@ -382,7 +382,7 @@ void cn23xx_vf_ask_pf_to_do_flr(struct octeon_device *oct)
 	mbox_cmd.recv_len = 0;
 	mbox_cmd.recv_status = 0;
 	mbox_cmd.fn = NULL;
-	mbox_cmd.fn_arg = 0;
+	mbox_cmd.fn_arg = NULL;
 
 	octeon_mbox_write(oct, &mbox_cmd);
 }
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index a60d5af..dd76477 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
@@ -2906,7 +2906,7 @@ static int liquidio_set_vf_vlan(struct net_device *netdev, int vfidx,
 	    vfidx + 1; /* vfidx is 0 based, but vf_num (param2) is 1 based */
 	nctrl.ncmd.s.more = 0;
 	nctrl.iq_no = lio->linfo.txpciq[0].s.q_no;
-	nctrl.cb_fn = 0;
+	nctrl.cb_fn = NULL;
 	nctrl.wait_time = LIO_CMD_WAIT_TM;
 
 	octnet_send_nic_ctrl_pkt(oct, &nctrl);
@@ -3065,7 +3065,7 @@ static int liquidio_set_vf_link_state(struct net_device *netdev, int vfidx,
 	nctrl.ncmd.s.param2 = linkstate;
 	nctrl.ncmd.s.more = 0;
 	nctrl.iq_no = lio->linfo.txpciq[0].s.q_no;
-	nctrl.cb_fn = 0;
+	nctrl.cb_fn = NULL;
 	nctrl.wait_time = LIO_CMD_WAIT_TM;
 
 	octnet_send_nic_ctrl_pkt(oct, &nctrl);
-- 
2.7.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-19  0:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-16  9:53 [PATCH net-next] liquidio: using NULL instead of plain integer YueHaibing
2019-02-19  0:42 ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2018-07-17  9:27 [PATCH net-next] liquidio: Using " YueHaibing
2018-07-18 20:41 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).