* [PATCH] orinoco : Replace function name in string with __func__
@ 2019-02-17 16:25 Keyur Patel
2019-02-19 15:17 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Keyur Patel @ 2019-02-17 16:25 UTC (permalink / raw)
Cc: iamkeyur96, Kalle Valo, David S. Miller, Eric Biggers,
Herbert Xu, linux-wireless, netdev, linux-kernel
From: Keyur Patel <iamkeyur96@gmail.com>
Replace hard coded function name with __func__, to
improve robustness and to conform to the Linux kernel coding
style. Issue found using checkpatch.
Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
---
drivers/net/wireless/intersil/orinoco/mic.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/intersil/orinoco/mic.c b/drivers/net/wireless/intersil/orinoco/mic.c
index 709d9ab3e7bc..67b0c05afbdb 100644
--- a/drivers/net/wireless/intersil/orinoco/mic.c
+++ b/drivers/net/wireless/intersil/orinoco/mic.c
@@ -18,16 +18,16 @@ int orinoco_mic_init(struct orinoco_private *priv)
{
priv->tx_tfm_mic = crypto_alloc_shash("michael_mic", 0, 0);
if (IS_ERR(priv->tx_tfm_mic)) {
- printk(KERN_DEBUG "orinoco_mic_init: could not allocate "
- "crypto API michael_mic\n");
+ printk(KERN_DEBUG "%s: could not allocate "
+ "crypto API michael_mic\n", __func__);
priv->tx_tfm_mic = NULL;
return -ENOMEM;
}
priv->rx_tfm_mic = crypto_alloc_shash("michael_mic", 0, 0);
if (IS_ERR(priv->rx_tfm_mic)) {
- printk(KERN_DEBUG "orinoco_mic_init: could not allocate "
- "crypto API michael_mic\n");
+ printk(KERN_DEBUG "%s: could not allocate "
+ "crypto API michael_mic\n", __func__);
priv->rx_tfm_mic = NULL;
return -ENOMEM;
}
@@ -52,7 +52,7 @@ int orinoco_mic(struct crypto_shash *tfm_michael, u8 *key,
int err;
if (tfm_michael == NULL) {
- printk(KERN_WARNING "orinoco_mic: tfm_michael == NULL\n");
+ printk(KERN_WARNING "%s: tfm_michael == NULL\n", __func__);
return -1;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] orinoco : Replace function name in string with __func__
2019-02-17 16:25 [PATCH] orinoco : Replace function name in string with __func__ Keyur Patel
@ 2019-02-19 15:17 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-02-19 15:17 UTC (permalink / raw)
To: Keyur Patel
Keyur Patel <iamkeyur96@gmail.com> wrote:
> From: Keyur Patel <iamkeyur96@gmail.com>
>
> Replace hard coded function name with __func__, to
> improve robustness and to conform to the Linux kernel coding
> style. Issue found using checkpatch.
>
> Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
25f87d8b63b8 orinoco : Replace function name in string with __func__
--
https://patchwork.kernel.org/patch/10817203/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-19 15:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-17 16:25 [PATCH] orinoco : Replace function name in string with __func__ Keyur Patel
2019-02-19 15:17 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).