linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] selftests/ftrace: Make the coloring POSIX compliant
@ 2019-02-20 16:13 Juerg Haefliger
  2019-02-20 19:49 ` Steven Rostedt
                   ` (2 more replies)
  0 siblings, 3 replies; 24+ messages in thread
From: Juerg Haefliger @ 2019-02-20 16:13 UTC (permalink / raw)
  To: linux-kernel, rostedt, mingo; +Cc: Juerg Haefliger

echo -e and \e are not POSIX. Depending on what /bin/sh is, we can get
incorrect output like:
$ -e -n [1] Basic trace file check
$ -e 	[PASS]

Fix that by using \033 instead of \e and printf.

Signed-off-by: Juerg Haefliger <juergh@canonical.com>
---
 tools/testing/selftests/ftrace/ftracetest | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index fc755e1b50f1..f200898e3e2c 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -161,10 +161,10 @@ color_green=
 color_blue=
 # If stdout exists and number of colors is eight or more, use them
 if [ -t 1 -a "$ncolors" -ge 8 ]; then
-  color_reset="\e[0m"
-  color_red="\e[31m"
-  color_green="\e[32m"
-  color_blue="\e[34m"
+  color_reset="\033[0m"
+  color_red="\033[31m"
+  color_green="\033[32m"
+  color_blue="\033[34m"
 fi
 
 strip_esc() {
@@ -173,8 +173,13 @@ strip_esc() {
 }
 
 prlog() { # messages
-  echo -e "$@"
-  [ "$LOG_FILE" ] && echo -e "$@" | strip_esc >> $LOG_FILE
+  newline="\n"
+  if [ "$1" = "-n" ] ; then
+    newline=
+    shift
+  fi
+  printf "$@$newline"
+  [ "$LOG_FILE" ] && printf "$@$newline" | strip_esc >> $LOG_FILE
 }
 catlog() { #file
   cat $1
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2019-02-25 13:01 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-20 16:13 [PATCH] selftests/ftrace: Make the coloring POSIX compliant Juerg Haefliger
2019-02-20 19:49 ` Steven Rostedt
2019-02-20 20:20   ` Juerg Haefliger
2019-02-20 20:33     ` Adam Borowski
2019-02-22  0:29 ` Masami Hiramatsu
2019-02-22  9:10 ` [PATCH v2 0/2] selftests/ftrace: Make ftracetest " Juerg Haefliger
2019-02-22  9:10   ` [PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
2019-02-22 14:58     ` Masami Hiramatsu
2019-02-22 15:58       ` shuah
2019-02-22  9:10   ` [PATCH v2 2/2] selftests/ftrace: Replace \e with \033 Juerg Haefliger
2019-02-22 14:59     ` Masami Hiramatsu
2019-02-22 15:59       ` shuah
2019-02-22 19:03         ` Steven Rostedt
2019-02-22 20:52   ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
2019-02-22 20:52     ` [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
2019-02-22 20:53   ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
2019-02-22 20:53     ` [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
2019-02-22 20:53   ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
2019-02-22 20:53     ` [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
2019-02-22 22:33       ` shuah
2019-02-22 20:53     ` [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033 Juerg Haefliger
2019-02-22 22:46       ` shuah
2019-02-23 12:25         ` Juerg Haefliger
2019-02-25 13:00           ` shuah

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).