* [PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf
2019-02-22 9:10 ` [PATCH v2 0/2] selftests/ftrace: Make ftracetest " Juerg Haefliger
@ 2019-02-22 9:10 ` Juerg Haefliger
2019-02-22 14:58 ` Masami Hiramatsu
2019-02-22 9:10 ` [PATCH v2 2/2] selftests/ftrace: Replace \e with \033 Juerg Haefliger
` (3 subsequent siblings)
4 siblings, 1 reply; 24+ messages in thread
From: Juerg Haefliger @ 2019-02-22 9:10 UTC (permalink / raw)
To: linux-kernel, rostedt, mingo, mhiramat; +Cc: Juerg Haefliger
echo -e is not POSIX. Depending on what /bin/sh is, we can get
incorrect output like:
$ -e -n [1] Basic trace file check
$ -e [PASS]
Fix that by using printf instead.
Signed-off-by: Juerg Haefliger <juergh@canonical.com>
---
tools/testing/selftests/ftrace/ftracetest | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index fc755e1b50f1..20c9c0ad8682 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -173,8 +173,13 @@ strip_esc() {
}
prlog() { # messages
- echo -e "$@"
- [ "$LOG_FILE" ] && echo -e "$@" | strip_esc >> $LOG_FILE
+ newline="\n"
+ if [ "$1" = "-n" ] ; then
+ newline=
+ shift
+ fi
+ printf "$*$newline"
+ [ "$LOG_FILE" ] && printf "$*$newline" | strip_esc >> $LOG_FILE
}
catlog() { #file
cat $1
--
2.19.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf
2019-02-22 9:10 ` [PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
@ 2019-02-22 14:58 ` Masami Hiramatsu
2019-02-22 15:58 ` shuah
0 siblings, 1 reply; 24+ messages in thread
From: Masami Hiramatsu @ 2019-02-22 14:58 UTC (permalink / raw)
To: Juerg Haefliger, Shuah Khan; +Cc: linux-kernel, rostedt, mingo, Juerg Haefliger
On Fri, 22 Feb 2019 10:10:20 +0100
Juerg Haefliger <juerg.haefliger@canonical.com> wrote:
> echo -e is not POSIX. Depending on what /bin/sh is, we can get
> incorrect output like:
> $ -e -n [1] Basic trace file check
> $ -e [PASS]
>
> Fix that by using printf instead.
>
> Signed-off-by: Juerg Haefliger <juergh@canonical.com>
Looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
> ---
> tools/testing/selftests/ftrace/ftracetest | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index fc755e1b50f1..20c9c0ad8682 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -173,8 +173,13 @@ strip_esc() {
> }
>
> prlog() { # messages
> - echo -e "$@"
> - [ "$LOG_FILE" ] && echo -e "$@" | strip_esc >> $LOG_FILE
> + newline="\n"
> + if [ "$1" = "-n" ] ; then
> + newline=
> + shift
> + fi
> + printf "$*$newline"
> + [ "$LOG_FILE" ] && printf "$*$newline" | strip_esc >> $LOG_FILE
> }
> catlog() { #file
> cat $1
> --
> 2.19.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf
2019-02-22 14:58 ` Masami Hiramatsu
@ 2019-02-22 15:58 ` shuah
0 siblings, 0 replies; 24+ messages in thread
From: shuah @ 2019-02-22 15:58 UTC (permalink / raw)
To: Masami Hiramatsu, Juerg Haefliger
Cc: linux-kernel, rostedt, mingo, Juerg Haefliger, shuah
Hi Juerg,
On 2/22/19 7:58 AM, Masami Hiramatsu wrote:
> On Fri, 22 Feb 2019 10:10:20 +0100
> Juerg Haefliger <juerg.haefliger@canonical.com> wrote:
>
>> echo -e is not POSIX. Depending on what /bin/sh is, we can get
>> incorrect output like:
>> $ -e -n [1] Basic trace file check
>> $ -e [PASS]
>>
>> Fix that by using printf instead.
>>
>> Signed-off-by: Juerg Haefliger <juergh@canonical.com>
>
> Looks good to me.
>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>
I wasn't on the To or Cc on the original patch. Make sure to
run the get_maintainers and include the people it recommends.
Please resend the patch to me, so I can take it for 5.1-rc1
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 2/2] selftests/ftrace: Replace \e with \033
2019-02-22 9:10 ` [PATCH v2 0/2] selftests/ftrace: Make ftracetest " Juerg Haefliger
2019-02-22 9:10 ` [PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
@ 2019-02-22 9:10 ` Juerg Haefliger
2019-02-22 14:59 ` Masami Hiramatsu
2019-02-22 20:52 ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
` (2 subsequent siblings)
4 siblings, 1 reply; 24+ messages in thread
From: Juerg Haefliger @ 2019-02-22 9:10 UTC (permalink / raw)
To: linux-kernel, rostedt, mingo, mhiramat; +Cc: Juerg Haefliger
The \e sequence character is not POSIX. Fix that by using \033 instead.
Signed-off-by: Juerg Haefliger <juergh@canonical.com>
---
tools/testing/selftests/ftrace/ftracetest | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index 20c9c0ad8682..136387422b00 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -161,10 +161,10 @@ color_green=
color_blue=
# If stdout exists and number of colors is eight or more, use them
if [ -t 1 -a "$ncolors" -ge 8 ]; then
- color_reset="\e[0m"
- color_red="\e[31m"
- color_green="\e[32m"
- color_blue="\e[34m"
+ color_reset="\033[0m"
+ color_red="\033[31m"
+ color_green="\033[32m"
+ color_blue="\033[34m"
fi
strip_esc() {
--
2.19.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] selftests/ftrace: Replace \e with \033
2019-02-22 9:10 ` [PATCH v2 2/2] selftests/ftrace: Replace \e with \033 Juerg Haefliger
@ 2019-02-22 14:59 ` Masami Hiramatsu
2019-02-22 15:59 ` shuah
0 siblings, 1 reply; 24+ messages in thread
From: Masami Hiramatsu @ 2019-02-22 14:59 UTC (permalink / raw)
To: Juerg Haefliger, Shuah Khan; +Cc: linux-kernel, rostedt, mingo, Juerg Haefliger
On Fri, 22 Feb 2019 10:10:21 +0100
Juerg Haefliger <juerg.haefliger@canonical.com> wrote:
> The \e sequence character is not POSIX. Fix that by using \033 instead.
>
> Signed-off-by: Juerg Haefliger <juergh@canonical.com>
This also looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you!
> ---
> tools/testing/selftests/ftrace/ftracetest | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index 20c9c0ad8682..136387422b00 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -161,10 +161,10 @@ color_green=
> color_blue=
> # If stdout exists and number of colors is eight or more, use them
> if [ -t 1 -a "$ncolors" -ge 8 ]; then
> - color_reset="\e[0m"
> - color_red="\e[31m"
> - color_green="\e[32m"
> - color_blue="\e[34m"
> + color_reset="\033[0m"
> + color_red="\033[31m"
> + color_green="\033[32m"
> + color_blue="\033[34m"
> fi
>
> strip_esc() {
> --
> 2.19.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] selftests/ftrace: Replace \e with \033
2019-02-22 14:59 ` Masami Hiramatsu
@ 2019-02-22 15:59 ` shuah
2019-02-22 19:03 ` Steven Rostedt
0 siblings, 1 reply; 24+ messages in thread
From: shuah @ 2019-02-22 15:59 UTC (permalink / raw)
To: Masami Hiramatsu, Juerg Haefliger
Cc: linux-kernel, rostedt, mingo, Juerg Haefliger, shuah
On 2/22/19 7:59 AM, Masami Hiramatsu wrote:
> On Fri, 22 Feb 2019 10:10:21 +0100
> Juerg Haefliger <juerg.haefliger@canonical.com> wrote:
>
>> The \e sequence character is not POSIX. Fix that by using \033 instead.
>>
>> Signed-off-by: Juerg Haefliger <juergh@canonical.com>
>
> This also looks good to me.
>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>
> Thank you!
>
I wasn't on the To or Cc on the original patch. Make sure to
run the get_maintainers and include the people it recommends.
Please resend the patch to me, so I can take it for 5.1-rc1
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/2] selftests/ftrace: Replace \e with \033
2019-02-22 15:59 ` shuah
@ 2019-02-22 19:03 ` Steven Rostedt
0 siblings, 0 replies; 24+ messages in thread
From: Steven Rostedt @ 2019-02-22 19:03 UTC (permalink / raw)
To: shuah
Cc: Masami Hiramatsu, Juerg Haefliger, linux-kernel, mingo, Juerg Haefliger
On Fri, 22 Feb 2019 08:59:42 -0700
shuah <shuah@kernel.org> wrote:
> On 2/22/19 7:59 AM, Masami Hiramatsu wrote:
> > On Fri, 22 Feb 2019 10:10:21 +0100
> > Juerg Haefliger <juerg.haefliger@canonical.com> wrote:
> >
> >> The \e sequence character is not POSIX. Fix that by using \033 instead.
> >>
> >> Signed-off-by: Juerg Haefliger <juergh@canonical.com>
> >
> > This also looks good to me.
> >
> > Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> >
> > Thank you!
> >
>
>
> I wasn't on the To or Cc on the original patch. Make sure to
> run the get_maintainers and include the people it recommends.
>
> Please resend the patch to me, so I can take it for 5.1-rc1
And add both Masami and my Acked-by when you send it to Shuah (for both
patches).
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
^ permalink raw reply [flat|nested] 24+ messages in thread
* [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant
2019-02-22 9:10 ` [PATCH v2 0/2] selftests/ftrace: Make ftracetest " Juerg Haefliger
2019-02-22 9:10 ` [PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
2019-02-22 9:10 ` [PATCH v2 2/2] selftests/ftrace: Replace \e with \033 Juerg Haefliger
@ 2019-02-22 20:52 ` Juerg Haefliger
2019-02-22 20:52 ` [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
2019-02-22 20:53 ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
2019-02-22 20:53 ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
4 siblings, 1 reply; 24+ messages in thread
From: Juerg Haefliger @ 2019-02-22 20:52 UTC (permalink / raw)
To: linux-kernel, rostedt, mingo, mhiramat, shuah, linux-kselftest
Cc: Juerg Haefliger
Add shuah@kernel.org and linux-kselftest@vger.kernel.org.
The recent addition of colored output introduced some non-POSIX-compliant
constructs. Fix that.
Juerg Haefliger (2):
selftests/ftrace: Replace echo -e with printf
selftests/ftrace: Replace \e with \033
tools/testing/selftests/ftrace/ftracetest | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 24+ messages in thread
* [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf
2019-02-22 20:52 ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
@ 2019-02-22 20:52 ` Juerg Haefliger
0 siblings, 0 replies; 24+ messages in thread
From: Juerg Haefliger @ 2019-02-22 20:52 UTC (permalink / raw)
To: linux-kernel, rostedt, mingo, mhiramat, shuah, linux-kselftest
Cc: Juerg Haefliger
echo -e is not POSIX. Depending on what /bin/sh is, we can get
incorrect output like:
$ -e -n [1] Basic trace file check
$ -e [PASS]
Fix that by using printf instead.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Juerg Haefliger <juergh@canonical.com>
---
tools/testing/selftests/ftrace/ftracetest | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index fc755e1b50f1..20c9c0ad8682 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -173,8 +173,13 @@ strip_esc() {
}
prlog() { # messages
- echo -e "$@"
- [ "$LOG_FILE" ] && echo -e "$@" | strip_esc >> $LOG_FILE
+ newline="\n"
+ if [ "$1" = "-n" ] ; then
+ newline=
+ shift
+ fi
+ printf "$*$newline"
+ [ "$LOG_FILE" ] && printf "$*$newline" | strip_esc >> $LOG_FILE
}
catlog() { #file
cat $1
--
2.19.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant
2019-02-22 9:10 ` [PATCH v2 0/2] selftests/ftrace: Make ftracetest " Juerg Haefliger
` (2 preceding siblings ...)
2019-02-22 20:52 ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
@ 2019-02-22 20:53 ` Juerg Haefliger
2019-02-22 20:53 ` [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
2019-02-22 20:53 ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
4 siblings, 1 reply; 24+ messages in thread
From: Juerg Haefliger @ 2019-02-22 20:53 UTC (permalink / raw)
To: linux-kernel, rostedt, mingo, mhiramat, shuah, linux-kselftest
Cc: Juerg Haefliger
Add shuah@kernel.org and linux-kselftest@vger.kernel.org.
The recent addition of colored output introduced some non-POSIX-compliant
constructs. Fix that.
Juerg Haefliger (2):
selftests/ftrace: Replace echo -e with printf
selftests/ftrace: Replace \e with \033
tools/testing/selftests/ftrace/ftracetest | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 24+ messages in thread
* [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf
2019-02-22 20:53 ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
@ 2019-02-22 20:53 ` Juerg Haefliger
0 siblings, 0 replies; 24+ messages in thread
From: Juerg Haefliger @ 2019-02-22 20:53 UTC (permalink / raw)
To: linux-kernel, rostedt, mingo, mhiramat, shuah, linux-kselftest
Cc: Juerg Haefliger
echo -e is not POSIX. Depending on what /bin/sh is, we can get
incorrect output like:
$ -e -n [1] Basic trace file check
$ -e [PASS]
Fix that by using printf instead.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Juerg Haefliger <juergh@canonical.com>
---
tools/testing/selftests/ftrace/ftracetest | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index fc755e1b50f1..20c9c0ad8682 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -173,8 +173,13 @@ strip_esc() {
}
prlog() { # messages
- echo -e "$@"
- [ "$LOG_FILE" ] && echo -e "$@" | strip_esc >> $LOG_FILE
+ newline="\n"
+ if [ "$1" = "-n" ] ; then
+ newline=
+ shift
+ fi
+ printf "$*$newline"
+ [ "$LOG_FILE" ] && printf "$*$newline" | strip_esc >> $LOG_FILE
}
catlog() { #file
cat $1
--
2.19.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant
2019-02-22 9:10 ` [PATCH v2 0/2] selftests/ftrace: Make ftracetest " Juerg Haefliger
` (3 preceding siblings ...)
2019-02-22 20:53 ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
@ 2019-02-22 20:53 ` Juerg Haefliger
2019-02-22 20:53 ` [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
2019-02-22 20:53 ` [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033 Juerg Haefliger
4 siblings, 2 replies; 24+ messages in thread
From: Juerg Haefliger @ 2019-02-22 20:53 UTC (permalink / raw)
To: linux-kernel, rostedt, mingo, mhiramat, shuah, linux-kselftest
Cc: Juerg Haefliger
Add shuah@kernel.org and linux-kselftest@vger.kernel.org.
The recent addition of colored output introduced some non-POSIX-compliant
constructs. Fix that.
Juerg Haefliger (2):
selftests/ftrace: Replace echo -e with printf
selftests/ftrace: Replace \e with \033
tools/testing/selftests/ftrace/ftracetest | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 24+ messages in thread
* [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf
2019-02-22 20:53 ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
@ 2019-02-22 20:53 ` Juerg Haefliger
2019-02-22 22:33 ` shuah
2019-02-22 20:53 ` [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033 Juerg Haefliger
1 sibling, 1 reply; 24+ messages in thread
From: Juerg Haefliger @ 2019-02-22 20:53 UTC (permalink / raw)
To: linux-kernel, rostedt, mingo, mhiramat, shuah, linux-kselftest
Cc: Juerg Haefliger
echo -e is not POSIX. Depending on what /bin/sh is, we can get
incorrect output like:
$ -e -n [1] Basic trace file check
$ -e [PASS]
Fix that by using printf instead.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Juerg Haefliger <juergh@canonical.com>
---
tools/testing/selftests/ftrace/ftracetest | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index fc755e1b50f1..20c9c0ad8682 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -173,8 +173,13 @@ strip_esc() {
}
prlog() { # messages
- echo -e "$@"
- [ "$LOG_FILE" ] && echo -e "$@" | strip_esc >> $LOG_FILE
+ newline="\n"
+ if [ "$1" = "-n" ] ; then
+ newline=
+ shift
+ fi
+ printf "$*$newline"
+ [ "$LOG_FILE" ] && printf "$*$newline" | strip_esc >> $LOG_FILE
}
catlog() { #file
cat $1
--
2.19.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf
2019-02-22 20:53 ` [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
@ 2019-02-22 22:33 ` shuah
0 siblings, 0 replies; 24+ messages in thread
From: shuah @ 2019-02-22 22:33 UTC (permalink / raw)
To: Juerg Haefliger, linux-kernel, rostedt, mingo, mhiramat, linux-kselftest
Cc: Juerg Haefliger, shuah
On 2/22/19 1:53 PM, Juerg Haefliger wrote:
> echo -e is not POSIX. Depending on what /bin/sh is, we can get
> incorrect output like:
> $ -e -n [1] Basic trace file check
> $ -e [PASS]
>
> Fix that by using printf instead.
>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> Signed-off-by: Juerg Haefliger <juergh@canonical.com>
> ---
> tools/testing/selftests/ftrace/ftracetest | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index fc755e1b50f1..20c9c0ad8682 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -173,8 +173,13 @@ strip_esc() {
> }
>
> prlog() { # messages
> - echo -e "$@"
> - [ "$LOG_FILE" ] && echo -e "$@" | strip_esc >> $LOG_FILE
> + newline="\n"
> + if [ "$1" = "-n" ] ; then
> + newline=
> + shift
> + fi
> + printf "$*$newline"
> + [ "$LOG_FILE" ] && printf "$*$newline" | strip_esc >> $LOG_FILE
> }
> catlog() { #file
> cat $1
>
This patch applied to linux-kselftest next which is at 5.0rc6
I queued this for 5.1-rc1.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 24+ messages in thread
* [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033
2019-02-22 20:53 ` [RESEND PATCH v2 0/2] selftests/ftrace: Make ftracetest POSIX compliant Juerg Haefliger
2019-02-22 20:53 ` [RESEND PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf Juerg Haefliger
@ 2019-02-22 20:53 ` Juerg Haefliger
2019-02-22 22:46 ` shuah
1 sibling, 1 reply; 24+ messages in thread
From: Juerg Haefliger @ 2019-02-22 20:53 UTC (permalink / raw)
To: linux-kernel, rostedt, mingo, mhiramat, shuah, linux-kselftest
Cc: Juerg Haefliger
The \e sequence character is not POSIX. Fix that by using \033 instead.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Juerg Haefliger <juergh@canonical.com>
---
tools/testing/selftests/ftrace/ftracetest | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index 20c9c0ad8682..136387422b00 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -161,10 +161,10 @@ color_green=
color_blue=
# If stdout exists and number of colors is eight or more, use them
if [ -t 1 -a "$ncolors" -ge 8 ]; then
- color_reset="\e[0m"
- color_red="\e[31m"
- color_green="\e[32m"
- color_blue="\e[34m"
+ color_reset="\033[0m"
+ color_red="\033[31m"
+ color_green="\033[32m"
+ color_blue="\033[34m"
fi
strip_esc() {
--
2.19.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033
2019-02-22 20:53 ` [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033 Juerg Haefliger
@ 2019-02-22 22:46 ` shuah
2019-02-23 12:25 ` Juerg Haefliger
0 siblings, 1 reply; 24+ messages in thread
From: shuah @ 2019-02-22 22:46 UTC (permalink / raw)
To: Juerg Haefliger, linux-kernel, rostedt, mingo, mhiramat, linux-kselftest
Cc: Juerg Haefliger, shuah
On 2/22/19 1:53 PM, Juerg Haefliger wrote:
> The \e sequence character is not POSIX. Fix that by using \033 instead.
>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> Signed-off-by: Juerg Haefliger <juergh@canonical.com>
> ---
> tools/testing/selftests/ftrace/ftracetest | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index 20c9c0ad8682..136387422b00 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -161,10 +161,10 @@ color_green=
> color_blue=
> # If stdout exists and number of colors is eight or more, use them
> if [ -t 1 -a "$ncolors" -ge 8 ]; then
> - color_reset="\e[0m"
> - color_red="\e[31m"
> - color_green="\e[32m"
> - color_blue="\e[34m"
> + color_reset="\033[0m"
> + color_red="\033[31m"
> + color_green="\033[32m"
> + color_blue="\033[34m"
> fi
>
> strip_esc() {
>
Which release is this patch based on?
This one failed to apply to linux-kselftest next - I resolved a minor
merge conflict and applied it. Please review to make sure it looks good.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033
2019-02-22 22:46 ` shuah
@ 2019-02-23 12:25 ` Juerg Haefliger
2019-02-25 13:00 ` shuah
0 siblings, 1 reply; 24+ messages in thread
From: Juerg Haefliger @ 2019-02-23 12:25 UTC (permalink / raw)
To: shuah
Cc: Juerg Haefliger, linux-kernel, rostedt, mingo, mhiramat, linux-kselftest
[-- Attachment #1: Type: text/plain, Size: 1661 bytes --]
On Fri, 22 Feb 2019 15:46:03 -0700
shuah <shuah@kernel.org> wrote:
> On 2/22/19 1:53 PM, Juerg Haefliger wrote:
> > The \e sequence character is not POSIX. Fix that by using \033 instead.
> >
> > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> > Signed-off-by: Juerg Haefliger <juergh@canonical.com>
> > ---
> > tools/testing/selftests/ftrace/ftracetest | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> > index 20c9c0ad8682..136387422b00 100755
> > --- a/tools/testing/selftests/ftrace/ftracetest
> > +++ b/tools/testing/selftests/ftrace/ftracetest
> > @@ -161,10 +161,10 @@ color_green=
> > color_blue=
> > # If stdout exists and number of colors is eight or more, use them
> > if [ -t 1 -a "$ncolors" -ge 8 ]; then
> > - color_reset="\e[0m"
> > - color_red="\e[31m"
> > - color_green="\e[32m"
> > - color_blue="\e[34m"
> > + color_reset="\033[0m"
> > + color_red="\033[31m"
> > + color_green="\033[32m"
> > + color_blue="\033[34m"
> > fi
> >
> > strip_esc() {
> >
>
> Which release is this patch based on?
>
> This one failed to apply to linux-kselftest next - I resolved a minor
> merge conflict and applied it. Please review to make sure it looks good.
Looks good. It didn't apply cleanly because you don't have
https://lore.kernel.org/lkml/20190220153706.24686-1-juergh@canonical.com/T/#u
Sorry about not copying you on that patch. Want me to resend?
...Juerg
> thanks,
> -- Shuah
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033
2019-02-23 12:25 ` Juerg Haefliger
@ 2019-02-25 13:00 ` shuah
0 siblings, 0 replies; 24+ messages in thread
From: shuah @ 2019-02-25 13:00 UTC (permalink / raw)
To: Juerg Haefliger
Cc: linux-kernel, rostedt, mingo, mhiramat, linux-kselftest, shuah
On 2/23/19 5:25 AM, Juerg Haefliger wrote:
> On Fri, 22 Feb 2019 15:46:03 -0700
> shuah <shuah@kernel.org> wrote:
>
>> On 2/22/19 1:53 PM, Juerg Haefliger wrote:
>>> The \e sequence character is not POSIX. Fix that by using \033 instead.
>>>
>>> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>>> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>>> Signed-off-by: Juerg Haefliger <juergh@canonical.com>
>>> ---
>>> tools/testing/selftests/ftrace/ftracetest | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
>>> index 20c9c0ad8682..136387422b00 100755
>>> --- a/tools/testing/selftests/ftrace/ftracetest
>>> +++ b/tools/testing/selftests/ftrace/ftracetest
>>> @@ -161,10 +161,10 @@ color_green=
>>> color_blue=
>>> # If stdout exists and number of colors is eight or more, use them
>>> if [ -t 1 -a "$ncolors" -ge 8 ]; then
>>> - color_reset="\e[0m"
>>> - color_red="\e[31m"
>>> - color_green="\e[32m"
>>> - color_blue="\e[34m"
>>> + color_reset="\033[0m"
>>> + color_red="\033[31m"
>>> + color_green="\033[32m"
>>> + color_blue="\033[34m"
>>> fi
>>>
>>> strip_esc() {
>>>
>>
>> Which release is this patch based on?
>>
>> This one failed to apply to linux-kselftest next - I resolved a minor
>> merge conflict and applied it. Please review to make sure it looks good.
>
> Looks good. It didn't apply cleanly because you don't have
> https://lore.kernel.org/lkml/20190220153706.24686-1-juergh@canonical.com/T/#u
> Sorry about not copying you on that patch. Want me to resend?
>
> ...Juerg
>
Yes. Please.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 24+ messages in thread