* [PATCH] drm/bochs: Fix the ID mismatch error
@ 2019-02-21 0:33 Alistair Francis
2019-02-21 11:52 ` kraxel
0 siblings, 1 reply; 5+ messages in thread
From: Alistair Francis @ 2019-02-21 0:33 UTC (permalink / raw)
To: kraxel, virtualization
Cc: dri-devel, linux-kernel, alistair23, david.abdurachmanov,
linux-riscv, Alistair Francis
When running RISC-V QEMU with the Bochs device attached via PCIe the
probe of the Bochs device fails with:
[drm:bochs_hw_init] *ERROR* ID mismatch
This was introduced by this commit:
7780eb9ce8 bochs: convert to drm_dev_register
To fix the error we ensure that pci_enable_device() is called before
bochs_load().
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Reported-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
---
drivers/gpu/drm/bochs/bochs_drv.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c
index f3dd66ae990a..aa35007262cd 100644
--- a/drivers/gpu/drm/bochs/bochs_drv.c
+++ b/drivers/gpu/drm/bochs/bochs_drv.c
@@ -154,6 +154,10 @@ static int bochs_pci_probe(struct pci_dev *pdev,
if (IS_ERR(dev))
return PTR_ERR(dev);
+ ret = pci_enable_device(pdev);
+ if (ret)
+ goto err_free_dev;
+
dev->pdev = pdev;
pci_set_drvdata(pdev, dev);
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bochs: Fix the ID mismatch error
2019-02-21 0:33 [PATCH] drm/bochs: Fix the ID mismatch error Alistair Francis
@ 2019-02-21 11:52 ` kraxel
2019-02-21 18:44 ` Alistair Francis
0 siblings, 1 reply; 5+ messages in thread
From: kraxel @ 2019-02-21 11:52 UTC (permalink / raw)
To: Alistair Francis
Cc: virtualization, dri-devel, linux-kernel, alistair23,
david.abdurachmanov, linux-riscv
On Thu, Feb 21, 2019 at 12:33:03AM +0000, Alistair Francis wrote:
> When running RISC-V QEMU with the Bochs device attached via PCIe the
> probe of the Bochs device fails with:
> [drm:bochs_hw_init] *ERROR* ID mismatch
>
> This was introduced by this commit:
> 7780eb9ce8 bochs: convert to drm_dev_register
>
> To fix the error we ensure that pci_enable_device() is called before
> bochs_load().
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> Reported-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
Pushed to drm-misc-fixes.
thanks,
Gerd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bochs: Fix the ID mismatch error
2019-02-21 11:52 ` kraxel
@ 2019-02-21 18:44 ` Alistair Francis
2019-02-22 5:37 ` kraxel
0 siblings, 1 reply; 5+ messages in thread
From: Alistair Francis @ 2019-02-21 18:44 UTC (permalink / raw)
To: kraxel
Cc: Alistair Francis, virtualization, dri-devel, linux-kernel,
david.abdurachmanov, linux-riscv
On Thu, Feb 21, 2019 at 3:52 AM kraxel@redhat.com <kraxel@redhat.com> wrote:
>
> On Thu, Feb 21, 2019 at 12:33:03AM +0000, Alistair Francis wrote:
> > When running RISC-V QEMU with the Bochs device attached via PCIe the
> > probe of the Bochs device fails with:
> > [drm:bochs_hw_init] *ERROR* ID mismatch
> >
> > This was introduced by this commit:
> > 7780eb9ce8 bochs: convert to drm_dev_register
> >
> > To fix the error we ensure that pci_enable_device() is called before
> > bochs_load().
> >
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > Reported-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
>
> Pushed to drm-misc-fixes.
Thanks. Any chance this will make it into 5.0?
Alistair
>
> thanks,
> Gerd
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bochs: Fix the ID mismatch error
2019-02-21 18:44 ` Alistair Francis
@ 2019-02-22 5:37 ` kraxel
2019-02-22 18:05 ` Alistair Francis
0 siblings, 1 reply; 5+ messages in thread
From: kraxel @ 2019-02-22 5:37 UTC (permalink / raw)
To: Alistair Francis
Cc: Alistair Francis, virtualization, dri-devel, linux-kernel,
david.abdurachmanov, linux-riscv
On Thu, Feb 21, 2019 at 10:44:06AM -0800, Alistair Francis wrote:
> On Thu, Feb 21, 2019 at 3:52 AM kraxel@redhat.com <kraxel@redhat.com> wrote:
> >
> > On Thu, Feb 21, 2019 at 12:33:03AM +0000, Alistair Francis wrote:
> > > When running RISC-V QEMU with the Bochs device attached via PCIe the
> > > probe of the Bochs device fails with:
> > > [drm:bochs_hw_init] *ERROR* ID mismatch
> > >
> > > This was introduced by this commit:
> > > 7780eb9ce8 bochs: convert to drm_dev_register
> > >
> > > To fix the error we ensure that pci_enable_device() is called before
> > > bochs_load().
> > >
> > > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > > Reported-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> >
> > Pushed to drm-misc-fixes.
>
> Thanks. Any chance this will make it into 5.0?
Hmm, we are damn close to the release, not sure there will be one more
drm-fixes pull req. But I've added a proper Fixes: tag, so even if the
patch misses the boat it should land in the stable branches shortly
thereafter.
cheers,
Gerd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bochs: Fix the ID mismatch error
2019-02-22 5:37 ` kraxel
@ 2019-02-22 18:05 ` Alistair Francis
0 siblings, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2019-02-22 18:05 UTC (permalink / raw)
To: kraxel
Cc: Alistair Francis, virtualization, dri-devel, linux-kernel,
david.abdurachmanov, linux-riscv
On Thu, Feb 21, 2019 at 9:37 PM kraxel@redhat.com <kraxel@redhat.com> wrote:
>
> On Thu, Feb 21, 2019 at 10:44:06AM -0800, Alistair Francis wrote:
> > On Thu, Feb 21, 2019 at 3:52 AM kraxel@redhat.com <kraxel@redhat.com> wrote:
> > >
> > > On Thu, Feb 21, 2019 at 12:33:03AM +0000, Alistair Francis wrote:
> > > > When running RISC-V QEMU with the Bochs device attached via PCIe the
> > > > probe of the Bochs device fails with:
> > > > [drm:bochs_hw_init] *ERROR* ID mismatch
> > > >
> > > > This was introduced by this commit:
> > > > 7780eb9ce8 bochs: convert to drm_dev_register
> > > >
> > > > To fix the error we ensure that pci_enable_device() is called before
> > > > bochs_load().
> > > >
> > > > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > > > Reported-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> > >
> > > Pushed to drm-misc-fixes.
> >
> > Thanks. Any chance this will make it into 5.0?
>
> Hmm, we are damn close to the release, not sure there will be one more
> drm-fixes pull req. But I've added a proper Fixes: tag, so even if the
> patch misses the boat it should land in the stable branches shortly
> thereafter.
Landing in the stable branches is probably enough. If you do end up
sending another pull request it would be great if this gets in. It
would be nice to have this fixed in the official 5.0 tag.
Alistair
>
> cheers,
> Gerd
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-22 18:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-21 0:33 [PATCH] drm/bochs: Fix the ID mismatch error Alistair Francis
2019-02-21 11:52 ` kraxel
2019-02-21 18:44 ` Alistair Francis
2019-02-22 5:37 ` kraxel
2019-02-22 18:05 ` Alistair Francis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).