* [PATCH net-next] rocker: Add missing break for PRE_BRIDGE_FLAGS
@ 2019-02-22 2:26 Florian Fainelli
2019-02-22 5:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2019-02-22 2:26 UTC (permalink / raw)
To: netdev; +Cc: sfr, Florian Fainelli, Jiri Pirko, David S. Miller, open list
A missing break keyword should have been added after adding support for
PRE_BRIDGE_FLAGS.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 93700458ff63 ("rocker: Check Handle PORT_PRE_BRIDGE_FLAGS")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/rocker/rocker_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c
index 8200fbf91306..309a6bf9130c 100644
--- a/drivers/net/ethernet/rocker/rocker_main.c
+++ b/drivers/net/ethernet/rocker/rocker_main.c
@@ -2083,6 +2083,7 @@ static int rocker_port_attr_set(struct net_device *dev,
err = rocker_world_port_attr_pre_bridge_flags_set(rocker_port,
attr->u.brport_flags,
trans);
+ break;
case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS:
err = rocker_world_port_attr_bridge_flags_set(rocker_port,
attr->u.brport_flags,
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] rocker: Add missing break for PRE_BRIDGE_FLAGS
2019-02-22 2:26 [PATCH net-next] rocker: Add missing break for PRE_BRIDGE_FLAGS Florian Fainelli
@ 2019-02-22 5:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-02-22 5:29 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, sfr, jiri, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 21 Feb 2019 18:26:46 -0800
> A missing break keyword should have been added after adding support for
> PRE_BRIDGE_FLAGS.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 93700458ff63 ("rocker: Check Handle PORT_PRE_BRIDGE_FLAGS")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
This turned out to be a really rough series for your Florian :-) :-)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-22 5:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-22 2:26 [PATCH net-next] rocker: Add missing break for PRE_BRIDGE_FLAGS Florian Fainelli
2019-02-22 5:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).