From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jim Broadus <jbroadus@gmail.com>,
Linux I2C <linux-i2c@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: Allow recovery of the initial IRQ by an I2C client device.
Date: Fri, 22 Feb 2019 10:30:19 +0000 [thread overview]
Message-ID: <20190222103019.GD130153@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20190222102335.GA1771@kunai>
On Fri, Feb 22, 2019 at 11:23:35AM +0100, Wolfram Sang wrote:
> On Fri, Feb 22, 2019 at 11:15:59AM +0100, Benjamin Tissoires wrote:
> > On Fri, Feb 22, 2019 at 12:26 AM Wolfram Sang <wsa@the-dreams.de> wrote:
> > > On Tue, Feb 19, 2019 at 11:30:27AM -0800, Jim Broadus wrote:
> > > > A previous change allowed I2C client devices to discover new IRQs upon
> > > > reprobe by clearing the IRQ in i2c_device_remove. However, if an IRQ was
> > > > assigned in i2c_new_device, that information is lost.
> > > >
> > > > For example, the touchscreen and trackpad devices on a Dell Inspiron laptop
> > > > are I2C devices whose IRQs are defined by ACPI extended IRQ types. The
> > > > client device structures are initialized during an ACPI walk. After
> > > > removing the i2c_hid device, modprobe fails.
> > > >
> > > > This change caches the initial IRQ value in i2c_new_device and then resets
> > > > the client device IRQ to the initial value in i2c_device_remove.
> > > >
> > > > Fixes: 6f108dd70d30 ("i2c: Clear client->irq in i2c_device_remove")
> > > > Signed-off-by: Jim Broadus <jbroadus@gmail.com>
> > >
> > > Adding Benjamin to CC
> >
> > Sorry, I should have answered earlier.
> >
> > I am a little bit hesitant regarding this patch. The effect is
> > correct, and I indeed realized a few weeks ago that something were
> > wrong as we couldn't rmmod/modprobe i2c-hid.
> >
> > But I still have the feeling that the problem is not solved at the
> > right place. In i2c_new_device() we are storing parts of the fields of
> > struct i2c_board_info, and when resetting the irq we are losing
> > information. This patch solves that, but I wonder if the IRQ should
> > not be 'simply' set in i2c_device_probe(). This means we also need to
> > store the .resources of info, but I have a feeling this will be less
> > error prone in the future.
> >
> > But this is just my guts telling me something is not right. I would
> > perfectly understand if we want to get this merged ASAP.
> >
> > So given that the code is correct, this is my:
> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> >
> > But at least I have expressed my feelings :)
>
> Which I can relate to very much. I see the code solves the issue but my
> feeling is that we are patching around something which should be handled
> differently in general.
>
> Is somebody willing to research this further?
>
> Thanks for your input.
>
I would be willing to have more of a look at it but am slightly
nervous I am not right person as all the systems I currently work
with are DT based so don't really exemplify the issue at all.
Thanks,
Charles
next prev parent reply other threads:[~2019-02-22 10:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 0:15 [PATCH] i2c: Allow recovery of the initial IRQ by a i2c client device Jim Broadus
2019-02-18 10:06 ` Charles Keepax
2019-02-18 18:25 ` Jim Broadus
2019-02-19 19:30 ` [PATCH] i2c: Allow recovery of the initial IRQ by an I2C " Jim Broadus
2019-02-19 19:32 ` Jim Broadus
2019-02-21 23:26 ` Wolfram Sang
2019-02-22 10:15 ` Benjamin Tissoires
2019-02-22 10:23 ` Wolfram Sang
2019-02-22 10:30 ` Charles Keepax [this message]
2019-02-22 11:31 ` Wolfram Sang
2019-02-22 18:47 ` Jim Broadus
2019-02-22 23:16 ` Wolfram Sang
2019-02-22 10:28 ` Charles Keepax
2019-02-24 13:51 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222103019.GD130153@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jbroadus@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).