From: Jim Broadus <jbroadus@gmail.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: benjamin.tissoires@redhat.com, wsa@the-dreams.de,
linux-i2c@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: Allow recovery of the initial IRQ by a i2c client device.
Date: Mon, 18 Feb 2019 10:25:10 -0800 [thread overview]
Message-ID: <CAKgEEwsOHqV-PtJnc-5nXAuH3BVitXWt80eoENJa3wZ6vGZDpw@mail.gmail.com> (raw)
In-Reply-To: <20190218100652.GB27940@ediswmail.ad.cirrus.com>
Thank you Charles. I should probably correct the typos in my commit message.
On Mon, Feb 18, 2019 at 2:06 AM Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:
>
> On Fri, Feb 15, 2019 at 04:15:33PM -0800, Jim Broadus wrote:
> > A previous change allowed i2c client devices to discover new IRQs upon
> > reprobe. By clearing the IRQ in i2c_device_remove. However, if an IRQ was
> > assigned in i2c_new_device, that information is lost.
> >
> > For example, the touchscreen and trackpad devices on a Dell Inspiron laptop
> > are I2C devices whose IRQs are defined by ACPI extended IRQ types. The
> > client device structures are initialized during an ACPI walk. After
> > removing the i2c_hid device, modprobe fails.
> >
> > This change caches the initial IRQ value in i2c_new_device and then resets
> > the client device IRQ to the initial value in i2c_device_remove.
> >
> > Fixes: 6f108dd70d30 ("i2c: Clear client->irq in i2c_device_remove")
> > Signed-off-by: Jim Broadus <jbroadus@gmail.com>
> > ---
>
> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
>
> Apologies for the issues caused. I think this looks like a good fix
> to me.
>
> Thanks,
> Charles
next prev parent reply other threads:[~2019-02-18 18:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 0:15 [PATCH] i2c: Allow recovery of the initial IRQ by a i2c client device Jim Broadus
2019-02-18 10:06 ` Charles Keepax
2019-02-18 18:25 ` Jim Broadus [this message]
2019-02-19 19:30 ` [PATCH] i2c: Allow recovery of the initial IRQ by an I2C " Jim Broadus
2019-02-19 19:32 ` Jim Broadus
2019-02-21 23:26 ` Wolfram Sang
2019-02-22 10:15 ` Benjamin Tissoires
2019-02-22 10:23 ` Wolfram Sang
2019-02-22 10:30 ` Charles Keepax
2019-02-22 11:31 ` Wolfram Sang
2019-02-22 18:47 ` Jim Broadus
2019-02-22 23:16 ` Wolfram Sang
2019-02-22 10:28 ` Charles Keepax
2019-02-24 13:51 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKgEEwsOHqV-PtJnc-5nXAuH3BVitXWt80eoENJa3wZ6vGZDpw@mail.gmail.com \
--to=jbroadus@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).