linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845
@ 2019-02-25 13:54 Cheng-Yi Chiang
  2019-02-25 14:37 ` Enric Balletbo i Serra
  2019-02-26 12:06 ` Applied "ASoC: qcom: Kconfig: fix dependency for sdm845" to the asoc tree Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Cheng-Yi Chiang @ 2019-02-25 13:54 UTC (permalink / raw)
  To: linux-kernel
  Cc: Mark Brown, alsa-devel, enric.balletbo, rdunlap, ncrews, bleung,
	dgreid, tzungbi, Rohit kumar, Cheng-Yi Chiang

SND_SOC_CROS_EC_CODEC depends on MFD_CROS_EC.
Add that dependency to SND_SOC_SDM845 to fix unmet direct dependencies
warning.

Fixes: 74c6ecf4194e (ASoC: qcom: Kconfig: select dmic for sdm845)
Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
---
 sound/soc/qcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
index 8f206cb4fcc0..75ceb04d8bf0 100644
--- a/sound/soc/qcom/Kconfig
+++ b/sound/soc/qcom/Kconfig
@@ -98,7 +98,7 @@ config SND_SOC_MSM8996
 
 config SND_SOC_SDM845
 	tristate "SoC Machine driver for SDM845 boards"
-	depends on QCOM_APR
+	depends on QCOM_APR && MFD_CROS_EC
 	select SND_SOC_QDSP6
 	select SND_SOC_QCOM_COMMON
 	select SND_SOC_RT5663
-- 
2.21.0.rc0.258.g878e2cd30e-goog


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845
  2019-02-25 13:54 [PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845 Cheng-Yi Chiang
@ 2019-02-25 14:37 ` Enric Balletbo i Serra
  2019-02-25 16:29   ` Randy Dunlap
  2019-02-26 12:06 ` Applied "ASoC: qcom: Kconfig: fix dependency for sdm845" to the asoc tree Mark Brown
  1 sibling, 1 reply; 4+ messages in thread
From: Enric Balletbo i Serra @ 2019-02-25 14:37 UTC (permalink / raw)
  To: Cheng-Yi Chiang, linux-kernel
  Cc: Mark Brown, alsa-devel, rdunlap, ncrews, bleung, dgreid, tzungbi,
	Rohit kumar

Hi,

On 25/2/19 14:54, Cheng-Yi Chiang wrote:
> SND_SOC_CROS_EC_CODEC depends on MFD_CROS_EC.
> Add that dependency to SND_SOC_SDM845 to fix unmet direct dependencies
> warning.
> 
> Fixes: 74c6ecf4194e (ASoC: qcom: Kconfig: select dmic for sdm845)

Reported-by: Randy Dunlap <rdunlap@infradead.org>

> Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>

Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Thanks,
Enric

> ---
>  sound/soc/qcom/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
> index 8f206cb4fcc0..75ceb04d8bf0 100644
> --- a/sound/soc/qcom/Kconfig
> +++ b/sound/soc/qcom/Kconfig
> @@ -98,7 +98,7 @@ config SND_SOC_MSM8996
>  
>  config SND_SOC_SDM845
>  	tristate "SoC Machine driver for SDM845 boards"
> -	depends on QCOM_APR
> +	depends on QCOM_APR && MFD_CROS_EC
>  	select SND_SOC_QDSP6
>  	select SND_SOC_QCOM_COMMON
>  	select SND_SOC_RT5663
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845
  2019-02-25 14:37 ` Enric Balletbo i Serra
@ 2019-02-25 16:29   ` Randy Dunlap
  0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2019-02-25 16:29 UTC (permalink / raw)
  To: Enric Balletbo i Serra, Cheng-Yi Chiang, linux-kernel
  Cc: Mark Brown, alsa-devel, ncrews, bleung, dgreid, tzungbi, Rohit kumar

On 2/25/19 6:37 AM, Enric Balletbo i Serra wrote:
> Hi,
> 
> On 25/2/19 14:54, Cheng-Yi Chiang wrote:
>> SND_SOC_CROS_EC_CODEC depends on MFD_CROS_EC.
>> Add that dependency to SND_SOC_SDM845 to fix unmet direct dependencies
>> warning.
>>
>> Fixes: 74c6ecf4194e (ASoC: qcom: Kconfig: select dmic for sdm845)
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> 
>> Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
> 
> Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> 
> Thanks,
> Enric

Works for me.  Thanks.

Tested-by: Randy Dunlap <rdunlap@infradead.org>

>> ---
>>  sound/soc/qcom/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
>> index 8f206cb4fcc0..75ceb04d8bf0 100644
>> --- a/sound/soc/qcom/Kconfig
>> +++ b/sound/soc/qcom/Kconfig
>> @@ -98,7 +98,7 @@ config SND_SOC_MSM8996
>>  
>>  config SND_SOC_SDM845
>>  	tristate "SoC Machine driver for SDM845 boards"
>> -	depends on QCOM_APR
>> +	depends on QCOM_APR && MFD_CROS_EC
>>  	select SND_SOC_QDSP6
>>  	select SND_SOC_QCOM_COMMON
>>  	select SND_SOC_RT5663
>>


-- 
~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Applied "ASoC: qcom: Kconfig: fix dependency for sdm845" to the asoc tree
  2019-02-25 13:54 [PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845 Cheng-Yi Chiang
  2019-02-25 14:37 ` Enric Balletbo i Serra
@ 2019-02-26 12:06 ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2019-02-26 12:06 UTC (permalink / raw)
  To: Cheng-Yi Chiang
  Cc: Randy Dunlap, Enric Balletbo i Serra, Randy Dunlap, Mark Brown,
	linux-kernel, alsa-devel, ncrews, rdunlap, tzungbi, Mark Brown,
	Rohit kumar, enric.balletbo, dgreid, bleung, alsa-devel

The patch

   ASoC: qcom: Kconfig: fix dependency for sdm845

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From cdcdba5d624fc3fbad224230ca318c6ddf73795a Mon Sep 17 00:00:00 2001
From: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Mon, 25 Feb 2019 21:54:05 +0800
Subject: [PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845

SND_SOC_CROS_EC_CODEC depends on MFD_CROS_EC.
Add that dependency to SND_SOC_SDM845 to fix unmet direct dependencies
warning.

Fixes: 74c6ecf4194e (ASoC: qcom: Kconfig: select dmic for sdm845)
Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/qcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
index 8f206cb4fcc0..75ceb04d8bf0 100644
--- a/sound/soc/qcom/Kconfig
+++ b/sound/soc/qcom/Kconfig
@@ -98,7 +98,7 @@ config SND_SOC_MSM8996
 
 config SND_SOC_SDM845
 	tristate "SoC Machine driver for SDM845 boards"
-	depends on QCOM_APR
+	depends on QCOM_APR && MFD_CROS_EC
 	select SND_SOC_QDSP6
 	select SND_SOC_QCOM_COMMON
 	select SND_SOC_RT5663
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-26 12:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-25 13:54 [PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845 Cheng-Yi Chiang
2019-02-25 14:37 ` Enric Balletbo i Serra
2019-02-25 16:29   ` Randy Dunlap
2019-02-26 12:06 ` Applied "ASoC: qcom: Kconfig: fix dependency for sdm845" to the asoc tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).