linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Vinod Koul <vkoul@kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alexandru Ardelean <alexandru.ardelean@analog.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: linux-next: manual merge of the slave-dma tree with Linus' tree
Date: Tue, 26 Feb 2019 15:24:17 +1100	[thread overview]
Message-ID: <20190226152417.29e1f3ed@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 4248 bytes --]

Hi Vinod,

Today's linux-next merge of the slave-dma tree got a conflict in:

  drivers/dma/dmatest.c

between commit:

  6454368a804c ("dmaengine: dmatest: Abort test in case of mapping error")

from Linus' tree and commit:

  361deb7243d2 ("dmaengine: dmatest: wrap src & dst data into a struct")

from the slave-dma tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/dma/dmatest.c
index 6511928b4cdf,50221d467d86..000000000000
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@@ -708,12 -726,14 +726,12 @@@ static int dmatest_func(void *data
  
  			um->addr[i] = dma_map_page(dev->dev, pg, pg_off,
  						   um->len, DMA_TO_DEVICE);
- 			srcs[i] = um->addr[i] + src_off;
+ 			srcs[i] = um->addr[i] + src->off;
  			ret = dma_mapping_error(dev->dev, um->addr[i]);
  			if (ret) {
 -				dmaengine_unmap_put(um);
  				result("src mapping error", total_tests,
- 				       src_off, dst_off, len, ret);
+ 				       src->off, dst->off, len, ret);
 -				failed_tests++;
 -				continue;
 +				goto error_unmap_continue;
  			}
  			um->to_cnt++;
  		}
@@@ -728,9 -748,11 +746,9 @@@
  					       DMA_BIDIRECTIONAL);
  			ret = dma_mapping_error(dev->dev, dsts[i]);
  			if (ret) {
 -				dmaengine_unmap_put(um);
  				result("dst mapping error", total_tests,
- 				       src_off, dst_off, len, ret);
+ 				       src->off, dst->off, len, ret);
 -				failed_tests++;
 -				continue;
 +				goto error_unmap_continue;
  			}
  			um->bidi_cnt++;
  		}
@@@ -758,10 -780,12 +776,10 @@@
  		}
  
  		if (!tx) {
- 			result("prep error", total_tests, src_off,
- 			       dst_off, len, ret);
 -			dmaengine_unmap_put(um);
+ 			result("prep error", total_tests, src->off,
+ 			       dst->off, len, ret);
  			msleep(100);
 -			failed_tests++;
 -			continue;
 +			goto error_unmap_continue;
  		}
  
  		done->done = false;
@@@ -770,10 -794,12 +788,10 @@@
  		cookie = tx->tx_submit(tx);
  
  		if (dma_submit_error(cookie)) {
- 			result("submit error", total_tests, src_off,
- 			       dst_off, len, ret);
 -			dmaengine_unmap_put(um);
+ 			result("submit error", total_tests, src->off,
+ 			       dst->off, len, ret);
  			msleep(100);
 -			failed_tests++;
 -			continue;
 +			goto error_unmap_continue;
  		}
  		dma_async_issue_pending(chan);
  
@@@ -782,23 -808,25 +800,23 @@@
  
  		status = dma_async_is_tx_complete(chan, cookie, NULL, NULL);
  
 -		dmaengine_unmap_put(um);
 -
  		if (!done->done) {
- 			result("test timed out", total_tests, src_off, dst_off,
+ 			result("test timed out", total_tests, src->off, dst->off,
  			       len, 0);
 -			failed_tests++;
 -			continue;
 +			goto error_unmap_continue;
  		} else if (status != DMA_COMPLETE) {
  			result(status == DMA_ERROR ?
  			       "completion error status" :
- 			       "completion busy status", total_tests, src_off,
- 			       dst_off, len, ret);
+ 			       "completion busy status", total_tests, src->off,
+ 			       dst->off, len, ret);
 -			failed_tests++;
 -			continue;
 +			goto error_unmap_continue;
  		}
  
 +		dmaengine_unmap_put(um);
 +
  		if (params->noverify) {
- 			verbose_result("test passed", total_tests, src_off,
- 				       dst_off, len, 0);
+ 			verbose_result("test passed", total_tests, src->off,
+ 				       dst->off, len, 0);
  			continue;
  		}
  
@@@ -833,15 -861,9 +851,15 @@@
  			       len, error_count);
  			failed_tests++;
  		} else {
- 			verbose_result("test passed", total_tests, src_off,
- 				       dst_off, len, 0);
+ 			verbose_result("test passed", total_tests, src->off,
+ 				       dst->off, len, 0);
  		}
 +
 +		continue;
 +
 +error_unmap_continue:
 +		dmaengine_unmap_put(um);
 +		failed_tests++;
  	}
  	ktime = ktime_sub(ktime_get(), ktime);
  	ktime = ktime_sub(ktime, comparetime);

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2019-02-26  4:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26  4:24 Stephen Rothwell [this message]
2019-02-26 17:22 ` linux-next: manual merge of the slave-dma tree with Linus' tree Vinod Koul
  -- strict thread matches above, loose matches on Subject: below --
2020-03-12  5:26 Stephen Rothwell
2020-03-12  7:16 ` Peter Ujfalusi
2020-03-13 12:42   ` Vinod Koul
2019-06-11  6:32 Stephen Rothwell
2019-06-11 10:08 ` Vinod Koul
2019-01-23  2:41 Stephen Rothwell
2012-12-18 23:44 Stephen Rothwell
2012-03-27  0:45 Stephen Rothwell
2012-03-09  2:25 Stephen Rothwell
2011-08-26  1:46 Stephen Rothwell
2011-07-27  2:08 Stephen Rothwell
2011-07-27  3:12 ` Koul, Vinod
2011-07-27 16:25   ` Koul, Vinod
2011-07-27 20:19     ` Russell King - ARM Linux
2011-07-27 20:29       ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190226152417.29e1f3ed@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=alexandru.ardelean@analog.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).