linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] watchdog: smsc37b787_wdt: Mark expected switch fall-through
Date: Tue, 26 Feb 2019 09:45:07 -0800	[thread overview]
Message-ID: <20190226174507.GC8682@roeck-us.net> (raw)
In-Reply-To: <a9aad06b-7917-328d-30fb-1c3e873bbe35@embeddedor.com>

On Tue, Feb 26, 2019 at 11:42:06AM -0600, Gustavo A. R. Silva wrote:
> 
> 
> On 2/18/19 10:08 AM, Guenter Roeck wrote:
> > On 2/14/19 12:16 PM, Gustavo A. R. Silva wrote:
> >> In preparation to enabling -Wimplicit-fallthrough, mark switch
> >> cases where we are expecting to fall through.
> >>
> >> This patch fixes the following warning:
> >>
> >> drivers/watchdog/smsc37b787_wdt.c: In function ‘wb_smsc_wdt_ioctl’:
> >> drivers/watchdog/smsc37b787_wdt.c:480:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >>     wb_smsc_wdt_set_timeout(timeout);
> >>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> drivers/watchdog/smsc37b787_wdt.c:482:2: note: here
> >>    case WDIOC_GETTIMEOUT:
> >>    ^~~~
> >>
> >> Warning level 3 was used: -Wimplicit-fallthrough=3
> >>
> >> Notice that, in this particular case, the code comment is modified
> >> in accordance with what GCC is expecting to find.
> >>
> >> This patch is part of the ongoing efforts to enable
> >> -Wimplicit-fallthrough.
> >>
> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> > 
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > 
> 
> Thank you, Guenter.
> 
> 
> Friendly ping:
> 
> Who can take this?
> 

It is queued in my watchdog-next branch. Usually Wim will pick it up from there.

Guenter

  reply	other threads:[~2019-02-26 17:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 20:16 [PATCH] watchdog: smsc37b787_wdt: Mark expected switch fall-through Gustavo A. R. Silva
2019-02-18 16:08 ` Guenter Roeck
2019-02-26 17:42   ` Gustavo A. R. Silva
2019-02-26 17:45     ` Guenter Roeck [this message]
2019-02-28 18:27       ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190226174507.GC8682@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=gustavo@embeddedor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).