From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] watchdog: smsc37b787_wdt: Mark expected switch fall-through
Date: Tue, 26 Feb 2019 11:42:06 -0600 [thread overview]
Message-ID: <a9aad06b-7917-328d-30fb-1c3e873bbe35@embeddedor.com> (raw)
In-Reply-To: <b914131b-fd1d-2a99-4903-856e2808034d@roeck-us.net>
On 2/18/19 10:08 AM, Guenter Roeck wrote:
> On 2/14/19 12:16 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/watchdog/smsc37b787_wdt.c: In function ‘wb_smsc_wdt_ioctl’:
>> drivers/watchdog/smsc37b787_wdt.c:480:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> wb_smsc_wdt_set_timeout(timeout);
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/watchdog/smsc37b787_wdt.c:482:2: note: here
>> case WDIOC_GETTIMEOUT:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
Thank you, Guenter.
Friendly ping:
Who can take this?
Thanks
--
Gustavo
>> ---
>> drivers/watchdog/smsc37b787_wdt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/smsc37b787_wdt.c b/drivers/watchdog/smsc37b787_wdt.c
>> index 445ea1ad1fa9..c768dcd53034 100644
>> --- a/drivers/watchdog/smsc37b787_wdt.c
>> +++ b/drivers/watchdog/smsc37b787_wdt.c
>> @@ -478,7 +478,7 @@ static long wb_smsc_wdt_ioctl(struct file *file,
>> return -EINVAL;
>> timeout = new_timeout;
>> wb_smsc_wdt_set_timeout(timeout);
>> - /* fall through and return the new timeout... */
>> + /* fall through - and return the new timeout... */
>> case WDIOC_GETTIMEOUT:
>> new_timeout = timeout;
>> if (unit == UNIT_MINUTE)
>>
>
next prev parent reply other threads:[~2019-02-26 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 20:16 [PATCH] watchdog: smsc37b787_wdt: Mark expected switch fall-through Gustavo A. R. Silva
2019-02-18 16:08 ` Guenter Roeck
2019-02-26 17:42 ` Gustavo A. R. Silva [this message]
2019-02-26 17:45 ` Guenter Roeck
2019-02-28 18:27 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9aad06b-7917-328d-30fb-1c3e873bbe35@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).