[PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D panel support

linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D panel support
@ 2019-02-28 18:58 Paul Cercueil
  2019-02-28 18:58 ` [PATCH 2/2] drm/panel: Add GiantPlus GPM940B0 " Paul Cercueil
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Paul Cercueil @ 2019-02-28 18:58 UTC (permalink / raw)
  To: Thierry Reding, David Airlie, Daniel Vetter
  Cc: dri-devel, linux-kernel, Paul Cercueil

The Sharp LS020B1DD01D is a simple 2.0" 240x160 16-bit TFT panel.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: Artur Rojek <contact@artur-rojek.eu>
---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 9e8218f6a3f2..3ab604f5477e 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2278,6 +2278,31 @@ static const struct panel_desc sharp_lq150x1lg11 = {
 	.bus_format = MEDIA_BUS_FMT_RGB565_1X16,
 };
 
+static const struct display_timing sharp_ls020b1dd01d_timing = {
+	.pixelclock = { 2000000, 4200000, 5000000 },
+	.hactive = { 240, 240, 240 },
+	.hfront_porch = { 66, 66, 66 },
+	.hback_porch = { 1, 1, 1 },
+	.hsync_len = { 1, 1, 1 },
+	.vactive = { 160, 160, 160 },
+	.vfront_porch = { 52, 52, 52 },
+	.vback_porch = { 6, 6, 6 },
+	.vsync_len = { 10, 10, 10 },
+	.flags = DISPLAY_FLAGS_HSYNC_HIGH | DISPLAY_FLAGS_VSYNC_LOW,
+};
+
+static const struct panel_desc sharp_ls020b1dd01d = {
+	.timings = &sharp_ls020b1dd01d_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 42,
+		.height = 28,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB565_1X16,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
+};
+
 static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode = {
 	.clock = 33300,
 	.hdisplay = 800,
@@ -2767,6 +2792,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "sharp,lq150x1lg11",
 		.data = &sharp_lq150x1lg11,
 	}, {
+		.compatible = "sharp,ls020b1dd01d",
+		.data = &sharp_ls020b1dd01d,
+	}, {
 		.compatible = "shelly,sca07010-bfn-lnn",
 		.data = &shelly_sca07010_bfn_lnn,
 	}, {
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] drm/panel: Add GiantPlus GPM940B0 panel support
  2019-02-28 18:58 [PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D panel support Paul Cercueil
@ 2019-02-28 18:58 ` Paul Cercueil
  2019-02-28 18:58 ` [PATCH 2/2] drm/panel: simple: " Paul Cercueil
  2019-03-01 22:24 ` [PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D " Sam Ravnborg
  2 siblings, 0 replies; 5+ messages in thread
From: Paul Cercueil @ 2019-02-28 18:58 UTC (permalink / raw)
  To: Thierry Reding, David Airlie, Daniel Vetter
  Cc: dri-devel, linux-kernel, Paul Cercueil

The GiantPlus GPM940B0 is a simple 3.0" 320x240 24-bit TFT panel.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: Artur Rojek <contact@artur-rojek.eu>
---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3ab604f5477e..a66aade78073 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1208,6 +1208,31 @@ static const struct panel_desc giantplus_gpg482739qs5 = {
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
 
+static const struct display_timing giantplus_gpm940b0_timing = {
+	.pixelclock = { 13500000, 27000000, 27500000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 14, 686, 718 },
+	.hback_porch = { 50, 70, 255 },
+	.hsync_len = { 1, 1, 1 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 1, 1, 179 },
+	.vback_porch = { 1, 21, 31 },
+	.vsync_len = { 1, 1, 6 },
+	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW,
+};
+
+static const struct panel_desc giantplus_gpm940b0 = {
+	.timings = &giantplus_gpm940b0_timing,
+	.num_timings = 1,
+	.bpc = 8,
+	.size = {
+		.width = 60,
+		.height = 45,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
+};
+
 static const struct display_timing hannstar_hsd070pww1_timing = {
 	.pixelclock = { 64300000, 71100000, 82000000 },
 	.hactive = { 1280, 1280, 1280 },
@@ -2666,6 +2691,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "giantplus,gpg482739qs5",
 		.data = &giantplus_gpg482739qs5
 	}, {
+		.compatible = "giantplus,gpm940b0",
+		.data = &giantplus_gpm940b0,
+	}, {
 		.compatible = "hannstar,hsd070pww1",
 		.data = &hannstar_hsd070pww1,
 	}, {
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] drm/panel: simple: Add GiantPlus GPM940B0 panel support
  2019-02-28 18:58 [PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D panel support Paul Cercueil
  2019-02-28 18:58 ` [PATCH 2/2] drm/panel: Add GiantPlus GPM940B0 " Paul Cercueil
@ 2019-02-28 18:58 ` Paul Cercueil
  2019-03-01 22:24 ` [PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D " Sam Ravnborg
  2 siblings, 0 replies; 5+ messages in thread
From: Paul Cercueil @ 2019-02-28 18:58 UTC (permalink / raw)
  To: Thierry Reding, David Airlie, Daniel Vetter
  Cc: dri-devel, linux-kernel, Paul Cercueil

The GiantPlus GPM940B0 is a simple 3.0" 320x240 24-bit TFT panel.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: Artur Rojek <contact@artur-rojek.eu>
---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3ab604f5477e..a66aade78073 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1208,6 +1208,31 @@ static const struct panel_desc giantplus_gpg482739qs5 = {
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
 
+static const struct display_timing giantplus_gpm940b0_timing = {
+	.pixelclock = { 13500000, 27000000, 27500000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 14, 686, 718 },
+	.hback_porch = { 50, 70, 255 },
+	.hsync_len = { 1, 1, 1 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 1, 1, 179 },
+	.vback_porch = { 1, 21, 31 },
+	.vsync_len = { 1, 1, 6 },
+	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW,
+};
+
+static const struct panel_desc giantplus_gpm940b0 = {
+	.timings = &giantplus_gpm940b0_timing,
+	.num_timings = 1,
+	.bpc = 8,
+	.size = {
+		.width = 60,
+		.height = 45,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
+};
+
 static const struct display_timing hannstar_hsd070pww1_timing = {
 	.pixelclock = { 64300000, 71100000, 82000000 },
 	.hactive = { 1280, 1280, 1280 },
@@ -2666,6 +2691,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "giantplus,gpg482739qs5",
 		.data = &giantplus_gpg482739qs5
 	}, {
+		.compatible = "giantplus,gpm940b0",
+		.data = &giantplus_gpm940b0,
+	}, {
 		.compatible = "hannstar,hsd070pww1",
 		.data = &hannstar_hsd070pww1,
 	}, {
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D panel support
  2019-02-28 18:58 [PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D panel support Paul Cercueil
  2019-02-28 18:58 ` [PATCH 2/2] drm/panel: Add GiantPlus GPM940B0 " Paul Cercueil
  2019-02-28 18:58 ` [PATCH 2/2] drm/panel: simple: " Paul Cercueil
@ 2019-03-01 22:24 ` Sam Ravnborg
  2019-03-01 22:42   ` Paul Cercueil
  2 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2019-03-01 22:24 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: Thierry Reding, David Airlie, Daniel Vetter, linux-kernel, dri-devel

Hi Paul.

On Thu, Feb 28, 2019 at 03:58:52PM -0300, Paul Cercueil wrote:
> The Sharp LS020B1DD01D is a simple 2.0" 240x160 16-bit TFT panel.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Tested-by: Artur Rojek <contact@artur-rojek.eu>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 9e8218f6a3f2..3ab604f5477e 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2278,6 +2278,31 @@ static const struct panel_desc sharp_lq150x1lg11 = {
>  	.bus_format = MEDIA_BUS_FMT_RGB565_1X16,
>  };
>  
> +static const struct display_timing sharp_ls020b1dd01d_timing = {
> +	.pixelclock = { 2000000, 4200000, 5000000 },
> +	.hactive = { 240, 240, 240 },
> +	.hfront_porch = { 66, 66, 66 },
> +	.hback_porch = { 1, 1, 1 },
> +	.hsync_len = { 1, 1, 1 },
> +	.vactive = { 160, 160, 160 },
> +	.vfront_porch = { 52, 52, 52 },
> +	.vback_porch = { 6, 6, 6 },
> +	.vsync_len = { 10, 10, 10 },
> +	.flags = DISPLAY_FLAGS_HSYNC_HIGH | DISPLAY_FLAGS_VSYNC_LOW,
> +};
> +
> +static const struct panel_desc sharp_ls020b1dd01d = {
> +	.timings = &sharp_ls020b1dd01d_timing,
> +	.num_timings = 1,
> +	.bpc = 6,
> +	.size = {
> +		.width = 42,
> +		.height = 28,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB565_1X16,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
> +};
> +
>  static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode = {
>  	.clock = 33300,
>  	.hdisplay = 800,
> @@ -2767,6 +2792,9 @@ static const struct of_device_id platform_of_match[] = {
>  		.compatible = "sharp,lq150x1lg11",
>  		.data = &sharp_lq150x1lg11,
>  	}, {
> +		.compatible = "sharp,ls020b1dd01d",
> +		.data = &sharp_ls020b1dd01d,
> +	}, {
For all three patches I am missing dt-bindings documentation.

also for all three patches you get a "+1" for adding all of
.flags, .bus_format, .bus_flags.

	Sam

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D panel support
  2019-03-01 22:24 ` [PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D " Sam Ravnborg
@ 2019-03-01 22:42   ` Paul Cercueil
  0 siblings, 0 replies; 5+ messages in thread
From: Paul Cercueil @ 2019-03-01 22:42 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: Thierry Reding, David Airlie, Daniel Vetter, linux-kernel, dri-devel

Hi,

Le ven. 1 mars 2019 à 19:24, Sam Ravnborg <sam@ravnborg.org> a écrit :
> Hi Paul.
> 
> On Thu, Feb 28, 2019 at 03:58:52PM -0300, Paul Cercueil wrote:
>>  The Sharp LS020B1DD01D is a simple 2.0" 240x160 16-bit TFT panel.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  Tested-by: Artur Rojek <contact@artur-rojek.eu>
>>  ---
>>   drivers/gpu/drm/panel/panel-simple.c | 28 
>> ++++++++++++++++++++++++++++
>>   1 file changed, 28 insertions(+)
>> 
>>  diff --git a/drivers/gpu/drm/panel/panel-simple.c 
>> b/drivers/gpu/drm/panel/panel-simple.c
>>  index 9e8218f6a3f2..3ab604f5477e 100644
>>  --- a/drivers/gpu/drm/panel/panel-simple.c
>>  +++ b/drivers/gpu/drm/panel/panel-simple.c
>>  @@ -2278,6 +2278,31 @@ static const struct panel_desc 
>> sharp_lq150x1lg11 = {
>>   	.bus_format = MEDIA_BUS_FMT_RGB565_1X16,
>>   };
>> 
>>  +static const struct display_timing sharp_ls020b1dd01d_timing = {
>>  +	.pixelclock = { 2000000, 4200000, 5000000 },
>>  +	.hactive = { 240, 240, 240 },
>>  +	.hfront_porch = { 66, 66, 66 },
>>  +	.hback_porch = { 1, 1, 1 },
>>  +	.hsync_len = { 1, 1, 1 },
>>  +	.vactive = { 160, 160, 160 },
>>  +	.vfront_porch = { 52, 52, 52 },
>>  +	.vback_porch = { 6, 6, 6 },
>>  +	.vsync_len = { 10, 10, 10 },
>>  +	.flags = DISPLAY_FLAGS_HSYNC_HIGH | DISPLAY_FLAGS_VSYNC_LOW,
>>  +};
>>  +
>>  +static const struct panel_desc sharp_ls020b1dd01d = {
>>  +	.timings = &sharp_ls020b1dd01d_timing,
>>  +	.num_timings = 1,
>>  +	.bpc = 6,
>>  +	.size = {
>>  +		.width = 42,
>>  +		.height = 28,
>>  +	},
>>  +	.bus_format = MEDIA_BUS_FMT_RGB565_1X16,
>>  +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
>>  +};
>>  +
>>   static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode 
>> = {
>>   	.clock = 33300,
>>   	.hdisplay = 800,
>>  @@ -2767,6 +2792,9 @@ static const struct of_device_id 
>> platform_of_match[] = {
>>   		.compatible = "sharp,lq150x1lg11",
>>   		.data = &sharp_lq150x1lg11,
>>   	}, {
>>  +		.compatible = "sharp,ls020b1dd01d",
>>  +		.data = &sharp_ls020b1dd01d,
>>  +	}, {
> For all three patches I am missing dt-bindings documentation.

Yes, I looked at 
Documentation/devicetree/bindings/display/panel/simple-panel.txt,
and saw that it was never documented with new compatible strings, so I 
thought
that for this driver it wasn't needed. I didn't see the other files. 
I'll add
the dt-bindings doc in V2.

> also for all three patches you get a "+1" for adding all of
> .flags, .bus_format, .bus_flags.
> 
> 	Sam

Thanks,
-Paul


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-03-01 22:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-28 18:58 [PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D panel support Paul Cercueil
2019-02-28 18:58 ` [PATCH 2/2] drm/panel: Add GiantPlus GPM940B0 " Paul Cercueil
2019-02-28 18:58 ` [PATCH 2/2] drm/panel: simple: " Paul Cercueil
2019-03-01 22:24 ` [PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D " Sam Ravnborg
2019-03-01 22:42   ` Paul Cercueil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).