From: Greg KH <gregkh@linuxfoundation.org>
To: Oryan Perlmutter <oryan.perl1997@gmail.com>
Cc: martyn@welchs.me.uk, manohar.vanga@gmail.com,
devel@driverdev.osuosl.org, trivial@kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Coding style fixes on vme_user.c trivial
Date: Fri, 1 Mar 2019 16:18:04 +0100 [thread overview]
Message-ID: <20190301151804.GA31958@kroah.com> (raw)
In-Reply-To: <20190301142726.23969-1-oryan.perl1997@gmail.com>
On Fri, Mar 01, 2019 at 04:27:25PM +0200, Oryan Perlmutter wrote:
> drivers/staging/devices: Coding style fixes found at file vme_user.c.
Your subject line, and this changelog text, need a lot of work. Please
look at the other patches that have been accepted for this driver as
examples of how to do this properly.
>
> Signed-off-by: Oryan Perlmutter <oryan.perl1997@gmail.com>
> ---
> drivers/staging/vme/devices/vme_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index 6a33aaa1a49f..4c7db4f5f15e 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -506,7 +506,7 @@ static int vme_user_match(struct vme_dev *vdev)
> int cur_slot = vme_slot_num(vdev);
>
> for (i = 0; i < bus_num; i++)
> - if ((cur_bus == bus[i]) && (cur_slot == vdev->num))
> + if (cur_bus == bus[i] && cur_slot == vdev->num)
Personally, I like the original code here, it's more explicit as to what
is going on.
thanks,
greg k-h
prev parent reply other threads:[~2019-03-01 15:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 14:27 [PATCH] Coding style fixes on vme_user.c trivial Oryan Perlmutter
2019-03-01 15:18 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301151804.GA31958@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=oryan.perl1997@gmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).